Angband Forums

Angband Forums (http://angband.oook.cz/forum/index.php)
-   Vanilla (http://angband.oook.cz/forum/forumdisplay.php?f=3)
-   -   [3.5-dev] Possible crash on cavern levels (http://angband.oook.cz/forum/showthread.php?t=6050)

PowerWyrm May 2, 2013 09:39

[3.5-dev] Possible crash on cavern levels
 
Since the removal of the in_bounds macros, I think it's possible to crash the game on cavern levels because the layout doesn't generate permanent walls outside of the cavern bounds.

See init_cavern():

Code:

/* Fill the edges with perma-rock, and rest with rock */
draw_rectangle(c, 0, 0, DUNGEON_HGT - 1, DUNGEON_WID - 1, FEAT_PERM_SOLID);
fill_rectangle(c, 1, 1, DUNGEON_HGT - 2, DUNGEON_WID - 2, FEAT_WALL_SOLID);

compared to the same code for the town:

Code:

/* Start with solid walls, and then create some floor in the middle */
fill_rectangle(c, 0, 0, DUNGEON_HGT - 1, DUNGEON_WID - 1, FEAT_PERM_SOLID);
fill_rectangle(c, 1, 1, c->height -2, c->width - 2, FEAT_FLOOR);


PowerWyrm May 2, 2013 09:55

The best would be to ensure that everything outside cave bounds is FEAT_PERM_SOLID, so that nothing can be placed there.

eMeM May 4, 2013 20:58

1 Attachment(s)
I'm playing current dev version and there is a display problem on cavern levels

scud May 4, 2013 21:02

You've somehow managed to access the top secret multi-player mode.

Shhhh. Tell no-one.

Nick May 4, 2013 23:52

Quote:

Originally Posted by eMeM (Post 79813)
I'm playing current dev version and there is a display problem on cavern levels

Yep, I've found that bug too. Refreshing the screen fixes it.

eMeM May 7, 2013 15:55

1 Attachment(s)
Multiplayer on maze level ;)


All times are GMT +1. The time now is 09:28.

Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2018, vBulletin Solutions Inc.