Angband Forums

Angband Forums (http://angband.oook.cz/forum/index.php)
-   Vanilla (http://angband.oook.cz/forum/forumdisplay.php?f=3)
-   -   5 May 2011 development release(s) (http://angband.oook.cz/forum/showthread.php?t=4416)

PowerDiver May 5, 2011 22:38

There seems to have been a change, as of the 4/22 stuff I have been messing with, that gives monsters saving throws when they didn't use to have them. I couldn't even ID a wand [sleep monster I think] with repeated aims at a cutpurse. Was there any change to that in this 5/5 release?

d_m May 5, 2011 22:40

Quote:

Originally Posted by PowerDiver (Post 52501)
There seems to have been a change, as of the 4/22 stuff I have been messing with, that gives monsters saving throws when they didn't use to have them. I couldn't even ID a wand [sleep monster I think] with repeated aims at a cutpurse. Was there any change to that in this 5/5 release?

I don't remember this, but I'll take a look for a commit on 4/22 that introduces this.

Sure does seem like a bug.

Chud May 6, 2011 01:01

Quote:

Originally Posted by Chud (Post 52492)
There also seems to be a bug in item stacking

Noticed this in the dungeon now too; I found !CCW that won't stack with my inventory, and also a spellbook that similarly won't stack. It seems not to be related to inscriptions (my first though was hmm, these are both auto-inscribe items) - I tried removing the inscriptions and removing the auto-inscribe setting, no effect.

My character is a CL27 Mage, and this only started happening recently - I'm not sure what changed. The savefile and pref files were copied over from the previous release (Apr 23) if that is relevant. Should I open a ticket for this, even though I'm not a developer? I'm not sure what the correct process is here. :)

PowerDiver May 6, 2011 01:17

Quote:

Originally Posted by d_m (Post 52502)
I don't remember this, but I'll take a look for a commit on 4/22 that introduces this.

Sure does seem like a bug.

I was wondering if it's completely unintentional, or a goof on something similar but intentional.

Don't look too hard. The previous nightly I have is dated 1/13, so it could have been introduced much earlier.

Taha May 6, 2011 03:27

The was a failure to ID wands and staves by use bug a little while back. It was related to sleep / confuse / slow monsters I think. Can't find the ticket or thread right now, but pretty sure it was fixed in the last build I played.
________
ExoticMae cam

Magnate May 6, 2011 10:40

Quote:

Originally Posted by Chud (Post 52522)
Noticed this in the dungeon now too; I found !CCW that won't stack with my inventory, and also a spellbook that similarly won't stack. It seems not to be related to inscriptions (my first though was hmm, these are both auto-inscribe items) - I tried removing the inscriptions and removing the auto-inscribe setting, no effect.

My character is a CL27 Mage, and this only started happening recently - I'm not sure what changed. The savefile and pref files were copied over from the previous release (Apr 23) if that is relevant. Should I open a ticket for this, even though I'm not a developer? I'm not sure what the correct process is here. :)

No, please don't open a ticket - we know what the problem is, but not why it's happening.

When a savefile is loaded, each object is read into memory using a function called rd_item_X, where X is the version number of the savefile. Object flag handling has now changed, so X was incremented to save and load the new flags properly using rd_item_3. I added code to rd_item_2 which should convert the flags of objects in old savefiles so that they stack properly with new objects, but for some reason this isn't working. The two relevant lines in rd_item_2 are

of_copy(o_ptr->flags, o_ptr->kind->base->flags);
of_union(o_ptr->flags, o_ptr->kind->flags);

We saw this bug in staging but couldn't see why it wasn't working, and assumed that it must have been an artefact of us all using savefiles we'd played in the staging branch, where things tend to get a bit muddled. I couldn't reproduce it with a "proper" old savefile.

But the assumption was wrong, and it is clearly a problem with the changes to object flags (ticket #120) and the rd_item_2 code.

All patches and suggestions welcome. In the meantime, apologies for the inconvenience w.r.t. stacking.

Magnate May 6, 2011 10:43

Quote:

Originally Posted by Taha (Post 52533)
The was a failure to ID wands and staves by use bug a little while back. It was related to sleep / confuse / slow monsters I think. Can't find the ticket or thread right now, but pretty sure it was fixed in the last build I played.

This was #1366 and was indeed closed about four weeks ago. Like d_m I am unaware of monsters getting additional saving throws for anything, but as Eddie says this could be an unintended side effect of something else. There has been a lot of refactoring of *player* saving throws to monster spells and breaths, but AFAICT that shouldn't yet have had any impact at all on monster saves. Definitely bears further observation though.

Magnate May 6, 2011 10:45

Quote:

Originally Posted by PowerDiver (Post 52489)
I was ready to port some code, but there were blocking(*) bugs. I think the first was the invisible purple monsters, but I don't really remember any more. Then a long progression in which a new blocking bug was introduced before the previous one was fixed. The dInvis bug is merely the last one.

You folks teased me a few times by closing all of the trac issues that bothered me, and then I'd find out something else got broken but hadn't been noticed yet. This better not be a repeat!

I don't mean the above as a complaint. You have to expect that sort of thing given the pace and nature of V development. I've just been waiting for a long time.

No worries - I'll be glad if there aren't any issues in this nightly that prevent you from porting.

What bothers me about this is that I don't have any real idea which bugs/issues you (and other forks) consider intolerable and which are just irritants. IMO it might be worth adding a "severity" field to trac so that we can distinguish tickets in this way, and focus on fixing the top-rated ones.

scud May 6, 2011 12:38

Previously I was under the impression that Enchant Weapon/Armour only got you as far as +10 before failing (or possibly being so unlikely to succeed that it was effectively 'impossible'). I've just dragged some arrows and speedy boots up to +15 levels. Nice.

Doesn't quite make up for losing my stock of books and scrolls and potions, though...

Derakon May 6, 2011 16:27

Yeah, the difficulty of enchanting was reduced awhile back. I couldn't tell you why, but at least in the case of armor it helps make up for the fact that you now need more AC than you used to.


All times are GMT +1. The time now is 06:21.

Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2022, vBulletin Solutions Inc.