Angband Forums

Angband Forums (http://angband.oook.cz/forum/index.php)
-   Variants (http://angband.oook.cz/forum/forumdisplay.php?f=4)
-   -   Equipment optimiser for frogcomposband characters (http://angband.oook.cz/forum/showthread.php?t=9602)

schatz March 4, 2020 11:54

Quote:

Originally Posted by ShadowTechnology (Post 141505)
Also, some of the Elemental Brands are not even being looked for:
|E and |P
(but |A, |F, and |Co are available for selection as attributes, and show up in the table)

Fixed as well. |E and |P should now be looked for in items and available as selection as attributes.

schatz March 4, 2020 11:58

Quote:

Originally Posted by Bostock (Post 141779)
Every attempt I make to access character #41 gives a 500 error. I was using it fine for quite a while before this happened.

Character 41 had an exclusion that has an empty value. This somehow matched everything so the solver barfed when it was given 0 items to solve for.

When this happens, I have added a message in the Solution text box below about the possibility of item exclusions excluding everything.

Have also made it such that one should not be able to create an empty valued exclusion entry.

Hopefully this resolves similar issues in the future.

schatz March 4, 2020 12:07

Quote:

Originally Posted by Bostock (Post 142891)
Although the optimiser is correctly respecting my restraints for *Fi>=1 and *Co>=1 (and thus using Nenya and Narya), the attribute list at the bottom shows *Fi and *Co as 0.

Character 48 (a Beholder).

The optimiser counts *Fi, *Co, *El, *Ac, etc. as different attributes from their respective Fi, Co, El, Ac attributes. Hence if you wear one *Fi item and have no other items worn that gives Fi, the attributes table will simply show:

Code:

Fi:  *0
Does that make sense? Or do you prefer if I present the attributes table as follows?

Code:

Fi:  0
*Fi:  1


schatz March 4, 2020 12:24

Quote:

Originally Posted by Bostock (Post 141787)
Another oddity: the Optimiser is only counting Nenya as 1Wm (and is perhaps undercounting it in other ways too, since it never picks Nenya unless forced). See character 43.

The app did not take into account the (+2) or (+3) values for Wm. This should be fixed now.

Quote:

Also, the first dump I uploaded that had the Dagger of Amun did not lead to that item being added to the item list. I tried putting it in my home and re-uploading, and then it was visible to the Optimiser.
I'm unable to replicate this. If this happens again for some other character, please can you keep a copy of the offending HTML dump file and send it to me? Thanks!

Susramanian March 5, 2020 02:18

Parsing bug?
 
In my character's pack, I have:

a Ring of Combat (+16,+14) {Fe}
The Ring of the Future King (+11,+8) (+2) {St;Di;Si(St}

but the Optimizer recommends I use
a Ring of Combat (+16,+14) {St;Di;Si(St}
which appears to be some weird combination of the two that doesn't actually exist.

I'm excited about this optimizer! Thanks for making it :)

schatz March 5, 2020 04:49

Quote:

Originally Posted by Susramanian (Post 143399)
In my character's pack, I have:

a Ring of Combat (+16,+14) {Fe}
The Ring of the Future King (+11,+8) (+2) {St;Di;Si(St}

but the Optimizer recommends I use
a Ring of Combat (+16,+14) {St;Di;Si(St}
which appears to be some weird combination of the two that doesn't actually exist.

This is what I'm seeing in the Solution box for your character:

Quote:

ring: a Ring of Combat (+16,+14) {Fe}
ring: The Ring of the Future King (+11,+8) (+2) {St;Di;Si(St}
I don't see this:

Quote:

a Ring of Combat (+16,+14) {St;Di;Si(St}
Please can you confirm that you are still seeing the wrong entry?

ShadowTechnology March 5, 2020 06:33

Quote:

Originally Posted by ShadowTechnology (Post 141505)
Also, some of the Elemental Brands are not even being looked for:
|E and |P
(but |A, |F, and |Co are available for selection as attributes, and show up in the table)

Thanks for fixing the issues I was having, especially missing the /* tag on some items. This is a handy tool and we are grateful for your effort and for sharing it with us.

Susramanian March 5, 2020 16:00

Quote:

Originally Posted by schatz (Post 143403)
This is what I'm seeing in the Solution box for your character:



I don't see this:



Please can you confirm that you are still seeing the wrong entry?

I kept a copy of the offending character dump, and it still results in the error. I can send it to you if that would help. What's the best way to do that?

Thanks for your hard work!

schatz March 5, 2020 16:04

Quote:

Originally Posted by Susramanian (Post 143419)
I kept a copy of the offending character dump, and it still results in the error. I can send it to you if that would help. What's the best way to do that?

Please send the HTML dump to optimiser@riverwaterhill.com and I will take a look. Thanks!

schatz March 6, 2020 03:55

Quote:

Originally Posted by schatz (Post 143420)
Please send the HTML dump to optimiser@riverwaterhill.com and I will take a look. Thanks!

Thanks for sending me the offending HTML dump.

The problem here is that within the Inventory section of the HTML dump, similar items of the same "coloring" is wrapped in a single <font> tag.

For instance,

Code:

<font color="#c00000">a Ring of Combat (+16,+14) {Fe}
The Ring of the Future King (+11,+8) (+2) {St;Di;Si(St}
</font>

and

Code:

<font color="#c08040">a Fur Cloak of Aman [3,+10] (+2) {SpSl;Sh}
a Large Leather Shield of Celestial Protection [6,+17] {DkSh}
</font>

This is different from the other sections where each item is wrapped within its own font tag.

The parser in Optimiser had assumed that the two rings are one item and hence the strange combined attribute item you see in your character earlier.

I have done a workaround by treating the Inventory section separately so it should work properly now for your character.

Hopefully this doesn't break something else.

By the way, this might explain the problem that Bostock had earlier:

Quote:

Also, the first dump I uploaded that had the Dagger of Amun did not lead to that item being added to the item list. I tried putting it in my home and re-uploading, and then it was visible to the Optimiser.
I'm suspecting that the dagger was in the inventory when he did the HTML dump. If it is worn or placed in home, it then "shows up" in the Optimiser.


All times are GMT +1. The time now is 18:57.

Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2021, vBulletin Solutions Inc.