View Single Post
Old March 24, 2016, 02:30   #5
takkaria
Veteran
 
takkaria's Avatar
 
Join Date: Apr 2007
Posts: 1,930
Donated: $40
takkaria is on a distinguished road
Hey, I'm familiar with the code and I think your plans are great and it's been needing doing for some time, especially standardising the file format and stopping every single different port reimplementing it. Here are the two comments I had that weren't "hurrah!":

Quote:
5. Replace calls to sound() with calls to msgt(), so
Code:
sound(MSG_MULTIPLY);
becomes
Code:
msgt(MSG_MULTIPLY, "");
I think in cases where there is no message but there is a sound hook, it's cleaner to keep a call to sound() rather than passing an empty string to msgt(), both because it requires no change to the API and semantically because the intended outcome is not to print a message but to make a sound.

Quote:
EDIT: We could just move the sound file names into message.prf

Code:
message:<message-type>:<color>:<sound file> <sound file> ... <sound file>
I think it's cleaner to keep sound file and message colours in separate places as it makes it easier to introduce new sound sets without touching stuff that isn't related to them.
__________________
takkaria whispers something about options. -more-
takkaria is offline   Reply With Quote