View Single Post
Old June 24, 2011, 14:44   #29
Angband Devteam member
d_m's Avatar
Join Date: Aug 2008
Location: Philadelphia, PA, USA
Age: 40
Posts: 1,516
d_m is on a distinguished road
Originally Posted by jens View Post
Yeay, it works! I have now successfully sent a pull request :-)

The thing I had missed was to make my local commit. I had read the start-up tutorials, and there when talking about contributing they only mentioned how to push your commits. I assumed that pushing commits meant commiting as well, but nope.

I tried to enter a better commit message, but I don't know vim, so it seems a bit of a hassle. How do you guys generally do it? Because when checking your commits you don't generally use one liners...
If you don't want to use vim, you can change which editor gets used by modifying your .bashrc/.profile, and adding something like:

export EDITOR=emacs
If you are a beginner you could use nano. I like emacs pretty well and other developers like vim.
d_m is offline   Reply With Quote