Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Development

Reply
 
Thread Tools Display Modes
Old June 20, 2011, 13:45   #1
jens
Swordsman
 
Join Date: Apr 2011
Location: Göteborg, Sweden
Posts: 348
jens is on a distinguished road
Multiple pvals with incorrect description

In my current game I have just found:
a Ring of the Mouse (+0,-7) <+3 stealth>

Which of course has +3 dex and +3 stealth, but the description could be a bit clearer, like:
a Ring of the Mouse (+0,-7) <+3>

Basically HIDE_TYPE if more than one flag present. (I actually feel that the type should always be hidden, and the flag HIDE_TYPE could be removed, but that is an other issue, and I guess others would disagree)
Attached Files
File Type: zip Calin.zip (7.4 KB, 161 views)
jens is offline   Reply With Quote
Old June 20, 2011, 14:02   #2
Timo Pietilä
Prophet
 
Join Date: Apr 2007
Location: Climbing up from hole I just dug.
Posts: 4,096
Timo Pietilä is on a distinguished road
Quote:
Originally Posted by jens View Post
In my current game I have just found:
a Ring of the Mouse (+0,-7) <+3 stealth>

Which of course has +3 dex and +3 stealth, but the description could be a bit clearer, like:
a Ring of the Mouse (+0,-7) <+3>

Basically HIDE_TYPE if more than one flag present. (I actually feel that the type should always be hidden, and the flag HIDE_TYPE could be removed, but that is an other issue, and I guess others would disagree)
Hiding the type in most cases makes sense: boots of speed/stealth <+x speed/stealth>, Amulet of Searching <+x Searching>, Cloak of Stealth <+x stealth>.

Plenty of useless repetition there.
Timo Pietilä is offline   Reply With Quote
Old June 20, 2011, 19:43   #3
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by Timo Pietilä View Post
Hiding the type in most cases makes sense: boots of speed/stealth <+x speed/stealth>, Amulet of Searching <+x Searching>, Cloak of Stealth <+x stealth>.

Plenty of useless repetition there.
In fact there are only five things ever printed after pvals: stealth, searching, infravision, speed and attacks. I'm inclined to remove the whole thing, since it probably adds unnecessary complexity in most cases. I could be persuaded to keep the display of speed and attacks, since they're both huge game-changers.

Any thoughts?
__________________
"3.4 is much better than 3.1, 3.2 or 3.3. It still is easier than 3.0.9, but it is more convenient to play without being ridiculously easy, so it is my new favorite of the versions." - Timo Pietila
Magnate is offline   Reply With Quote
Old June 20, 2011, 20:04   #4
Derakon
Prophet
 
Derakon's Avatar
 
Join Date: Dec 2009
Posts: 8,770
Derakon is on a distinguished road
Yank 'em. If you want to know the modifiers, use the 'I'nspect command. Or look on your detailed character screen.
Derakon is online now   Reply With Quote
Old June 20, 2011, 20:21   #5
camlost
Sangband 1.x Maintainer
 
camlost's Avatar
 
Join Date: Apr 2007
Posts: 522
camlost is on a distinguished road
Quote:
Originally Posted by Derakon View Post
Yank 'em. If you want to know the modifiers, use the 'I'nspect command. Or look on your detailed character screen.
+1. While blows and speed are important, most everyone will already know them already, and the rest can inspect.
__________________
a chunk of Bronze {These look tastier than they are. !E}
3 blank Parchments (Vellum) {No french novels please.}
camlost is offline   Reply With Quote
Old June 20, 2011, 21:05   #6
jens
Swordsman
 
Join Date: Apr 2011
Location: Göteborg, Sweden
Posts: 348
jens is on a distinguished road
Yank them all! I also want to get rid of the HIDE_TYPE :-)
jens is offline   Reply With Quote
Old June 24, 2011, 17:44   #7
jens
Swordsman
 
Join Date: Apr 2011
Location: Göteborg, Sweden
Posts: 348
jens is on a distinguished road
I opened ticket #1485 for this.
jens is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Multiple pvals PowerWyrm Vanilla 27 April 21, 2011 20:01
Taking advantage of multiple pvals Derakon Vanilla 20 January 23, 2011 13:04
Serious problem with Aeglos description ClaytonAguiar Vanilla 2 May 26, 2010 20:15
SVN: pvals no longer displayed (bug!) Pete Mack Vanilla 1 January 24, 2009 19:01
weapons: multiple blows versus multiple slays vorondil Vanilla 24 December 24, 2008 19:13


All times are GMT +1. The time now is 18:04.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.