Angband.oook.cz
Angband.oook.cz
AboutDownloadVariantsLadderForumCompetitionSpoilersComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Development

Reply
 
Thread Tools Display Modes
Old June 1, 2012, 22:43   #11
fizzix
Prophet
 
Join Date: Aug 2009
Location: Madison, Wisconsin, US
Posts: 2,630
fizzix is on a distinguished road
Quote:
Originally Posted by PowerWyrm View Post
I know TomeNET disables numlock by default, maybe V should do the same...
I'm thinking this is the way to go also.
fizzix is offline   Reply With Quote
Old June 4, 2012, 09:30   #12
PowerWyrm
Knight
 
PowerWyrm's Avatar
 
Join Date: Apr 2008
Posts: 753
PowerWyrm is on a distinguished road
Quote:
Originally Posted by PowerWyrm View Post
Ah ok... that explains the behavior of keypresses on SDL and GCU clients, so the same behavior should indeed be applied with Windows. NUMLOCK off should be the default and shift-keypad with numlock off should work as expected.
So the correct behavior should be:
- press keypad with numlock off: virtual key (left, right, down, up, home, end, pgup, pgdn)
- press keypad with numlock on: numeric key (1, 2, 3, 4, 6, 7, 8, 9)
- press shift+keypad with numlock off: shift+virtual key (shift+left, shift+right, shift+down, shift+up, shift+home, shift+end, shift+pgup, shift+pgdn)
- press shift+keypad with numlock on: virtual key (left, right, down, up, home, end, pgup, pgdn)

The game should then ensure than numlock is off and that the virtual keys are mapped to the numeric keys in pref.prf (which should be the case).
__________________
PWMAngband variant maintainer - check http://www.mangband.org/forum/viewforum.php?f=9 to learn more about this new variant!
PowerWyrm is offline   Reply With Quote
Old June 4, 2012, 09:41   #13
PowerWyrm
Knight
 
PowerWyrm's Avatar
 
Join Date: Apr 2008
Posts: 753
PowerWyrm is on a distinguished road
This also implies fixing pref.prf to map the virtual key VK_DELETE to the numeric '.' so that running is possible with numlock off by pressing the game command.
__________________
PWMAngband variant maintainer - check http://www.mangband.org/forum/viewforum.php?f=9 to learn more about this new variant!
PowerWyrm is offline   Reply With Quote
Old June 4, 2012, 10:09   #14
PowerWyrm
Knight
 
PowerWyrm's Avatar
 
Join Date: Apr 2008
Posts: 753
PowerWyrm is on a distinguished road
Hmm what's the expected behavior of control+numpad? Currently, pressing control+numpad does nothing when numlock is on, since the VK_NUMPAD keys are not handled in handle_keydown().

Note that handling VK_NUMPAD keys in handle_keydown() leads to the old bug of double keypresses and should be avoided...
__________________
PWMAngband variant maintainer - check http://www.mangband.org/forum/viewforum.php?f=9 to learn more about this new variant!

Last edited by PowerWyrm; June 4, 2012 at 10:18.
PowerWyrm is offline   Reply With Quote
Old June 4, 2012, 16:30   #15
half
Knight
 
half's Avatar
 
Join Date: Jan 2009
Posts: 881
half is on a distinguished road
PowerWyrm,

I just wanted to say thanks for working on this. When you've stabilised on something, I definitely want to incorporate it into Sil. I just don't know enough about Windows to do it myself. I was actually pretty shocked that these things don't work properly on Windows (or Unix) and that it was been decades without it being fixed.
half is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
[3.4-dev] Minor bugs with Win client PowerWyrm Development 0 April 18, 2012 14:17
Bug report: Can shift-run over the edge of the trap detection zone Remuz Development 26 July 14, 2011 00:26
can I bind macro to shift+numpad keys? fbas Vanilla 3 December 1, 2010 15:59
Play FAangband part II Fendell Orcbane AAR 6 November 29, 2010 21:53
Quill, Part II Sirridan AAR 9 June 25, 2009 04:51


All times are GMT +1. The time now is 05:54.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2014, vBulletin Solutions, Inc.