Silly minor problem with extra-large window

bron · June 15, 2012, 18:05

Since my utf-8 problem seems to have been overcome, I wanted to try out my snazzy new ultra-huge monitor. So I open a max-sized window, run "./angband -- -b" and ... it fails. Complains that the "main window is too small" ?!?! It didn't take me long to figure out that the problem is that Term->wid (and also Term->hgt) are stored as *bytes*, which meant that my huge window (with >256 columns) wrapped the available range.

Once I understood this, it was easy enough to create a window with "only" 254 columns, and everything works great. I think it would be nice if "hgt" and "wid" could be made shorts rather than bytes, but perhaps an easier change/fix would be to just limit the value to 255 (e.g. use something like:
Term->wid = min(COLS,255);
when assigning a value to "wid").

Derakon · June 15, 2012, 19:12

...we're actually using bytes for anything other than ASCII chars? That's really rather sad.

Magnate · June 15, 2012, 22:56

Quote:

Originally Posted by Derakon

...we're actually using bytes for anything other than ASCII chars? That's really rather sad.

Er ... don't forget that when Angband was written the average RAM on a PC was about 1MB. Every byte counted - so yes, we have all of byte, s16b and u16b to save memory over using 4-byte integers ...

Derakon · June 15, 2012, 23:56

Okay, let me rephrase.

We're still using bytes for anything other than ASCII chars? That's really rather sad.

buzzkill · June 16, 2012, 03:56

Quote:

Originally Posted by bron

Complains that the "main window is too small" ?!?! It didn't take me long to figure out that the problem is that Term->wid (and also Term->hgt) are stored as *bytes*, which meant that my huge window (with >256 columns) wrapped the available range.

I get this error with tiles too, before I learned to avoid it. If I maximize the screen during character creation, it would crash upon arrival in town, or just before that happened, or at least I used to. I don't recall the circumstances exactly but it's probably worth fixing (in variants too, you crazy variant maintainers).

PowerWyrm · June 16, 2012, 18:22

For my variant I've limited row/col size to 255. I've tried to change them to short ints, but this would have meant rewriting half of the code, since those bytes are spreading all over the place in the code

June 15, 2012, 18:05	#1
bron Swordsman Join Date: May 2008 Location: Saratoga, California (in the midst of Silicon Valley) Posts: 287	Silly minor problem with extra-large window Since my utf-8 problem seems to have been overcome, I wanted to try out my snazzy new ultra-huge monitor. So I open a max-sized window, run "./angband -- -b" and ... it fails. Complains that the "main window is too small" ?!?! It didn't take me long to figure out that the problem is that Term->wid (and also Term->hgt) are stored as bytes, which meant that my huge window (with >256 columns) wrapped the available range. Once I understood this, it was easy enough to create a window with "only" 254 columns, and everything works great. I think it would be nice if "hgt" and "wid" could be made shorts rather than bytes, but perhaps an easier change/fix would be to just limit the value to 255 (e.g. use something like: Term->wid = min(COLS,255); when assigning a value to "wid").

June 16, 2012, 18:22	#6
PowerWyrm Swordsman Join Date: Apr 2008 Posts: 455	For my variant I've limited row/col size to 255. I've tried to change them to short ints, but this would have meant rewriting half of the code, since those bytes are spreading all over the place in the code __________________ PWMAngband variant maintainer - check http://www.mangband.org/forum/viewforum.php?f=9 to learn more about this new variant!

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
minor problem with 3.4RC1	bron	Vanilla	1	June 11, 2012 21:30
How to use large screen size?	kicker	Vanilla	13	May 23, 2012 02:22
[3.3.x] Minor problem with randart activations	PowerWyrm	Vanilla	1	January 10, 2012 12:27
Probably a silly question	Mr Mushroom	Vanilla	4	May 31, 2011 05:55
Request for enhancement (Large monitor support)	K.I.L.E.R	Vanilla	13	March 31, 2008 08:08

June 15, 2012, 19:12	#2
Derakon Prophet Join Date: Dec 2009 Posts: 4,778	...we're actually using bytes for anything other than ASCII chars? That's really rather sad.

June 15, 2012, 23:56	#4
Derakon Prophet Join Date: Dec 2009 Posts: 4,778	Okay, let me rephrase. We're still using bytes for anything other than ASCII chars? That's really rather sad.

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)