[3.4-RC] Dropping items in the dark

PowerWyrm · July 10, 2012, 13:55

Found this while playtesting my variant, and reproduced it with the latest 3.4-RC:
- when you drop an item on the ground in the dark (you can do that by removing your light source and walking on a dark tile), it simply disappears
- if you walk on the item while having a similar item in the inventory and the pickup_inven option is on, you manage to combine the items
- if you walk on the item and it's not similar to something you have in the inventory, nothing happens at all: no message (when you're blind, but carry a light source, you get a "You feel..." message), and pressing "g" doesn't initiate pickup... it's just like the item has been squelched

I re-downloaded 3.3 and 3.2 to see if the same bug happens in these versions: the problem happens in 3.3, but not in 3.2 (you get a message and can get the item while in the dark). Clearly a regression...

dos350 · July 10, 2012, 15:23

wow

massive vouch

atleast some1 here is trying,

siz 4 all others

CynicK · July 10, 2012, 15:25

wow legit ideas, we need more like them!~

Philip · July 11, 2012, 09:05

Look, everyone, dos's sock puppet is back! Let us all welcome him back with an ignore.
EDIT: It's not like we can't read what he says in dos's posts.

PowerWyrm · July 11, 2012, 12:26

In 3.2, the pickup routine was divided in two parts: one part testing all items on the floor for pickup availability with a test only on squelched items, and one part with scan_floor with a test on hidden items (squelched + unmarked). The message and pickup availability were tested during the first part, allowing items in the dark to be picked up.

In 3.3/3.4, the pickup routine was rewritten to simplify the code with only one call to scan_floor. Items in the dark are ignored. I'm still wondering if that's a regression...

Magnate · July 13, 2012, 18:53

Quote:

Originally Posted by PowerWyrm

In 3.2, the pickup routine was divided in two parts: one part testing all items on the floor for pickup availability with a test only on squelched items, and one part with scan_floor with a test on hidden items (squelched + unmarked). The message and pickup availability were tested during the first part, allowing items in the dark to be picked up.

In 3.3/3.4, the pickup routine was rewritten to simplify the code with only one call to scan_floor. Items in the dark are ignored. I'm still wondering if that's a regression...

It sounds like it, from the bug you've observed. Reported as #1665.

July 10, 2012, 15:23	#2
dos350 Swordsman Join Date: Sep 2010 Location: nimbin, australia Posts: 455	wow massive vouch atleast some1 here is trying, siz 4 all others __________________ ~eek Reality hits you -more- S+++++++++++++++++++

July 11, 2012, 12:26	#5
PowerWyrm Swordsman Join Date: Apr 2008 Posts: 451	In 3.2, the pickup routine was divided in two parts: one part testing all items on the floor for pickup availability with a test only on squelched items, and one part with scan_floor with a test on hidden items (squelched + unmarked). The message and pickup availability were tested during the first part, allowing items in the dark to be picked up. In 3.3/3.4, the pickup routine was rewritten to simplify the code with only one call to scan_floor. Items in the dark are ignored. I'm still wondering if that's a regression... __________________ PWMAngband variant maintainer - check http://www.mangband.org/forum/viewforum.php?f=9 to learn more about this new variant!

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
[3.2] Weapon Smiths appears dark when out of LOS	PowerWyrm	Vanilla	0	April 21, 2011 12:27
[CatH] Deep One, the dark avatar	Adley	AAR	3	January 1, 2011 19:15
Stack items when dropping	Derakon	Vanilla	10	July 22, 2010 19:56
Dropping squelch items	Zikke	Vanilla	5	June 9, 2009 19:37
[Ironband] Dead in the dark..	dzhang	Variants	1	January 7, 2009 19:56

July 10, 2012, 13:55	#1
PowerWyrm Swordsman Join Date: Apr 2008 Posts: 451	[3.4-RC] Dropping items in the dark Found this while playtesting my variant, and reproduced it with the latest 3.4-RC: - when you drop an item on the ground in the dark (you can do that by removing your light source and walking on a dark tile), it simply disappears - if you walk on the item while having a similar item in the inventory and the pickup_inven option is on, you manage to combine the items - if you walk on the item and it's not similar to something you have in the inventory, nothing happens at all: no message (when you're blind, but carry a light source, you get a "You feel..." message), and pressing "g" doesn't initiate pickup... it's just like the item has been squelched I re-downloaded 3.3 and 3.2 to see if the same bug happens in these versions: the problem happens in 3.3, but not in 3.2 (you get a message and can get the item while in the dark). Clearly a regression... __________________ PWMAngband variant maintainer - check http://www.mangband.org/forum/viewforum.php?f=9 to learn more about this new variant!

July 10, 2012, 15:25	#3
CynicK Rookie Join Date: Aug 2011 Location: middle of nowhere Posts: 10	wow legit ideas, we need more like them!~

July 11, 2012, 09:05	#4
Philip Swordsman Join Date: Jul 2009 Location: Prague,Czech Republic Posts: 408	Look, everyone, dos's sock puppet is back! Let us all welcome him back with an ignore. EDIT: It's not like we can't read what he says in dos's posts.

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)