Angband.oook.cz
Angband.oook.cz
AboutDownloadVariantsLadderForumCompetitionSpoilersComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old July 10, 2012, 14:55   #1
PowerWyrm
Knight
 
PowerWyrm's Avatar
 
Join Date: Apr 2008
Posts: 776
PowerWyrm is on a distinguished road
[3.4-RC] Dropping items in the dark

Found this while playtesting my variant, and reproduced it with the latest 3.4-RC:
- when you drop an item on the ground in the dark (you can do that by removing your light source and walking on a dark tile), it simply disappears
- if you walk on the item while having a similar item in the inventory and the pickup_inven option is on, you manage to combine the items
- if you walk on the item and it's not similar to something you have in the inventory, nothing happens at all: no message (when you're blind, but carry a light source, you get a "You feel..." message), and pressing "g" doesn't initiate pickup... it's just like the item has been squelched

I re-downloaded 3.3 and 3.2 to see if the same bug happens in these versions: the problem happens in 3.3, but not in 3.2 (you get a message and can get the item while in the dark). Clearly a regression...
__________________
PWMAngband variant maintainer - check http://www.mangband.org/forum/viewforum.php?f=9 to learn more about this new variant!
PowerWyrm is offline   Reply With Quote
Old July 10, 2012, 16:23   #2
dos350
Swordsman
 
dos350's Avatar
 
Join Date: Sep 2010
Location: nimbin, australia
Posts: 474
dos350 is on a distinguished road
wow

massive vouch

atleast some1 here is trying,

siz 4 all others
__________________
~eek

Reality hits you -more-

S+++++++++++++++++++
dos350 is offline   Reply With Quote
Old July 10, 2012, 16:25   #3
CynicK
Rookie
 
CynicK's Avatar
 
Join Date: Aug 2011
Location: middle of nowhere
Posts: 10
CynicK is on a distinguished road
wow legit ideas, we need more like them!~
CynicK is offline   Reply With Quote
Old July 11, 2012, 10:05   #4
Philip
Knight
 
Join Date: Jul 2009
Location: Prague,Czech Republic
Posts: 585
Philip is on a distinguished road
Look, everyone, dos's sock puppet is back! Let us all welcome him back with an ignore.
EDIT: It's not like we can't read what he says in dos's posts.
Philip is offline   Reply With Quote
Old July 11, 2012, 13:26   #5
PowerWyrm
Knight
 
PowerWyrm's Avatar
 
Join Date: Apr 2008
Posts: 776
PowerWyrm is on a distinguished road
In 3.2, the pickup routine was divided in two parts: one part testing all items on the floor for pickup availability with a test only on squelched items, and one part with scan_floor with a test on hidden items (squelched + unmarked). The message and pickup availability were tested during the first part, allowing items in the dark to be picked up.

In 3.3/3.4, the pickup routine was rewritten to simplify the code with only one call to scan_floor. Items in the dark are ignored. I'm still wondering if that's a regression...
__________________
PWMAngband variant maintainer - check http://www.mangband.org/forum/viewforum.php?f=9 to learn more about this new variant!
PowerWyrm is offline   Reply With Quote
Old July 13, 2012, 19:53   #6
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,008
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate Send a message via Skype™ to Magnate
Quote:
Originally Posted by PowerWyrm View Post
In 3.2, the pickup routine was divided in two parts: one part testing all items on the floor for pickup availability with a test only on squelched items, and one part with scan_floor with a test on hidden items (squelched + unmarked). The message and pickup availability were tested during the first part, allowing items in the dark to be picked up.

In 3.3/3.4, the pickup routine was rewritten to simplify the code with only one call to scan_floor. Items in the dark are ignored. I'm still wondering if that's a regression...
It sounds like it, from the bug you've observed. Reported as #1665.
__________________
"3.4 is much better than 3.1, 3.2 or 3.3. It still is easier than 3.0.9, but it is more convenient to play without being ridiculously easy, so it is my new favorite of the versions." - Timo Pietila
Magnate is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
[3.2] Weapon Smiths appears dark when out of LOS PowerWyrm Vanilla 0 April 21, 2011 13:27
[CatH] Deep One, the dark avatar Adley AAR 3 January 1, 2011 20:15
Stack items when dropping Derakon Vanilla 10 July 22, 2010 20:56
Dropping squelch items Zikke Vanilla 5 June 9, 2009 20:37
[Ironband] Dead in the dark.. dzhang Variants 1 January 7, 2009 20:56


All times are GMT +1. The time now is 19:26.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2014, vBulletin Solutions, Inc.