Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old March 3, 2009, 06:58   #1
bron
Swordsman
 
Join Date: May 2008
Location: Saratoga, California (in the midst of Silicon Valley)
Posts: 448
bron is on a distinguished road
Bug: !Heal too good

I'm playing the 3.1.0 beta, and potions of Healing are healing way too many HP. The offending code is in effects.c:
...
case EF_CURE_FULL:
{
int amt = (p_ptr->mhp * 100) / 35;
if (amt < 300) amt = 300;

if (hp_player(amt)) *ident = TRUE;
...
It's pretty clear that the author meant to say:
int amt = (p_ptr->mhp * 35) / 100;
but it seems that even better would be to use:
if (heal_player(35, 300)) *ident = TRUE;
bron is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Charisma! What is it good for? (Shopping) PaulBlay Vanilla 20 February 26, 2009 19:13
Talk about a good drop ... [NPP] Pete Mack AAR 2 January 26, 2009 14:14
Should arrows/shovels be 'good'? ChodTheWacko Vanilla 4 October 14, 2008 03:21
Question regarding good/great probability ChodTheWacko Vanilla 4 October 3, 2008 19:28
[FA] A Good Start! Slonk AAR 0 October 20, 2007 22:20


All times are GMT +1. The time now is 16:35.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2018, vBulletin Solutions Inc.