[ToME 2] Getting serious about the SDL interface (again)

[Therem Harth]

And the culprit is...

$ git bisect good
c06c5c1d05164048707ef8235e971597beaffbdf is the first bad commit
commit c06c5c1d05164048707ef8235e971597beaffbdf
Author: Bardur Arantsson <bardur@scientician.net>
Date:   Tue Feb 22 00:29:52 2011 +0100

    Remove SAVE_HACK compile-time flag.

:040000 040000 b07db02dde8d70bfbd3fa37541fb5279b355b023 2be7bdb7dc925c045df331cf
2b69884f92347cc7 M      src

[AnonymousHero]

Originally Posted by Therem Harth

First, something else noteworthy: revision

gcc: error: and\: No such file or directory
gcc: error: Settings/Administrator/My\: No such file or directory
gcc: error: Documents/Downloads/tome2-tome2/src: No such file or directory
C:\MinGW\bin\windres.exe: preprocessing failed.
mingw32-make[2]: *** [src/angband_rc.o] Error 1
mingw32-make[1]: *** [src/CMakeFiles/tome.dir/all] Error 2
mingw32-make: *** [all] Error 2

This is the Win2k/WInXP one?

Btw, which Cmake version are you running? The changelog for 2.8.6 claims some fixes wrt. white space handling so maybe that's worth a shot if you are on a lower version.

[AnonymousHero]

Originally Posted by Therem Harth

And the culprit is...

$ git bisect good
c06c5c1d05164048707ef8235e971597beaffbdf is the first bad commit
commit c06c5c1d05164048707ef8235e971597beaffbdf
Author: Bardur Arantsson <bardur@scientician.net>
Date:   Tue Feb 22 00:29:52 2011 +0100

    Remove SAVE_HACK compile-time flag.

:040000 040000 b07db02dde8d70bfbd3fa37541fb5279b355b023 2be7bdb7dc925c045df331cf
2b69884f92347cc7 M      src

This... makes no sense. This doesn't remove any function definitions, so it shouldn't even be possible for this to cause the error you described earlier.

[Therem Harth]

Originally Posted by AnonymousHero

This is the Win2k/WInXP one?

Btw, which Cmake version are you running? The changelog for 2.8.6 claims some fixes wrt. white space handling so maybe that's worth a shot if you are on a lower version.

Cmake 2.8.8.

This... makes no sense. This doesn't remove any function definitions, so it shouldn't even be possible for this to cause the error you described earlier.

Ugh, sorry. Maybe the linker hung on c06c5c1 because my computer was overheating, I was compiling in a VM...

[Therem Harth]

Unfortunately it might be a while before I can get back to this, due to intensive summer courses at uni. Just FYI...

(The silver lining is that, once I'm back to Angband, I may have a better idea how to optimize the SDL code.)

[AnonymousHero]

That's fine. It's not really going anywhere (fast), anyway

[Therem Harth]

So I gathered.

Hmm. An idea regarding centered view, somewhat inspired by FVWM: maybe the distance from the edge that triggers view scrolling could be increased, to something greater than magical attack range? That would fix the major issue with centered view being impractical (i.e. monsters instakilling you from offscreen), without requiring (difficult) optimization of the SDL code.

It'd be a temporary workaround, not a long-term fix, but it would offer some reprieve from the major performance issues on the Win32 and SDL platforms.

Edit: N/M, that wouldn't work; the size of the screen isn't big enough. Grr.