Bug report v4 9feb8de

jevansau · February 21, 2012, 01:16

There seems to be a problem with overflow when finesse/prowess gets too high.
Damage rises at an extreme rate, and then you get to a point where Angband hangs on a hit ( I guess the critical calculation is open ended and the chance of passing is 100%).

The current save (attached) exhibits the problem. If you reduce the attack potential by swapping gloves, it works OK (although damage is still ridiculously high).

Regards,
Jonathan

Old Coach · February 21, 2012, 02:42

Ah, you beat me to it! Just found the same problem today.

Magnate · February 21, 2012, 20:49

Thanks both for the report, and for the savefile. There are several ways to fix this, and I daresay we'll end up trying more than one ...

jevansau · February 22, 2012, 19:59

As I understand it, the issue arises because the critical chance gets over 100% and the same check is repeated for each extra dice until it fails.
May I suggest dropping the percentage to 90% of its previous value for each roll after the first.
This will still reward very high finesse and prowess, but cannot become open ended.

Regards,
Jonathan

ekolis · February 22, 2012, 20:04

Quote:

Originally Posted by jevansau

As I understand it, the issue arises because the critical chance gets over 100% and the same check is repeated for each extra dice until it fails.

Haha, so you can get an infinite damage crit, but as punishment the game locks up on you calculating the damage? Sounds like something out of Dragon Ball... :P

Derakon · February 22, 2012, 20:51

I did the math beforehand and extrapolated that even an extremely well-equipped warrior shouldn't have had a crit chance above 60% or so (I forget exactly what I ended up with but it was in that region). But clearly I screwed something up there. Those calculations should be fixed. Additionally some kind of safety cap should be put into place to ensure that crit chance is never above 90% or so, but that's just there to make certain the game fails gracefully in unforeseen situations. The cap should never even come close to being hit in practice.

February 21, 2012, 20:49	#3
Magnate Angband Devteam member Join Date: May 2007 Location: London, UK Posts: 5,079	Thanks both for the report, and for the savefile. There are several ways to fix this, and I daresay we'll end up trying more than one ... __________________ "3.4 is much better than 3.1, 3.2 or 3.3. It still is easier than 3.0.9, but it is more convenient to play without being ridiculously easy, so it is my new favorite of the versions." - Timo Pietila

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Bug report: / on numpad on win7	Remuz	Development	6	July 8, 2011 14:16
Bug Report: Graphics not masking	Blue Baron	Development	12	July 7, 2011 16:20
Bug report: shopkeeper greetings	Derakon	Development	4	June 19, 2011 18:43
Bug report - money not updated	jens	Development	0	June 18, 2011 22:20
Vanilla Bug Report: Everburning Lantern	The G Masta	Vanilla	1	November 11, 2009 17:35

February 21, 2012, 02:42	#2
Old Coach Apprentice Join Date: Feb 2009 Posts: 61	Ah, you beat me to it! Just found the same problem today.

February 22, 2012, 19:59	#4
jevansau Adept Join Date: Jan 2009 Age: 64 Posts: 200	As I understand it, the issue arises because the critical chance gets over 100% and the same check is repeated for each extra dice until it fails. May I suggest dropping the percentage to 90% of its previous value for each roll after the first. This will still reward very high finesse and prowess, but cannot become open ended. Regards, Jonathan

February 22, 2012, 20:51	#6
Derakon Prophet Join Date: Dec 2009 Posts: 9,022	I did the math beforehand and extrapolated that even an extremely well-equipped warrior shouldn't have had a crit chance above 60% or so (I forget exactly what I ended up with but it was in that region). But clearly I screwed something up there. Those calculations should be fixed. Additionally some kind of safety cap should be put into place to ensure that crit chance is never above 90% or so, but that's just there to make certain the game fails gracefully in unforeseen situations. The cap should never even come close to being hit in practice.

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)