Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old January 29, 2017, 17:33   #11
takkaria
Veteran
 
takkaria's Avatar
 
Join Date: Apr 2007
Posts: 1,817
Donated: $40
takkaria is on a distinguished road
Quote:
Originally Posted by Thraalbee View Post
That is a good thing. I would love if you also added
variant: angband
version: 4.0.5
in the beginning as well

I use regexp so easy to adapt to your changes.
I willl also propose adding my file to json converter to the tools once it is in a decent state
The edit files used to have a version number in them but I removed them. I think they're a bad idea, because it's yet another place to update the version number when a new release happens especially now there's so many edit files.
__________________
"Physician, heal thyself."
takkaria is offline   Reply With Quote
Old January 30, 2017, 19:17   #12
kandrc
Adept
 
Join Date: Dec 2007
Posts: 171
kandrc is on a distinguished road
Quote:
Originally Posted by takkaria View Post
The edit files used to have a version number in them but I removed them. I think they're a bad idea, because it's yet another place to update the version number when a new release happens especially now there's so many edit files.
With the makefile + sed (or awk or any number of other tools), this update can be automated. I'd pull the version number from the git metadata and write it into the appropriate files as part of the build process. If you want to avoid shipping git metadata with official releases (sensible enough), then you have a rule to build the release distribution that queries git and does the file update(s) before the code ever goes to the consumers. It may be that git contains some methods to do this automatically when you check out; CVS did, back in the day (or maybe I'm thinking of perforce...?).
kandrc is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Is this 'Slow Monster probability' spoiler correct? Patashu Vanilla 1 July 29, 2012 15:45
Borg page is back up APWhite Development 19 December 6, 2010 21:03
Ladder summary page Pete Mack Oook! 11 January 11, 2010 19:01
How to compile Angband page PaulBlay Oook! 2 February 20, 2009 12:51
The Download page needs to be updated CJNyfalt Oook! 3 May 15, 2007 09:21


All times are GMT +1. The time now is 18:00.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2017, vBulletin Solutions, Inc.