Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old July 16, 2019, 23:23   #211
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 54
Posts: 7,860
Donated: $60
Nick will become famous soon enough
Quote:
Originally Posted by Thraalbee View Post
I'm hungry, I eat food => Fed 80%. I am not satisfied so I cast the (ranger) Satisfy Hunger spell too => Fed 49%. With the current naming of the spell this is very unintuitive. Sure it brings < 49% fed to 49% which is fine. Also, a glutton at 99% fed is much helped by using the spell to get to 49%, but again the naming is not telling what the spell does.
Calibrate Hunger? Set Food Level? Make Half Satiated?

Please, someone suggest something.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.

Last edited by Nick; July 16, 2019 at 23:27. Reason: Can't read, apparently
Nick is offline   Reply With Quote
Old July 16, 2019, 23:57   #212
jml34
Rookie
 
Join Date: Jul 2019
Posts: 11
jml34 is on a distinguished road
Spell of Nicely Half-full Stomach
Make Belly Comfy
Satisfy Stomach
Alleviate digestion nuisances. (But "alleviate" would suggest you go up or down to some reasonable value, not that you get to a set middle state)
Reinitialize/reinstate/rejuvenate/revitalize Stomach/Digestion
I find "Rejuvenate Stomach" suggestive

or maybe just have a spell of Fill Stomach/Magical Food (adds some constant food), then have a way to vomit at monsters when your stomach is above some value (cone attack dealing acidic damage + makes player stunned)

("Slow Digestion" isn't great either: it looks like regen will be slowed too, while it's not the case AFAIK. Low Food Wastage? Sustainable Metabolism? Just plain Save Food?)
jml34 is offline   Reply With Quote
Old July 17, 2019, 00:44   #213
Pete Mack
Prophet
 
Join Date: Apr 2007
Location: Seattle, WA
Posts: 5,414
Donated: $40
Pete Mack is on a distinguished road
Good digestion.
Pete Mack is offline   Reply With Quote
Old July 17, 2019, 01:52   #214
Diego Gonzalez
Apprentice
 
Join Date: May 2007
Posts: 63
Diego Gonzalez is on a distinguished road
Restore metabolism
Diego Gonzalez is offline   Reply With Quote
Old July 17, 2019, 02:53   #215
Youssarian
Scout
 
Youssarian's Avatar
 
Join Date: Feb 2019
Location: RI
Posts: 27
Youssarian is on a distinguished road
Scroll of Tasty Victuals

Scroll of Sustenance

Scroll of Bilbo's Larder
__________________
In the halls of Angband, Melkor discovers cupcakes and is changed forever.

He commands his servant Sauron to create the One Cupcake of Doom!
Youssarian is offline   Reply With Quote
Old July 17, 2019, 02:56   #216
Chud
Swordsman
 
Join Date: Jun 2010
Posts: 288
Chud is on a distinguished road
Normalize Nutrition

Moderate Gluttony

Frodo's Second Breakfast

Chud is offline   Reply With Quote
Old July 17, 2019, 03:23   #217
jml34
Rookie
 
Join Date: Jul 2019
Posts: 11
jml34 is on a distinguished road
I've just tried to patch the game to extend the @[cmd][key] syntax so that "key" can also be a-zA-Z, and it's really great. Try it and you'll wonder how you could play without it!
Engrave default food with @EE, the most useful rod with @aa, wand with @zz, arrow with @tt etc. (roguelike keyset examples) Then other things with whatever is easy to type, and probably use an upper-case key for things you don't want to mistype and launch by mistake.
If I have a potion engraved with @qe then another potion at slot e does get hidden but I don't think it's a problem. I didn't allow for the general @[key] syntax to get extended of course, since this would conflit with the @[cmd][key] syntax.
(The engraving check code doesn't use an efficient algorithm so it's slowed by a factor 6.2 (each @ was checked 10 times, now it's 10+26+26))

ui-object.c
Code:
/* old code in 4.1.3
        if (quiver_tags) { */
 /* new code */
        if (quiver_tags && '0'<=tag && tag<='9') {
/* end of new code */
                i = tag - '0';
Code:
/* Old code */      
                        ///* Check the normal tags */
                        //if (s[1] == tag) {
/* new code */        
                        /* Check the normal tags when '0'<=tag<='9' */
                        if (s[1] == tag && '0'<=tag && tag<='9') {
/* end of new code */
                                /* Save the actual object */
                                *tagged_obj = obj;
Code:
 /* Get inscriptions */
/* old code */
        //m->inscriptions = mem_zalloc(10 * sizeof(char));
        //for (inscrip = 0; inscrip < 10; inscrip++) {
                ///* Look up the tag */
                //if (get_tag(&obj, (char)inscrip + '0', item_cmd,
                                        //item_mode & QUIVER_TAGS)) {
/* new code */
        /* inscriptions: '0'-'9', 'a'-'z', 'A'-'Z' */
        m->inscriptions = mem_zalloc((10+2*26) * sizeof(char));
        for (inscrip = 0; inscrip < 10+2*26; inscrip++) {
                /* Look up the tag */
                char tag;
                if (inscrip < 10) tag = (char)inscrip + '0';
                else if (inscrip < 10+26) tag = (char)(inscrip-10) + 'a';
                else tag = (char)(inscrip-10-26) + 'A';

                if (get_tag(&obj, tag, item_cmd, item_mode & QUIVER_TAGS)) {
/* end of new code */
                        int i;
                        for (i = 0; i < num_obj; i++)
                                if (items[i].object == obj)
                                                break;
file ui-menu.c:
Code:
/* Old code: we don't touch the first if but we need to swap the ifs        
        if (menu->flags & MN_CASELESS_TAGS)
                key.code = toupper((unsigned char) key.code);

        if ((menu->flags & MN_INSCRIP_TAGS) && isdigit((unsigned char)key.code)
                && menu->inscriptions[D2I(key.code)])
                key.code = menu->inscriptions[D2I(key.code)];
*/ /* new code */
        if (menu->flags & MN_INSCRIP_TAGS) {
                unsigned char keyc = (unsigned char)key.code;
                int index = -1;
                if ('0'<=keyc && keyc<='9') index = keyc-'0';
                if ('a'<=keyc && keyc<='z') index = (keyc-'a')+10;
                if ('A'<=keyc && keyc<='Z') index = (keyc-'A')+10+26;
                if (index>=0 && menu->inscriptions[index])
                        key.code = menu->inscriptions[index];
        }

        if (menu->flags & MN_CASELESS_TAGS)
                key.code = toupper((unsigned char) key.code);
/* end of new code */
I hope it's OK to not learn git for a simple patch like this sorry
Well above all I hope it doesn't break things. I made a beginner warrior and whatever I tought I'd try worked...
jml34 is offline   Reply With Quote
Old July 17, 2019, 03:44   #218
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 54
Posts: 7,860
Donated: $60
Nick will become famous soon enough
Quote:
Originally Posted by jml34 View Post
I've just tried to patch the game to extend the @[cmd][key] syntax so that "key" can also be a-zA-Z, and it's really great. Try it and you'll wonder how you could play without it!
Engrave default food with @EE, the most useful rod with @aa, wand with @zz, arrow with @tt etc. (roguelike keyset examples) Then other things with whatever is easy to type, and probably use an upper-case key for things you don't want to mistype and launch by mistake.
At first glance this looks good. Anyone see any objections to it (if it works as described)?
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old July 17, 2019, 03:48   #219
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 54
Posts: 7,860
Donated: $60
Nick will become famous soon enough
Also thanks for all the helpful suggestions on a new name for Satisfy Hunger. My current thinking is to go with Derakon's idea of Remove Hunger, and change it to not reset food downward. This means it will not be a cure for fullness, which seems more in keeping with the philosophy of the changes. Also makes ,Purging and !Salt Water more useful
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old July 17, 2019, 04:10   #220
Sideways
Swordsman
 
Join Date: Nov 2008
Posts: 434
Sideways is on a distinguished road
Quote:
Originally Posted by Nick View Post
At first glance this looks good. Anyone see any objections to it (if it works as described)?
Poslikes have that; and my experience is that the situation jml34 described (an item being left without a letter slot because its natural letter was claimed by another item's inscription) was actually a fairly serious problem that occurred repeatedly and equally repeatedly produced headaches (especially for new players who hadn't seen it happen before) until code was written to make sure every item always has a letter.
__________________
The Complainer worries about the lack of activity here these days.
Sideways is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
First release Quirk Sil 18 November 14, 2017 23:45
3.4.0 Release Candidate is available fizzix Vanilla 111 July 5, 2012 13:39
3.2 release candidate is upon us! d_m Vanilla 147 January 19, 2011 11:10
Release HellBand 0.8.7 konijn_ Variants 4 December 27, 2009 05:14
reactions to changes in new V release will_asher Vanilla 50 April 9, 2008 19:47


All times are GMT +1. The time now is 23:13.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.