Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Development

Reply
 
Thread Tools Display Modes
Old March 12, 2020, 06:42   #1
wobbly
Veteran
 
Join Date: May 2012
Location: Adelaide, Australia
Posts: 2,375
wobbly is on a distinguished road
Dodgy code notes

I'm just going to keep a record here as I find them & at some stage I'll submit a pull request to fix them all up:

genroom.c
build_crossed
room b runs east/east
locate room b followed by locate room b

build_pit
2 headings for corners - looking at it again its probably right, just written in a way that isn't exactly clear.

Last edited by wobbly; March 12, 2020 at 06:55.
wobbly is offline   Reply With Quote
Old March 12, 2020, 07:12   #2
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 55
Posts: 8,463
Donated: $60
Nick will become famous soon enough
Thanks, this is an unglamorous but useful task.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old March 16, 2020, 13:22   #3
wobbly
Veteran
 
Join Date: May 2012
Location: Adelaide, Australia
Posts: 2,375
wobbly is on a distinguished road
gencave.c
I don't think the odds in the note actually match the function.

Code:
		/* We generate a rarity number to figure out how exotic to make the
		 * room. This number has a depth/DUN_UNUSUAL chance of being > 0,
		 * a depth^2/DUN_UNUSUAL^2 chance of being > 1, up to MAX_RARITY. */
		i = 0;
		rarity = 0;
		while (i == rarity && i < dun->profile->max_rarity) {
			if (randint0(dun_unusual) < 50 + c->depth / 2) rarity++;
			i++;
		}
wobbly is offline   Reply With Quote
Old April 29, 2020, 18:24   #4
backwardsEric
Apprentice
 
Join Date: Aug 2019
Posts: 86
backwardsEric is on a distinguished road
There's misleading comments for the brands and slays fields of struct object at line 447 and 448 of object.h.

Code:
        bool *brands;                   /**< Array of brand structures */
	bool *slays;                    /**< Array of slay structures */
backwardsEric is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Notes on the zborg 2.40 konijn_ Development 0 April 19, 2018 14:09
Notes/History StephenR Vanilla 0 February 22, 2009 11:47
Code: Notes live where? camlost Vanilla 4 February 20, 2009 21:11
Comp #61 notes Donald Jonker Competition 37 November 29, 2008 18:45
Notes Patch Narvius Vanilla 12 August 8, 2008 20:50


All times are GMT +1. The time now is 10:44.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2020, vBulletin Solutions Inc.