Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old February 20, 2009, 20:08   #1
camlost
Sangband 1.x Maintainer
 
camlost's Avatar
 
Join Date: Apr 2007
Posts: 522
camlost is on a distinguished road
Code: Notes live where?

Where is the standard place to store the notes (and autonotes) for a character? I think I found a patch that seems to store them externally, but I assume that it is more common to save it within the savefile.

Alternately, is there a GPL-compatible note/autonotes patch I can copy from?
__________________
a chunk of Bronze {These look tastier than they are. !E}
3 blank Parchments (Vellum) {No french novels please.}
camlost is offline   Reply With Quote
Old February 20, 2009, 20:43   #2
Pete Mack
Prophet
 
Join Date: Apr 2007
Location: Seattle, WA
Posts: 3,953
Donated: $40
Pete Mack is on a distinguished road
I don't know about a patch, but V and FA store it in the savefile, and do not keep an external file during the game (as NPP does).
Pete Mack is offline   Reply With Quote
Old February 20, 2009, 20:44   #3
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 51
Posts: 6,410
Donated: $60
Nick is on a distinguished road
That patch is I suspect where NPP got it's implementation from (or vice versa). NPP originally stored the notes in a separate file, which had several problems. I don't know if there is a patch for the current V setup (although stuff was posted to the angband-dev mailing list). It should be fairly straightforward just to lift one of the current implementations, though - V and FA have good setups, I haven't checked NPP's in a while.
__________________
One Ring to rule them all, One Ring to find them,
One Ring to bring them all and in the darkness bind them.
Nick is offline   Reply With Quote
Old February 20, 2009, 20:54   #4
camlost
Sangband 1.x Maintainer
 
camlost's Avatar
 
Join Date: Apr 2007
Posts: 522
camlost is on a distinguished road
Quote:
Originally Posted by Nick View Post
That patch is I suspect where NPP got it's implementation from (or vice versa). NPP originally stored the notes in a separate file, which had several problems. I don't know if there is a patch for the current V setup (although stuff was posted to the angband-dev mailing list). It should be fairly straightforward just to lift one of the current implementations, though - V and FA have good setups, I haven't checked NPP's in a while.
FA is GPL, right? Is there a list of variants and licenses for those trying to lift code?
__________________
a chunk of Bronze {These look tastier than they are. !E}
3 blank Parchments (Vellum) {No french novels please.}
camlost is offline   Reply With Quote
Old February 20, 2009, 21:11   #5
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 51
Posts: 6,410
Donated: $60
Nick is on a distinguished road
Quote:
Originally Posted by camlost View Post
FA is GPL, right?
Current version technically not, next one will be. That said, the notes stuff is taken from Jeff Greene's NPP implementation, and modified by me, and we're both signed up members of the GPL push, so I think you're clear. IIRC almost all the GPL-dubious stuff is in the main-xxx.c files, which are well away from any notes content. If you're in any doubt, use the V one.
__________________
One Ring to rule them all, One Ring to find them,
One Ring to bring them all and in the darkness bind them.
Nick is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Comp #61 notes Donald Jonker Competition 37 November 29, 2008 18:45
Notes Patch Narvius Vanilla 12 August 8, 2008 20:50
[ToME] Notes on a thaumaturgist build Therem Harth AAR 0 January 19, 2008 22:08
Looking through the code K.I.L.E.R Vanilla 5 July 11, 2007 08:01
The safe_setuid code CJNyfalt Vanilla 11 June 26, 2007 03:25


All times are GMT +1. The time now is 11:16.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2017, vBulletin Solutions, Inc.