Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Development

Reply
 
Thread Tools Display Modes
Old January 8, 2011, 18:35   #1
APWhite
Adept
 
APWhite's Avatar
 
Join Date: Jul 2007
Location: St George Utah, USA
Posts: 244
APWhite is on a distinguished road
Borg for 320 is running.

The borg for 320 is running. I have to play test it for a while. There are some subtle changes in the game code that are causing problems. But they are being hammered out.

There are still some problems with the screensaver. But I will get to it.

Another issue is with the game giving the message "Type '?' for help." whenever the ESC or Space is hit. The borg uses ESC and Space a lot for clearing messages and catching up. So it would be nice if the game did not give this report for those two keys.

Andrew

www.innovapain.com/borg

Last edited by APWhite; January 9, 2011 at 04:34.
APWhite is offline   Reply With Quote
Old January 8, 2011, 23:37   #2
d_m
Angband Devteam member
 
d_m's Avatar
 
Join Date: Aug 2008
Location: Philadelphia, PA, USA
Age: 39
Posts: 1,516
d_m is on a distinguished road
Quote:
Originally Posted by APWhite View Post
Another issue is with the game giving the message "Type '?' for help." whenever the ESC or Space is hit. The borg uses ESC and Space a lot for clearing messages and catching up. So it would be nice if the game did not give this report for those two keys.
This is fixed in HEAD.

If you want I can probably find the diff for you, I think it's a small change.
__________________
linux->xterm->screen->pmacs
d_m is offline   Reply With Quote
Old January 9, 2011, 01:02   #3
flechette
Scout
 
Join Date: Sep 2008
Posts: 40
flechette is on a distinguished road
This news makes me immensely happy.
flechette is offline   Reply With Quote
Old January 9, 2011, 04:38   #4
APWhite
Adept
 
APWhite's Avatar
 
Join Date: Jul 2007
Location: St George Utah, USA
Posts: 244
APWhite is on a distinguished road
Quote:
Originally Posted by d_m View Post
This is fixed in HEAD.

If you want I can probably find the diff for you, I think it's a small change.
I got it. I just bracketed this error and the automatic savefile with #ifndef ALLOW_BORG

I do have some changes to the game code to help the borg. They are all marked. Search for apw in the game files included with the borg. There will be a few more as soon as I can figure out why the screensaver is freaky.
APWhite is offline   Reply With Quote
Old January 9, 2011, 08:53   #5
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by APWhite View Post
I got it. I just bracketed this error and the automatic savefile with #ifndef ALLOW_BORG

I do have some changes to the game code to help the borg. They are all marked. Search for apw in the game files included with the borg. There will be a few more as soon as I can figure out why the screensaver is freaky.
It occurs to me that the borg could be really useful for testing the staging branch (and indeed other dev branches). Can you give a brief description of what it logs, if anything? For testing purposes it would be good to focus on the game commands the borg executes, rather than the decision-making. But it would be helpful if the borg logged when it made use of o_ptr->known_flags etc. as this would help with bug-hunting.
Magnate is offline   Reply With Quote
Old January 10, 2011, 02:05   #6
APWhite
Adept
 
APWhite's Avatar
 
Join Date: Jul 2007
Location: St George Utah, USA
Posts: 244
APWhite is on a distinguished road
Quote:
Originally Posted by Magnate View Post
It occurs to me that the borg could be really useful for testing the staging branch (and indeed other dev branches). Can you give a brief description of what it logs, if anything? For testing purposes it would be good to focus on the game commands the borg executes, rather than the decision-making. But it would be helpful if the borg logged when it made use of o_ptr->known_flags etc. as this would help with bug-hunting.
As far as logging, the borg has an option called borg_verbose which has him record a lot of information in the log; things like creating monsters, tracking movements of monsters and stuff like that. Most of it is designed for him reporting on his internal thought process.

He does log his commands and all his key-presses.

If you need him to give reports on flags, that is not hard to do. He knows the o_ptr->flags, but he is not allowed to use that information until the object is ID'd. The borg will keep a separate struct (borg_item) and will copy all the flags from o_ptr to borg_item. When he needs to think about those flags, he will do so by looking at borg_item.

If you needed him to stop when a certain item is found or a certain event occurs, he can be programmed to do that.

I am not opposed to having my code put up into a repository so long as only skilled people are modify it. The borg is really complex and tinkering in one area of the code, can have some bad side effects.

If you have a specific concern, let me know and I can describe how the borg could help.

By the way, the borg is crashing in resurrect_borg() with:
Code:
    /* Clear the inventory */
    for (i = 0; i < ALL_INVEN_TOTAL; i++)
    {
		object_wipe(&p_ptr->inventory[i]);
    }
The error is:
Code:
Unhandled exception at 0x0055ebdf in Angband.exe: 0xC0000005: Access violation writing location 0x00000000.
It appears that the borg is not being given access to p_ptr->inventory. If you can take a look at it, I'd appreciate it. This routine is critical to getting the screensaver up to date. Picture of the error and call stack below.
APWhite


APWhite is offline   Reply With Quote
Old January 10, 2011, 03:44   #7
takkaria
Veteran
 
takkaria's Avatar
 
Join Date: Apr 2007
Posts: 1,947
Donated: $40
takkaria is on a distinguished road
Quote:
Originally Posted by APWhite View Post
By the way, the borg is crashing in resurrect_borg() with:
Code:
    /* Clear the inventory */
    for (i = 0; i < ALL_INVEN_TOTAL; i++)
    {
		object_wipe(&p_ptr->inventory[i]);
    }
The error is:
Code:
Unhandled exception at 0x0055ebdf in Angband.exe: 0xC0000005: Access violation writing location 0x00000000.
It appears that the borg is not being given access to p_ptr->inventory. If you can take a look at it, I'd appreciate it. This routine is critical to getting the screensaver up to date. Picture of the error and call stack below.
I think there's a bug somewhere that is causing memory to get overwritten in weird ways, since that backtrace is really weird (memset's paramaters are way off, when that call should be taking (object, 0, sizeof object_type)). No suggestions on how to fix it though, I'm afraid...

Something that might paper of the crack: now inventory is part of the player struct, you can remove separate inventory wiping, since you wipe the player anyway (line 3067 on the version from your website).
__________________
takkaria whispers something about options. -more-
takkaria is offline   Reply With Quote
Old January 15, 2011, 15:53   #8
Rosario
Rookie
 
Join Date: Jan 2011
Posts: 1
Rosario is on a distinguished road
I downloaded the borg from your site, and ran the .exe. My anti-virus software shut it down, saying it was acting funny. Help?
Rosario is offline   Reply With Quote
Old January 15, 2011, 17:08   #9
APWhite
Adept
 
APWhite's Avatar
 
Join Date: Jul 2007
Location: St George Utah, USA
Posts: 244
APWhite is on a distinguished road
Quote:
Originally Posted by Rosario View Post
I downloaded the borg from your site, and ran the .exe. My anti-virus software shut it down, saying it was acting funny. Help?
Did the AV say why it didn't like the borg?

Also, when did the AV freak out. Was it when you loaded up angband or after you hit ^zz and engaged the borg?

There is no malicious stuff in the borg. It does not access the internet or anything. Maybe because it sends keypresses.
APWhite is offline   Reply With Quote
Old January 15, 2011, 17:10   #10
buzzkill
Prophet
 
buzzkill's Avatar
 
Join Date: May 2008
Location: Indiana, USA
Posts: 2,939
Donated: $8
buzzkill is on a distinguished road
Quote:
Originally Posted by Rosario View Post
I downloaded the borg from your site, and ran the .exe. My anti-virus software shut it down, saying it was acting funny. Help?
Funny how? I mean, funny like a clown? I amuse you? I make you laugh? Iím here to *** amuse you? What do you mean funny. Funny how? How am I funny? (says the borg)

After viewing it this many times, I've concluded that funny is a funny looking word. There was no question at first, but after I while I began to wonder if it was misspelled, even though I knew it wasn't.
__________________
www.mediafire.com/buzzkill - Get your 32x32 tiles here. UT32 now compatible Ironband and Quickband 9/6/2012.
My banding life on Buzzkill's ladder.
buzzkill is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
(not) running into molds half Vanilla 12 May 24, 2009 09:04
Re-thinking running (away) buzzkill Development 2 March 8, 2009 08:42
3.1 running bug Faust Vanilla 0 January 11, 2009 16:16
Disturbs when running. Zero Vanilla 1 June 19, 2008 16:30
Anyone running the nightlies... takkaria Vanilla 3 July 13, 2007 16:54


All times are GMT +1. The time now is 01:12.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2020, vBulletin Solutions Inc.