p_ptr->class vs. p_ptr->pclass

APWhite · August 13, 2011, 17:35

So what was the push to switch pclass to class? 'class' is a reserved word in some environments (like Visual Studio).

pclass was still a useful word. We understood it to be player-class. I think that switch may have caused more harm than good.

d_m · August 13, 2011, 17:58

Quote:

Originally Posted by APWhite

So what was the push to switch pclass to class? 'class' is a reserved word in some environments (like Visual Studio).

pclass was still a useful word. We understood it to be player-class. I think that switch may have caused more harm than good.

I didn't make the change, but absent other considerations i think player->class and p_ptr->class read better. That said, if it's breaking things then I'm not necessarily against changing it back.

Does this prevent you from building in VC++/VS? I think that BluBaron has been building recent staging in Angband in VS without hitting this problem.

Blue Baron · August 13, 2011, 21:51

Quote:

Originally Posted by d_m

I didn't make the change, but absent other considerations i think player->class and p_ptr->class read better. That said, if it's breaking things then I'm not necessarily against changing it back.

Does this prevent you from building in VC++/VS? I think that BluBaron has been building recent staging in Angband in VS without hitting this problem.

I am building without any mention of this pointer. even though "class" is highlighted for me, I guess it is not treated as a keyword in C files.

Derakon · August 13, 2011, 22:23

It may also be that since it isn't a bare word it doesn't confuse the parser.

fph · August 13, 2011, 22:39

GTK uses "klass" instead of "class" to avoid conflicting with the C++ reserved word. This is funny to see, since "klass" sounds a lot like the typical KDE3 app name...

Azerath · August 17, 2011, 16:32

klass - may come from KDE Large Ass... ;-) - just kidding no want to start OS-War ;-)

August 13, 2011, 17:35	#1
APWhite Adept Join Date: Jul 2007 Location: St George Utah, USA Posts: 244	p_ptr->class vs. p_ptr->pclass So what was the push to switch pclass to class? 'class' is a reserved word in some environments (like Visual Studio). pclass was still a useful word. We understood it to be player-class. I think that switch may have caused more harm than good.

August 13, 2011, 22:39	#5
fph Veteran Join Date: Apr 2009 Location: Pisa / DL0 Posts: 1,027	GTK uses "klass" instead of "class" to avoid conflicting with the C++ reserved word. This is funny to see, since "klass" sounds a lot like the typical KDE3 app name... __________________ -- Dive fast, die young, leave a high-CHA corpse.

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
new class?	Tibarius	Vanilla	11	July 18, 2011 18:53
New class?	Philip	Development	9	June 18, 2011 23:22
Question about p_ptr	Kyle	Development	1	July 27, 2009 23:30
p_ptr->command_cmd	PaulBlay	Development	5	April 22, 2009 04:24
This Class. Right here.	Larvitz	Vanilla	1	January 24, 2009 18:43

August 13, 2011, 22:23	#4
Derakon Prophet Join Date: Dec 2009 Posts: 9,022	It may also be that since it isn't a bare word it doesn't confuse the parser.

August 17, 2011, 16:32	#6
Azerath Rookie Join Date: Jun 2011 Posts: 21	klass - may come from KDE Large Ass... ;-) - just kidding no want to start OS-War ;-)

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)