Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old June 14, 2020, 23:26   #61
moosferatu
Apprentice
 
Join Date: Feb 2020
Posts: 99
moosferatu is on a distinguished road
Quote:
Originally Posted by DavidMedley View Post
There is a user interface option to prevent this.
Do you mean disable auto-pickup matching items or charges being averaged across devices? I like auto-pickup most of the time. I'm not seeing a setting for the latter.
moosferatu is offline   Reply With Quote
Old June 15, 2020, 00:16   #62
DavidMedley
Knight
 
Join Date: Oct 2019
Posts: 726
DavidMedley is on a distinguished road
Matching items
Command: =af
DavidMedley is offline   Reply With Quote
Old June 15, 2020, 07:34   #63
spara
Adept
 
Join Date: Nov 2014
Posts: 234
spara is on a distinguished road
Found another unknown rod. Zapped from the ground and it revealed itself to be Rod of Polymorph. Again missing details in description. I guess the problem is in the identification of (rods?) from the ground.
spara is offline   Reply With Quote
Old June 15, 2020, 07:52   #64
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 55
Posts: 8,392
Donated: $60
Nick will become famous soon enough
Quote:
Originally Posted by backwardsEric View Post
There was a change to avoid problems when reading a rune of protection scroll from the floor. As a direct result of that or the subsequent fixes to clean up extra messages from that change, a problem with propagating knowledge about single-use items was introduced which Nick fixed. All those changes were in a routine that's called for all item use. So, they could be related to this bug about not learning the properties of a rod after using it.
OK, I'm pretty sure this is actually the problem. Looking at that code, it seems to me that there is only need to use a work object for single use items, so that code for multi-use items could just be removed - do you agree?
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old June 15, 2020, 13:13   #65
spara
Adept
 
Join Date: Nov 2014
Posts: 234
spara is on a distinguished road
@ has been blinded and tries to look at objects formerly left behind. They all basically give the same "You see an open floor..." message. They can be seen in the "You are aware of ... objects" term-window though. @ should probably be able to use the look command to check the objects they are aware of even though being blinded.

Click image for larger version

Name:	Screenshot from 2020-06-15 15-04-52.jpg
Views:	22
Size:	19.5 KB
ID:	1854

Save: look.zip
spara is offline   Reply With Quote
Old June 15, 2020, 16:35   #66
backwardsEric
Apprentice
 
Join Date: Aug 2019
Posts: 72
backwardsEric is on a distinguished road
Quote:
Originally Posted by Nick View Post
OK, I'm pretty sure this is actually the problem. Looking at that code, it seems to me that there is only need to use a work object for single use items, so that code for multi-use items could just be removed - do you agree?
For the current item set, I think that's fine. If you want to allow the possibility of things like rods or staffs of deep descent or teleport level (something where the item's effect would leave the original object inaccessible after use from the floor), then using a temporary object for the bookkeeping after the effect seems necessary.
backwardsEric is offline   Reply With Quote
Old June 15, 2020, 21:05   #67
DavidMedley
Knight
 
Join Date: Oct 2019
Posts: 726
DavidMedley is on a distinguished road
Like a rod of recall?
DavidMedley is offline   Reply With Quote
Old June 15, 2020, 21:47   #68
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 55
Posts: 8,392
Donated: $60
Nick will become famous soon enough
Quote:
Originally Posted by backwardsEric View Post
For the current item set, I think that's fine. If you want to allow the possibility of things like rods or staffs of deep descent or teleport level (something where the item's effect would leave the original object inaccessible after use from the floor), then using a temporary object for the bookkeeping after the effect seems necessary.
OK, good thinking.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old June 15, 2020, 22:57   #69
luneya
Swordsman
 
Join Date: Aug 2015
Posts: 276
luneya is on a distinguished road
Quote:
Originally Posted by DavidMedley View Post
Like a rod of recall?
Recall or deep descent wouldn't actually trigger this problem because they trigger a status effect immediately, and the effect removes the player from the level after several turns. The identity is learned as soon as the status effect is gained, at which point the rod/staff/wand is still present.

An object of teleport level would be a problem if such existed. We probably should also test if there is a problem using unknown staves of teleport from the floor, as the staff would no longer be visible to the player after teleporting.
luneya is offline   Reply With Quote
Old June 16, 2020, 02:52   #70
DavidMedley
Knight
 
Join Date: Oct 2019
Posts: 726
DavidMedley is on a distinguished road
I don't know if it's just the power of suggestion, but now I do seem to remember something weird like that happening to me... used a scroll of teleport from the floor and it didn't ID. I guess that's not a very helpful report...
DavidMedley is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Reviving Iso-Angband, an isometric view addon for Angband Hajo Development 111 August 3, 2014 19:44


All times are GMT +1. The time now is 16:24.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2020, vBulletin Solutions Inc.