Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Variants

Reply
 
Thread Tools Display Modes
Old April 2, 2018, 04:48   #11
Pete Mack
Prophet
 
Join Date: Apr 2007
Location: Seattle, WA
Posts: 4,593
Donated: $40
Pete Mack is on a distinguished road
The trouble with PosCheng largely stems from the fast development from an ancient code base. It uses monolithic programming in spades, and is very difficult to jump in and modify. Big engineering deficit, that has already been paid in Vanilla.
Pete Mack is offline   Reply With Quote
Old April 2, 2018, 20:08   #12
droof
Apprentice
 
Join Date: Dec 2013
Posts: 71
droof is on a distinguished road
I think most variants inherit the same old code base, because they start out as tweaks on existing interesting features of another variant. Probably future variants will inherit an old code base for the same reason. Also if a variant only has one maintainer, if that maintainer stops, the variant stops.
droof is offline   Reply With Quote
Old April 3, 2018, 10:16   #13
Gwarl
Knight
 
Join Date: Jan 2017
Posts: 532
Gwarl is on a distinguished road
Nah they're all inheriting different old codebases. For example, PosChengband was last vanilla in 2.8.0, whereas RePosband was last vanilla in 3.0.something

But that's not the problem with it. Didn't stop me forking after all.
Gwarl is offline   Reply With Quote
Old April 3, 2018, 13:37   #14
Mocht
Swordsman
 
Join Date: Mar 2015
Posts: 263
Mocht is on a distinguished road
Quote:
Originally Posted by Pete Mack View Post
The trouble with PosCheng largely stems from ... an ancient code base
What makes the newer Vanilla code so much cleaner than the older Vanilla code
Mocht is offline   Reply With Quote
Old April 3, 2018, 14:05   #15
Gwarl
Knight
 
Join Date: Jan 2017
Posts: 532
Gwarl is on a distinguished road
Old V is full of global defines. So much stuff that's hardcoded but shouldn't be.
Gwarl is offline   Reply With Quote
Old April 3, 2018, 15:15   #16
Pete Mack
Prophet
 
Join Date: Apr 2007
Location: Seattle, WA
Posts: 4,593
Donated: $40
Pete Mack is on a distinguished road
The #defines are just part of it.
* The bitflags are now done properly.
* Similar attributes are kept in array, not as separate fields
* All game configuration is loaded from files, or where that is not possible, done with generated code
* UI implementation is cleaner
Large number of other smaller changes for better code quality (Knowledge menu, character sheet, birth...)
Pete Mack is offline   Reply With Quote
Old April 3, 2018, 18:04   #17
droof
Apprentice
 
Join Date: Dec 2013
Posts: 71
droof is on a distinguished road
Quote:
Originally Posted by Gwarl View Post
Nah they're all inheriting different old codebases. For example, PosChengband was last vanilla in 2.8.0, whereas RePosband was last vanilla in 3.0.something

But that's not the problem with it. Didn't stop me forking after all.
Oops, PosChengband resembled Kangband and old Zangband, so I just assumed it originated from one of those, at least at some point in the long dev history
droof is offline   Reply With Quote
Old April 10, 2018, 00:26   #18
Gwarl
Knight
 
Join Date: Jan 2017
Posts: 532
Gwarl is on a distinguished road
I'm not sure of the details regarding Kang, but Cheng forked from Heng which forked from a version of Zang which was originally forked from vanilla 2.8. Certainly a lot of the content originates from Kang, but I think Z is the direct ancestor.
Gwarl is offline   Reply With Quote
Old April 10, 2018, 04:45   #19
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 52
Posts: 7,057
Donated: $60
Nick is on a distinguished road
Quote:
Originally Posted by Gwarl View Post
I'm not sure of the details regarding Kang, but Cheng forked from Heng which forked from a version of Zang which was originally forked from vanilla 2.8. Certainly a lot of the content originates from Kang, but I think Z is the direct ancestor.
Actually Zang (version 1.2) was originally forked from PCAngband 1.4 (PCAngband 1.0-1.4 were a PC port plus follow-ups to frog-knows). From memory, it did then import most of Vanilla from time to time.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old April 10, 2018, 13:03   #20
Therem Harth
Knight
 
Therem Harth's Avatar
 
Join Date: Jan 2008
Location: https://github.com/miramor
Posts: 889
Therem Harth is on a distinguished road
Given the age of the code base, and the size and growing complexity of the game, I strongly suspect this is a case of "I'm abandoning the project because otherwise it will eat my life."
Therem Harth is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Poschengband github Pete Mack Variants 10 December 1, 2016 17:05
Crash due to referencing object deleted by drop_near() calris Development 5 April 6, 2016 12:25
github question nppangband Development 4 September 26, 2012 09:52
Github for Windows Nick Development 0 May 30, 2012 05:25
Github help nppangband Development 9 September 20, 2011 21:11


All times are GMT +1. The time now is 11:16.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2018, vBulletin Solutions Inc.