Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old January 19, 2020, 04:09   #1
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 54
Posts: 7,974
Donated: $60
Nick will become famous soon enough
Bug tracking

Thanks to a huge effort by d_m, Angband bug tracking has been moved from trac to Github issues.

This means any Github user can now log an issue, and becoming a Github user is straightforward. So from now on the preferred method of submitting bug reports is by opening a new issue here.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old January 19, 2020, 04:44   #2
DavidMedley
Swordsman
 
Join Date: Oct 2019
Posts: 312
DavidMedley is on a distinguished road
Any guidelines to this? Like, I sometimes post some very minor bugs in the "4.2 bugs thread." Seems like if no one wants to tackle them it's pretty easy to just scroll past. I'd be more concerned about cluttering up this list. Also, there's a good number of feature requests in here. If any GitHub user can submit those then clutter is even more of a concern.

What about people not in the dev pool taking on some of these? There's a sticky over in the Development forum about issues that non-coders can take on. Looking through this GitHub Issues list I suspect there's a fair number that you wouldn't implement even if you could with a snap of your fingers, tho.
DavidMedley is offline   Reply With Quote
Old January 19, 2020, 06:38   #3
eastwind
Apprentice
 
Join Date: Dec 2019
Location: Mexico, undisclosed location
Posts: 79
eastwind is on a distinguished road
I entered a bug - I didn't see any non-freeform field where the version the bug is reported against is specified - seems like a necessary desirable standard thing to me - to say whether the bug you're reporting is against 4.2.0 or whatever the bleeding edge version is called.

At a minimum you could establish a convention for bug titles:

[4.2.0]: bug title
eastwind is offline   Reply With Quote
Old January 19, 2020, 09:34   #4
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 54
Posts: 7,974
Donated: $60
Nick will become famous soon enough
So one thing you can do is set the milestone on the right to be "Triage". But I'll be going through these as they come in (roughly) and putting milestones and types against them. I'll try to tighten up the whole procedure a bit too, and give more guidelines.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old January 20, 2020, 06:13   #5
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 54
Posts: 7,974
Donated: $60
Nick will become famous soon enough
Here are step-by-step instructions for reporting a bug. Depending on the nature of the bug, it may be worth some preliminary enquiries to see whether it is actually a bug or simply a wonderful, surprising piece of game design.
  1. Go to the issues page on Github.
  2. Click the green "New Issue" button near the top right.
  3. Give a short descriptive title to your bug; if it's not a report for the current official release, please include what version it it in your title.
  4. In the "Write" pane below the title, give sufficient details to fully describe the problem; this can include links.
  5. Add any relevant files (a savefile is sometimes helpful).
  6. Click "Labels" on the right and add a type label from the list (they start with "T:") - usually you will want T: bug.
  7. Click "Milestone" on the right and choose the "Triage" milestone.
  8. Click the green "Submit new issue" button at the bottom and you are done.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old January 20, 2020, 06:27   #6
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 54
Posts: 7,974
Donated: $60
Nick will become famous soon enough
Quote:
Originally Posted by DavidMedley View Post
Any guidelines to this? Like, I sometimes post some very minor bugs in the "4.2 bugs thread." Seems like if no one wants to tackle them it's pretty easy to just scroll past. I'd be more concerned about cluttering up this list. Also, there's a good number of feature requests in here. If any GitHub user can submit those then clutter is even more of a concern.
I think I'd actually prefer submitting via the issues page - it's pretty easy for me to close things that aren't valid bugs. If clutter starts becoming a problem, maybe I'll change my opinion...

Quote:
Originally Posted by DavidMedley View Post
What about people not in the dev pool taking on some of these? There's a sticky over in the Development forum about issues that non-coders can take on. Looking through this GitHub Issues list I suspect there's a fair number that you wouldn't implement even if you could with a snap of your fingers, tho.
I have now done a bit of work on curating the issues list, and open issues are now in one of three milestones:
  • Ongoing - these are issues which have to be repeated from time to time (like checking for memory leaks), and will likely never be closed.
  • Future - these are aspirational goals written by a variety of people. Anyone thinking of resolving one of these should discuss first to check it's actually wanted.
  • 4.2 - if anyone resolves one of these and gives me code or a pull request, I will be very happy

Does this answer your question?
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old January 21, 2020, 01:42   #7
DavidMedley
Swordsman
 
Join Date: Oct 2019
Posts: 312
DavidMedley is on a distinguished road
Quote:
Originally Posted by Nick View Post
actually a bug or simply a wonderful, surprising piece of game design
This brightened my day
DavidMedley is offline   Reply With Quote
Old January 21, 2020, 01:43   #8
DavidMedley
Swordsman
 
Join Date: Oct 2019
Posts: 312
DavidMedley is on a distinguished road
Quote:
Originally Posted by Nick View Post
Does this answer your question?
Yes, the details in this thread are very helpful! Thanks!
DavidMedley is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Tracking Change from Frog Knows Forward moonsdad Development 4 January 20, 2018 11:24
Tracking an annoying monster message bug PowerWyrm Vanilla 0 October 20, 2017 11:15
Dev tracking for pete Pete Mack Development 43 February 8, 2016 21:23
Tracking Angband using Mercurial (DVCS) d_m Vanilla 5 June 18, 2009 23:45
[D] Bug tracking help request. APWhite Variants 1 July 24, 2007 11:35


All times are GMT +1. The time now is 09:37.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2020, vBulletin Solutions Inc.