Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Variants

Reply
 
Thread Tools Display Modes
Old November 8, 2012, 12:39   #101
ekolis
Knight
 
ekolis's Avatar
 
Join Date: Apr 2007
Location: Cincinnati, OH, USA
Age: 36
Posts: 911
ekolis is on a distinguished road
Send a message via AIM to ekolis Send a message via MSN to ekolis Send a message via Yahoo to ekolis
Hmm, looks like you already have a base Artist class which all the frontend Artist classes inherit from, so this won't be as hard as it looked initially! Just need to put that view-model layer in there... but we'll need to leave flexibility for drawing things that cross tile boundaries, too (at least for the graphical frontends) - such as any beams, bolts, explosions, and particle effects! (I know Derakon was talking about those a while back! )
__________________
You read the scroll labeled NOBIMUS UPSCOTI...
You are surrounded by a stasis field!
The tengu tries to teleport, but fails!
ekolis is offline   Reply With Quote
Old November 8, 2012, 16:23   #102
Derakon
Prophet
 
Derakon's Avatar
 
Join Date: Dec 2009
Posts: 8,979
Derakon is on a distinguished road
I thought that the UI was in pretty good shape, actually. We spent a lot of time on cleaning it up, so now there's very little code that's actually identical across frontends. Of course there's plenty of code that's similar but not actually identical, but that's because the UIs do similar things in different ways due to the libraries they work with. Still, if you can find improvements then go ahead!

As far as displaying messages in the main window, that was one of those things I always figured would be an option down the road. Personally I like having a separate message window that doubles as a message history; this way the messages don't cover over the action and there's no need to have -more- prompts. Of course I recognize that not everyone feels the same way -- hence why this would be an option.
Derakon is offline   Reply With Quote
Old November 9, 2012, 00:38   #103
ekolis
Knight
 
ekolis's Avatar
 
Join Date: Apr 2007
Location: Cincinnati, OH, USA
Age: 36
Posts: 911
ekolis is on a distinguished road
Send a message via AIM to ekolis Send a message via MSN to ekolis Send a message via Yahoo to ekolis
Well, right now the message window doesn't even appear
__________________
You read the scroll labeled NOBIMUS UPSCOTI...
You are surrounded by a stasis field!
The tengu tries to teleport, but fails!
ekolis is offline   Reply With Quote
Old November 9, 2012, 01:00   #104
Derakon
Prophet
 
Derakon's Avatar
 
Join Date: Dec 2009
Posts: 8,979
Derakon is on a distinguished road
Well, that's not good. Does it appear if you launch with "-ui=QT"? That will use the QT frontend instead of the WX one.

The WX one launches the windows with hardcoded positions, and the message frame starts at (840, 200). I suppose if your display only had 800 pixels of horizontal resolution then you wouldn't be able to see it at all. The default positions should be changed since I'm guessing not everyone has a gigantic display to work with.

...in fact, let's go ahead and fix that. The main window now defaults (in WX) to (50, 50), and the message window defaults to immediately below the main window. That should keep it visible for everyone.

EDIT: er, this will be fixed next time I push, anyway. In the meantime you can change this trivially by modifying gui/wxPyrel/mainFrame.py:
Code:
         # Make us big enough for an 80x24 view, by default.
         self.SetClientSize((width * 80, height * 24))
-        self.SetPosition((200, 200))
-        messageFrame.makeWindow(self, (840, 200))
+        self.SetPosition((50, 50))
+        messageFrame.makeWindow(self, (50, 50 + self.GetRect()[3]))

Last edited by Derakon; November 9, 2012 at 01:36.
Derakon is offline   Reply With Quote
Old November 9, 2012, 19:52   #105
AnonymousHero
Veteran
 
AnonymousHero's Avatar
 
Join Date: Jun 2007
Posts: 1,367
AnonymousHero is on a distinguished road
Just wondering... Would you accept patches adding nose tests and test cases for some of the pure logic modules at this point?

(Not making any big promises, but I though that I could at least contribute some basic tests for the grammar module. I'd mark all the known failures as "ignored" and and the ones that we expect to succeed with the current implementation would just be normal tests. It woudl be a sort of todo-list for the module.)
AnonymousHero is offline   Reply With Quote
Old November 9, 2012, 20:02   #106
Derakon
Prophet
 
Derakon's Avatar
 
Join Date: Dec 2009
Posts: 8,979
Derakon is on a distinguished road
Absolutely! nose looks to be a decent testing framework from my admittedly very cursory inspection, and I certainly don't object to having tests available, so if you want to make 'em, by all means!
Derakon is offline   Reply With Quote
Old November 11, 2012, 20:42   #107
Derakon
Prophet
 
Derakon's Avatar
 
Join Date: Dec 2009
Posts: 8,979
Derakon is on a distinguished road
Apparently Mercurial was a bigger roadblock to getting contributions from other devs than I thought it'd be, so Pyrel has been switched to Git. Same URL, just a different versioning system behind the scenes.

(Also the wiki and issue tracker were replaced, so that content needs to be transferred over...)
Derakon is offline   Reply With Quote
Old November 12, 2012, 23:09   #108
ekolis
Knight
 
ekolis's Avatar
 
Join Date: Apr 2007
Location: Cincinnati, OH, USA
Age: 36
Posts: 911
ekolis is on a distinguished road
Send a message via AIM to ekolis Send a message via MSN to ekolis Send a message via Yahoo to ekolis
Oh, so that explains why the pyrel repository I was following got turned into pyrel-hg! I was going to ask why you had two...

So seeing as I actually prefer Mercurial to Git, which repo should I work off of if I want to do some development? I can connect to the Git repo with the hggit plugin, but if you'd prefer that people using Mercurial connect only to the Mercurial repo for whatever reason...
__________________
You read the scroll labeled NOBIMUS UPSCOTI...
You are surrounded by a stasis field!
The tengu tries to teleport, but fails!
ekolis is offline   Reply With Quote
Old November 12, 2012, 23:30   #109
Derakon
Prophet
 
Derakon's Avatar
 
Join Date: Dec 2009
Posts: 8,979
Derakon is on a distinguished road
I think it very unlikely that I'll bother to keep both repos up to date, so I recommend just switching to pyrel and forgetting that pyrel-hg exists.
Derakon is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Pyrel dev log, part 2 Derakon Variants 126 September 11, 2012 23:03
Pyrel dev log Derakon Variants 64 June 8, 2012 11:58
Play FAangband part II Fendell Orcbane AAR 6 November 29, 2010 21:53
JBand progress log. PaulBlay Development 38 June 27, 2009 10:19
Quill, Part II Sirridan AAR 9 June 25, 2009 04:51


All times are GMT +1. The time now is 14:20.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2020, vBulletin Solutions Inc.