Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old October 24, 2017, 13:01   #31
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 52
Posts: 6,655
Donated: $60
Nick is on a distinguished road
Quote:
Originally Posted by kaypy View Post
Word of Recall seems to keep x,y location fixed, which may leave you stuck in a wall or worse yet off the valid map area for a savefile wrecking crash.

I'll go poke around in the source now and see if I can come up with a patch for it.
Problem is in prepare_next_level(), which assumes the player is arriving via stairs. Feel free to fix it, otherwise I will before too long
__________________
One Ring to rule them all, One Ring to find them,
One Ring to bring them all and in the darkness bind them.
Nick is offline   Reply With Quote
Old October 24, 2017, 14:35   #32
kaypy
Swordsman
 
Join Date: May 2009
Posts: 261
kaypy is on a distinguished road
Oops, hadn't noticed a new post had come in (it was on the next page)

There should be a first pass patch on github now

It should probably use a similar approach to the teleport code, but I wanted to get something up quick...

(my first thought was to call into the teleport routine, but its kinda linked into the player-activation stuff, also the range isnt really relevant for level creation time...)
kaypy is offline   Reply With Quote
Old October 24, 2017, 14:49   #33
kaypy
Swordsman
 
Join Date: May 2009
Posts: 261
kaypy is on a distinguished road
Quote:
Originally Posted by kaypy View Post
BTW, I am seeing a fair amount of code like
Code:
level_by_depth(p->depth + 1)
in the new code.

Does that cooperate with the stair_skip constant?
I double checked this and the stair connections break if stair_skip is set to != 1

There is also the matter of z_info->max_depth.

dungeon_get_next_level is almost what you want here, but unfortunately it is set to also block on quest levels...

...

Hmm. If create stair is disabled, does killing Sauron work?...
kaypy is offline   Reply With Quote
Old October 24, 2017, 22:31   #34
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 52
Posts: 6,655
Donated: $60
Nick is on a distinguished road
Thanks, I'll look at this properly soon.
__________________
One Ring to rule them all, One Ring to find them,
One Ring to bring them all and in the darkness bind them.
Nick is offline   Reply With Quote
Old October 25, 2017, 00:24   #35
Sky
Knight
 
Join Date: Oct 2016
Location: Glasgae
Age: 45
Posts: 766
Sky is on a distinguished road
got another unrecoverable crash.

recalling back to town gave me a "invalid player location" error, and a broken save file.
https://drive.google.com/open?id=0B9...2tvY2tmRTZVVnM
__________________
#ARKENSTONESMATTER
Sky is offline   Reply With Quote
Old October 25, 2017, 02:46   #36
kaypy
Swordsman
 
Join Date: May 2009
Posts: 261
kaypy is on a distinguished road
Quote:
Originally Posted by Sky View Post
got another unrecoverable crash.
This is the one I just put up a patch for...

(The patch will stop the initial crash- I dont *think* it will recover the file though...)
kaypy is offline   Reply With Quote
Old October 25, 2017, 12:42   #37
kaypy
Swordsman
 
Join Date: May 2009
Posts: 261
kaypy is on a distinguished road
I've got a seg fault here if I recall.

savefile.zip

The stack trace points at something in the sdl font handling, but I doubt that is where memory is getting first mishandled...

I am running with the recall patches, but they dont do anything interesting with memory, so I woudn't guess the problem is there?

Hmm. I wonder what happens if I wander up to the top-left where my code may not be called at all? (This might also be a way to test against unpatched code without the out-of-bounds crash interfering)

...

it still crashes on the top-left area...
kaypy is offline   Reply With Quote
Old October 25, 2017, 13:37   #38
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 52
Posts: 6,655
Donated: $60
Nick is on a distinguished road
Quote:
Originally Posted by kaypy View Post
I've got a seg fault here if I recall.

Attachment 1586

The stack trace points at something in the sdl font handling, but I doubt that is where memory is getting first mishandled...
Found it, it's bad string handling in savefile loading. I'll get a fix up soon.

EDIT: Correction, that's a small problem that doesn't cause the crash. There's a bigger issue I haven't nailed down yet.
__________________
One Ring to rule them all, One Ring to find them,
One Ring to bring them all and in the darkness bind them.
Nick is offline   Reply With Quote
Old October 25, 2017, 14:19   #39
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 52
Posts: 6,655
Donated: $60
Nick is on a distinguished road
OK, latest build fixes the problem, that savefile should work fine now.
__________________
One Ring to rule them all, One Ring to find them,
One Ring to bring them all and in the darkness bind them.
Nick is offline   Reply With Quote
Old October 25, 2017, 17:03   #40
kaypy
Swordsman
 
Join Date: May 2009
Posts: 261
kaypy is on a distinguished road
That got it. Thanks
kaypy is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Getting levels Angrist Vanilla 6 January 13, 2015 10:26
Persistent bugs Ingwe Ingweron Development 9 October 24, 2013 15:45
Variant with persistent dungeons? Sabreman Variants 5 November 15, 2007 22:22
Feature Request: Optionally persistent dungeon levels TJA Vanilla 6 August 22, 2007 11:42
[Un, others] Difficulty levels andrewdoull Variants 10 May 29, 2007 23:00


All times are GMT +1. The time now is 22:23.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2017, vBulletin Solutions, Inc.