Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Development

Reply
 
Thread Tools Display Modes
Old May 18, 2013, 23:04   #1
molybdenum
Apprentice
 
Join Date: May 2013
Posts: 84
molybdenum is on a distinguished road
OS X Window Scaling

I've been poking around the source to fix the window resize issue (1743). While the basic fix is easy, getting it to work with the existing drawing code is turning out to be a pain. I was wondering if there was a rationale for drawing the views in that manner; I don't want to rip out a lot of code if there was a purpose for it.

I'm a Cocoa developer, so I'm seeing a lot of other things that could be cleaned up. Should I file tickets or should I just make changes and issue pull requests? I don't want to muck up any workflows you guys have.
molybdenum is offline   Reply With Quote
Old May 18, 2013, 23:52   #2
takkaria
Veteran
 
takkaria's Avatar
 
Join Date: Apr 2007
Posts: 1,936
Donated: $40
takkaria is on a distinguished road
Quote:
Originally Posted by molybdenum View Post
I've been poking around the source to fix the window resize issue (1743). While the basic fix is easy, getting it to work with the existing drawing code is turning out to be a pain. I was wondering if there was a rationale for drawing the views in that manner; I don't want to rip out a lot of code if there was a purpose for it.

I'm a Cocoa developer, so I'm seeing a lot of other things that could be cleaned up. Should I file tickets or should I just make changes and issue pull requests? I don't want to muck up any workflows you guys have.
I don't think we really have a Cocoa workflow at the moment. Myshkin has been mostly doing Cocoa stuff but I don't think he's worked on the code for a long time. I think (and I'm sure myshkin will correct me if I'm wrong) you're good to go ahead and submit pull requests. Cocoa could definitely do with some love.
__________________
takkaria whispers something about options. -more-
takkaria is offline   Reply With Quote
Old May 19, 2013, 00:33   #3
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 54
Posts: 7,864
Donated: $60
Nick will become famous soon enough
Quote:
Originally Posted by molybdenum View Post
I'm a Cocoa developer, so I'm seeing a lot of other things that could be cleaned up. Should I file tickets or should I just make changes and issue pull requests? I don't want to muck up any workflows you guys have.
Oh yes please just fix it for us.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old May 19, 2013, 00:53   #4
scud
Swordsman
 
Join Date: Jan 2011
Location: Sarf Laaaahdon
Posts: 323
scud is on a distinguished road
Quote:
Originally Posted by Nick View Post
Oh yes please just fix it for us.
What Nick said.
scud is offline   Reply With Quote
Old May 20, 2013, 11:50   #5
Pete Mack
Prophet
 
Join Date: Apr 2007
Location: Seattle, WA
Posts: 5,424
Donated: $40
Pete Mack is on a distinguished road
Quote:
Originally Posted by scud View Post
What Nick said.
Ditto. I worked on the Carbon port about 10 years back; now that Carbon is no longer supported, OSX users need a Compleat Cocoa Port... Unfortenately for me, I am now a Windows 8/Metro user...
Pete Mack is online now   Reply With Quote
Old May 31, 2013, 06:14   #6
molybdenum
Apprentice
 
Join Date: May 2013
Posts: 84
molybdenum is on a distinguished road
I submitted a pull request a few days ago and wasn't sure if I should announce it here as well (another thread made me think it might be advisable). I was able to get resizing in without changing too much of the drawing code. The only problem is that when you change fonts or enter full screen, you need to bump the mouse or tap a key to get it to redraw. Otherwise, it's quite playable.

I'm swamped with work for the next few weeks, but after that, I should have some time to give the code a proper cleanup. I just wanted to get the main changes out so people could actually play.
molybdenum is offline   Reply With Quote
Old May 31, 2013, 07:29   #7
Derakon
Prophet
 
Derakon's Avatar
 
Join Date: Dec 2009
Posts: 8,951
Derakon is on a distinguished road
Hooray, excellent news! Thank you very much for working on this. I'll try to notify the other devs in #angband-dev about the pullreq in case they haven't seen it yet; I don't personally have permission to accept them.
Derakon is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
[3.3] Bug in overhead window. Timo Pietilš Development 1 July 26, 2011 23:21
Terminal window hell cutty Vanilla 2 January 12, 2010 16:01
Post your window arrangements. Tobias Vanilla 31 January 6, 2010 16:51
Linux Window positioning fph Vanilla 4 November 16, 2009 14:19
Dungeon window size Bodkin Vanilla 2 March 30, 2008 05:48


All times are GMT +1. The time now is 17:49.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.