[3.5-dev] Gorged status missing?

[Derakon]

Spacebux is claiming that Slow Digestion is Stop Digestion in 3.5, though. I asked if he was sure because I wasn't aware of this being an official change and I know that "normally slow" digestion in previous versions meant you could go an awfully long time without food. But 50k turns is a bit much.

Any of the other devs care to comment?

[DaviddesJ]

Originally Posted by Derakon

Spacebux is claiming that Slow Digestion is Stop Digestion in 3.5, though.

No. He's claiming that, in some circumstances, Slow Digestion can reduce your food consumption rate to zero. Not that it always does.

[Spacebux]

Feel free to TEST IT guys. 'gb1011f7' is the nightly I'm using...

Let me state it simply here:
If you have a piece of equipment that gives your character 'Slow Digestion' in the 3.5-dev-gb1011f7 version, your character no longer digests food, not even 1 tick. 'Slow' means 'Stop' in this case.

Shall I need to start quoting code here? I'm not a developer, nor do I play one on t.v., but I can still decipher code if I have to.

[Derakon]

Here's the relevant block of code from dungeon.c's process_world():

    /* Digest normally */
    if (!(turn % 100))
    {
        /* Basic digestion rate based on speed */
        i = extract_energy[p_ptr->state.speed] * 2;

        /* Regeneration takes more food */
        if (check_state(p_ptr, OF_REGEN, p_ptr->state.flags)) i += 30;

        /* Slow digestion takes less food */
        if (check_state(p_ptr, OF_SLOW_DIGEST, p_ptr->state.flags)) i = 1;

        /* Minimal digestion */
        if (i < 1) i = 1;

        /* Digest some food */
        player_set_food(p_ptr, p_ptr->food - i);
    }

So yeah, if you have slow digestion, then regeneration and speed effects on digestion are completely overwritten. You do still have some digestion, but it's 10 times slower than what an ordinary character at normal speed would have. I could easily believe that'd mean you could go 50k turns without getting hungry.

DaviddesJ, I appreciate your desire for clarity, but in this case it really came across as you doubting Spacebux' word. It's clear he got irritated by the constant questioning of what he had to say. I admit I started things with the "are you sure?" question, but piling onto him after me did not help.

[Spacebux]

Originally Posted by Derakon

Here's the relevant block of code from dungeon.c's process_world():

    /* Digest normally */
/* ... snipped ... */ 
    }

So yeah, if you have slow digestion, then regeneration and speed effects on digestion are completely overwritten. You do still have some digestion, but it's 10 times slower than what an ordinary character at normal speed would have. I could easily believe that'd mean you could go 50k turns without getting hungry.

DaviddesJ, I appreciate your desire for clarity, but in this case it really came across as you doubting Spacebux' word. It's clear he got irritated by the constant questioning of what he had to say. I admit I started things with the "are you sure?" question, but piling onto him after me did not help.

I sit corrected. I now know it takes a very_long_time, but yes, after 80,000 turns of resting, "You are no longer full." did appear.

The code is working as written... .

[DaviddesJ]

Originally Posted by Derakon

DaviddesJ, I appreciate your desire for clarity, but in this case it really came across as you doubting Spacebux' word.

I don't think that's what I said. If it's true that Slow Digestion completely overrides other effects on food consumption rate, then that seems like a poor design, to me. Even though food hardly matters in Angband.

[Daniel Fishman]

Is that how it's always worked, or has it changed recently?

[DaviddesJ]

Originally Posted by Daniel Fishman

Is that how it's always worked, or has it changed recently?

It was i -= 10 in 3.4.1. I guess someone changed it because Slow Digestion was so weak. Of course, even if it stops digestion completely, it's still weak.

Maybe the OP's point was right and it should really be renamed to "Prevent Hunger" and it should permanently (while you equip it) make you need no food and never get gorged either. At least then you could consider it slightly useful.

[scud]

As Edwin Starr so nearly sang: Food. Huh! What is it good for?

In the many hundreds of games of Moria/Angband I've played over the last couple of decades I don't think I've ever starved to death, and can count the times I've been driven home by either a potion of salt water or a GGG on the fingers of one hand.

Can't we just assume that we shakedown kobold corpses for candy bars and do away with rations?

[Oramin]

Tradition, my friend.

It wouldn't feel like a Rogue-like game if you eliminated the need for food.