SDL2 port when ?

[t4nk]

Originally Posted by shirish

argh... that's horrible if I am seeing this right -

~/games/angband-t4nk074/lib/save$ file Shirish 
Shirish: data

I was expecting a nice .json type file but it's not to be

Yes, Angband is pretty old Older than Javascript...

I did as you shared and this time did hear a thunder but that's about it.
Nice. So it seems we have sounds, but doesn't seem to have any background music, although you might be better judge of that. Is that it as far as music is concerned ?

TBH, I never played it with sound either. All sounds are in angband/lib/sound: looks like there are some twangs and clicks and that's about it. Pretty sure it doesn't have any music.

[t4nk]

If anyone has any bug reports or comments about the SDL2 port, don't hesitate to post here. Now that I opened the pull request, I'll be maintaining it. The compilation instructions are here: http://angband.oook.cz/forum/showpos...1&postcount=24
If you get errors, try to compile without sound. Anyway, I'll fix the branch soon

[t4nk]

I pushed some more small cleanups (to snd-sdl.c, as discussed previously, and also fixes to some comments), but it looks like sdl2 is already merged Thanks, Takkaria. I guess Makefile.sdl2 is not necessary. Anyway, you can find three more commits here: https://github.com/t4nk074/angband/commits/sdl2

Not sending it as a pull request, since it's utterly trivial stuff, but might be useful to Nick when he'll get around to it.

[Magnate]

Originally Posted by takkaria

(Hi magnate!)

And hello takk!

[Nick]

Originally Posted by t4nk

I pushed some more small cleanups (to snd-sdl.c, as discussed previously, and also fixes to some comments), but it looks like sdl2 is already merged Thanks, Takkaria. I guess Makefile.sdl2 is not necessary. Anyway, you can find three more commits here: https://github.com/t4nk074/angband/commits/sdl2

Thanks, I have merged these.

The latest build on the nightlies page has this plus a failed attempt to get the standard build system to build the SDL2 port. I have at least left it so that the build system works if you don't try to use SDL2, and so that you can use Makefile.sdl2 to use the SDL2 port. If anyone is better at getting the build system and autotools to work (and surely someone must be), please have a go.

[t4nk]

Originally Posted by Nick

Thanks, I have merged these.

The latest build on the nightlies page has this plus a failed attempt to get the standard build system to build the SDL2 port. I have at least left it so that the build system works if you don't try to use SDL2, and so that you can use Makefile.sdl2 to use the SDL2 port. If anyone is better at getting the build system and autotools to work (and surely someone must be), please have a go.

Thanks, Nick! After some f...g around it seems to work for me:
https://github.com/angband/angband/pull/503
At least, it brings us closer to the goal, I think

[fph]

Works for me, too (Ubuntu 18.04), after installing the sdl2 devel packages and running autogen.sh from scratch. Thanks t4nk!

[Nick]

Originally Posted by t4nk

Thanks, Nick! After some f...g around it seems to work for me:
https://github.com/angband/angband/pull/503
At least, it brings us closer to the goal, I think

Awesome! That all works for me too - you can't configure with both SDL2 and SDL, but (a) they both work separately and (b) why would you want to? That's merged now and the new build is up on the nightlies page. I guess at some point the guts of Makefile.sdl2 can be rolled into Makefile.std and Makefile.sdl2 removed.

The thing that was really getting me was why I couldn't get it to use sdl2-config, which I assume was the AM_PATH_SDL2 thing. Thanks for clearing that up

[t4nk]

Originally Posted by Nick

Awesome! That all works for me too - you can't configure with both SDL2 and SDL

It's impossible to link with both at the same time anyway - they have plenty of functions with same names (and use headers with same names, too, like that SDL.h). The build system should probably prevent attempts to use both... alternatively, consider deprecating SDL1

I guess at some point the guts of Makefile.sdl2 can be rolled into Makefile.std and Makefile.sdl2 removed.

Well, if you want to revive Makefile.std, I can do it.
I also noticed that the long-standing bug with panel redraws while running is still there. I should probably fix that, too.
Again, in several days, maybe

[fph]

Issue: the SDL2 port does not display the cursor. This makes the 'look' command, for instance, almost unusable.