Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old May 24, 2013, 10:40   #1
PowerWyrm
Veteran
 
PowerWyrm's Avatar
 
Join Date: Apr 2008
Posts: 2,137
PowerWyrm is on a distinguished road
[3.5-dev] Store refactoring

Latest attempt at fixing store bugs concerning staples had the following comment:

"No store has a staple item which it buys, and which has magic but non-ego
varieties..."

However, the same commit added diggers to the General Store, which can be generated as magical...
__________________
PWMAngband variant maintainer - check http://www.mangband.org/forum/viewforum.php?f=9 to learn more about this new variant!
PowerWyrm is offline   Reply With Quote
Old May 24, 2013, 14:32   #2
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,054
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate Send a message via Skype™ to Magnate
Quote:
Originally Posted by PowerWyrm View Post
Latest attempt at fixing store bugs concerning staples had the following comment:

"No store has a staple item which it buys, and which has magic but non-ego
varieties..."

However, the same commit added diggers to the General Store, which can be generated as magical...
But diggers have egos, so the comment is true
__________________
"3.4 is much better than 3.1, 3.2 or 3.3. It still is easier than 3.0.9, but it is more convenient to play without being ridiculously easy, so it is my new favorite of the versions." - Timo Pietila
Magnate is offline   Reply With Quote
Old May 24, 2013, 16:18   #3
PowerWyrm
Veteran
 
PowerWyrm's Avatar
 
Join Date: Apr 2008
Posts: 2,137
PowerWyrm is on a distinguished road
With the new system implemented, staples are created when there's no item of the same kind that is not an ego in the store. If the player sells a non- ego item to the store, it will stack to the staples if it's not magical, but not if it's magical. If you buy all staples of that kind, no more will be generated in the store. This can happen if you sell a magical digger in the General Store.
__________________
PWMAngband variant maintainer - check http://www.mangband.org/forum/viewforum.php?f=9 to learn more about this new variant!
PowerWyrm is offline   Reply With Quote
Old May 27, 2013, 08:01   #4
Timo Pietilš
Prophet
 
Join Date: Apr 2007
Location: Climbing up from hole I just dug.
Posts: 4,080
Timo Pietilš is on a distinguished road
Quote:
Originally Posted by PowerWyrm View Post
With the new system implemented, staples are created when there's no item of the same kind that is not an ego in the store. If the player sells a non- ego item to the store, it will stack to the staples if it's not magical, but not if it's magical. If you buy all staples of that kind, no more will be generated in the store. This can happen if you sell a magical digger in the General Store.
I have hard time following what is happening here. Correct me if I got this wrong:
  1. You sell magical digger in store
  2. you buy all non-magical diggers from store
result: no more non-magical diggers in store. Ever? is the step 1 required for that to happen?


What is this "staple item" anyway?
Timo Pietilš is offline   Reply With Quote
Old May 27, 2013, 14:06   #5
PowerWyrm
Veteran
 
PowerWyrm's Avatar
 
Join Date: Apr 2008
Posts: 2,137
PowerWyrm is on a distinguished road
"Staples" are items that are always generated in a store. The logic behind this is to ensure that when a player buys some of these, the store will automatically restock to max. So if you buy 10 potions of cure light wounds from the temple, next time the temple restocks, you'll have 40 potions of cure light wounds in the store again.

This system works with items "by kind" and doesn't apply to ego items. For example, the General store sells shovels as "staples", so you'll always have 40 shovels (+0, +0) (+1) in the store. If you sell an ego shovel to the General Store, the system will not count it as a staple item, since it's an ego. So when restocking, it will discard the ego shovel and only restock the average ones to a stack of 40.

Now suppose you sell an enchanted non-ego shovel. Currently, the system will not discard it and restock the first item found of the same kind, which is the enchanted shovel. So after restock, if you bought all the average shovels, you'll get 40 enchanted shovels and no average ones.
__________________
PWMAngband variant maintainer - check http://www.mangband.org/forum/viewforum.php?f=9 to learn more about this new variant!
PowerWyrm is offline   Reply With Quote
Old May 27, 2013, 14:25   #6
Timo Pietilš
Prophet
 
Join Date: Apr 2007
Location: Climbing up from hole I just dug.
Posts: 4,080
Timo Pietilš is on a distinguished road
Quote:
Originally Posted by PowerWyrm View Post
... So after restock, if you bought all the average shovels, you'll get 40 enchanted shovels and no average ones.
OK. Now I understand what the bug was.
Timo Pietilš is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
[3.5-dev] Monster opening/bashing refactoring PowerWyrm Vanilla 3 June 27, 2013 13:19
Store Menu? Lord Fell Vanilla 28 November 15, 2010 08:11
Store oddities Derakon Vanilla 3 October 27, 2010 21:42
You see no store. ChodTheWacko Vanilla 5 June 3, 2010 04:05
General Store Malak Darkhunter Vanilla 3 January 11, 2009 18:21


All times are GMT +1. The time now is 01:31.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2017, vBulletin Solutions, Inc.