Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old May 28, 2017, 19:05   #41
Ingwe Ingweron
Veteran
 
Join Date: Jan 2009
Location: Manhattan Beach, CA
Posts: 1,449
Ingwe Ingweron is on a distinguished road
Quote:
Originally Posted by Nick View Post
I think this is more or less covered by this bug; see also this post and subsequent discussion.
Oops, sorry about that. I try not to duplicate bugs that are already in the bug list on the tracker.

One that I haven't found on the list, but that still persists - still get the rolls underfoot message for things that have been ignored, whether items or money.
__________________
“We're more of the love, blood, and rhetoric school. Well, we can do you blood and love without the rhetoric, and we can do you blood and rhetoric without the love, and we can do you all three concurrent or consecutive. But we can't give you love and rhetoric without the blood. Blood is compulsory. They're all blood, you see.”
― Tom Stoppard, Rosencrantz and Guildenstern are Dead
Ingwe Ingweron is offline   Reply With Quote
Old May 28, 2017, 23:16   #42
wobbly
Veteran
 
Join Date: May 2012
Location: Adelaide, Australia
Posts: 1,112
wobbly is on a distinguished road
Ok, build 4.0.3-748-g2e2a52b. If I cast rfire it doesn't id the fire rune. If I cast rfire while wearing a shield of rfire it does id the fire rune. Seems a bit weird.
wobbly is offline   Reply With Quote
Old May 30, 2017, 15:06   #43
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 52
Posts: 6,649
Donated: $60
Nick is on a distinguished road
New build up on the nightlies page, only a few changes this time:
  • Fix repetition of slays (and potentially brands) sometimes, as in Deathwreaker's description having two different levels of slay undead
  • Fix an interesting room which was getting generated cut off from the dungeon
  • Make probing much better - let me know if it's too much better

There are still 14 bugs on the tracker, plus some more in this thread. In particular, some fixes (and policy decisions) are needed for ID.
__________________
One Ring to rule them all, One Ring to find them,
One Ring to bring them all and in the darkness bind them.
Nick is offline   Reply With Quote
Old May 30, 2017, 17:10   #44
kandrc
Swordsman
 
Join Date: Dec 2007
Posts: 263
kandrc is on a distinguished road
Here are a stack trace showing the level generation bug. It occurs when placing special rooms in cave_generate(). This trace shows the failure while placing a vault, but I've also seen it while placing pits. Looks like there might be a bad test for special room placement?

To reproduce efficiently, I commented out the checks for stairs (grep for "I see no"), then you can run up and down the dungeon very quickly.

Code:
angband: cave-square.c:472: square_istrap: Assertion `square_in_bounds(c, y, x)' failed.

Program received signal SIGABRT, Aborted.
0x0000007fb7c77528 in __GI_raise (sig=sig@entry=6)
    at ../sysdeps/unix/sysv/linux/raise.c:54
54	../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb) bt
#0  0x0000007fb7c77528 in __GI_raise (sig=sig@entry=6)
    at ../sysdeps/unix/sysv/linux/raise.c:54
#1  0x0000007fb7c789e0 in __GI_abort () at abort.c:89
#2  0x0000007fb7c70c04 in __assert_fail_base (
    fmt=0x7fb7d5d0c0 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", 
    assertion=assertion@entry=0x5231f8 "square_in_bounds(c, y, x)", 
    file=file@entry=0x5231e8 "cave-square.c", line=line@entry=472, 
    function=function@entry=0x5234e8 <__PRETTY_FUNCTION__.9481> "square_istrap") at assert.c:92
#3  0x0000007fb7c70cac in __GI___assert_fail (
    assertion=0x5231f8 "square_in_bounds(c, y, x)", 
    file=0x5231e8 "cave-square.c", line=472, 
    function=0x5234e8 <__PRETTY_FUNCTION__.9481> "square_istrap")
    at assert.c:101
#4  0x0000000000408468 in square_istrap (c=0xaf1e18, y=67, x=99)
    at cave-square.c:472
#5  0x00000000004c53d8 in square_trap_flag (c=0xaf1e18, y=67, x=99, flag=2)
    at trap.c:90
#6  0x0000000000409514 in square_isplayertrap (c=0xaf1e18, y=67, x=99)
    at cave-square.c:712
#7  0x0000000000408c18 in square_isempty (c=0xaf1e18, y=67, x=99)
    at cave-square.c:570
#8  0x000000000043d580 in vault_monsters (c=0xaf1e18, y1=66, x1=100, depth=50, 
    num=2) at gen-util.c:734
#9  0x0000000000435a70 in build_room_template (c=0xaf1e18, y0=60, x0=100, 
    ymax=10, xmax=17, doors=3, 
    data=0x7b0448 '#' <repeats 18 times>, ".x.#9x.#.x9#.x.##...#...#...#...##123#321#123#321#%", '.' <repeats 15 times>, "%%", '.' <repeats 15 times>, "%#321#123#321#123##...#...#...#...##.x.#9x.#.x9#.x.", '#' <repeats 18 times>, tval=0)
    at gen-room.c:1010
#10 0x0000000000435d80 in build_room_template_type (c=0xaf1e18, y0=66, x0=198, 
    typ=1, rating=1) at gen-room.c:1074
#11 0x0000000000439f24 in build_template (c=0xaf1e18, y0=66, x0=198, rating=1)
    at gen-room.c:2388
#12 0x000000000043bbb8 in room_build (c=0xaf1e18, by0=0, bx0=0, profile=..., 
    finds_own_space=true) at gen-room.c:2994
#13 0x000000000042d3a4 in modified_chunk (depth=49, height=66, width=198)
    at gen-cave.c:1680
#14 0x000000000042da9c in modified_gen (p=0x798228) at gen-cave.c:1783
#15 0x00000000004279b0 in cave_generate (c=0x5738e0 <cave>, p=0x798228)
    at generate.c:864
#16 0x000000000042542c in run_game_loop () at game-world.c:999
#17 0x00000000004d62e4 in play_game (new_game=false) at ui-game.c:434
#18 0x000000000051b640 in main (argc=1, argv=0x7ffffff448) at main.c:524
(gdb) up
#1  0x0000007fb7c789e0 in __GI_abort () at abort.c:89
89	abort.c: No such file or directory.
(gdb) 
#2  0x0000007fb7c70c04 in __assert_fail_base (
    fmt=0x7fb7d5d0c0 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", 
    assertion=assertion@entry=0x5231f8 "square_in_bounds(c, y, x)", 
    file=file@entry=0x5231e8 "cave-square.c", line=line@entry=472, 
    function=function@entry=0x5234e8 <__PRETTY_FUNCTION__.9481> "square_istrap") at assert.c:92
92	assert.c: No such file or directory.
(gdb) 
#3  0x0000007fb7c70cac in __GI___assert_fail (
    assertion=0x5231f8 "square_in_bounds(c, y, x)", 
    file=0x5231e8 "cave-square.c", line=472, 
    function=0x5234e8 <__PRETTY_FUNCTION__.9481> "square_istrap")
    at assert.c:101
101	in assert.c
(gdb) 
#4  0x0000000000408468 in square_istrap (c=0xaf1e18, y=67, x=99)
    at cave-square.c:472
472		assert(square_in_bounds(c, y, x));
(gdb) print *c
$1 = {name = 0x0, created_at = 1, depth = 49, feeling = 0 '\000', 
  obj_rating = 593, mon_rating = 48477, good_item = false, height = 66, 
  width = 198, feeling_squares = 0, feat_count = 0x994c18, squares = 0x96c5e8, 
  noise = {grids = 0xa99408}, scent = {grids = 0xa99628}, objects = 0xb4f7a8, 
  obj_max = 127, monsters = 0xb4fbb8, mon_max = 50, mon_cnt = 49, 
  mon_current = -1}
(gdb)
kandrc is offline   Reply With Quote
Old May 30, 2017, 23:12   #45
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 52
Posts: 6,649
Donated: $60
Nick is on a distinguished road
Quote:
Originally Posted by kandrc View Post
Here are a stack trace showing the level generation bug.
Thank you so much. Nice tip on the check for stairs, too
__________________
One Ring to rule them all, One Ring to find them,
One Ring to bring them all and in the darkness bind them.
Nick is offline   Reply With Quote
Old May 31, 2017, 14:40   #46
Nomad
Knight
 
Nomad's Avatar
 
Join Date: Sep 2010
Location: England
Posts: 958
Nomad is on a distinguished road
Something still looks amiss with ego pricing... Just visited the town in 6ba537e and found the temple selling both a Whip (+5,+5) and a Whip of Slay Troll (+5,+5) for the exact same price of 696.
Nomad is offline   Reply With Quote
Old May 31, 2017, 15:07   #47
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 52
Posts: 6,649
Donated: $60
Nick is on a distinguished road
Quote:
Originally Posted by Nomad View Post
Something still looks amiss with ego pricing... Just visited the town in 6ba537e and found the temple selling both a Whip (+5,+5) and a Whip of Slay Troll (+5,+5) for the exact same price of 696.
Seems about right to me
__________________
One Ring to rule them all, One Ring to find them,
One Ring to bring them all and in the darkness bind them.
Nick is offline   Reply With Quote
Old May 31, 2017, 15:13   #48
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 52
Posts: 6,649
Donated: $60
Nick is on a distinguished road
New builds up on the nightlies page, some notable changes:
  • The level generation crash bug is fixed (completely, I hope - let me know if it is recurring), thanks to some awesome debugging by kandrc
  • Innate abilities like Half-Troll's regeneration imply knowledge of the relevant rune at birth
  • Runes are now learnt on selling as well as buying
  • Donating to shops in a no-selling game is now allowed wherever selling would be in a selling game, so you can give your sword {??} to the weaponsmith and learn all about it. If this is proving too easy, I'll make donating only possible to the Black Market

Please let me know how all this plays.
__________________
One Ring to rule them all, One Ring to find them,
One Ring to bring them all and in the darkness bind them.
Nick is offline   Reply With Quote
Old May 31, 2017, 15:16   #49
Nomad
Knight
 
Nomad's Avatar
 
Join Date: Sep 2010
Location: England
Posts: 958
Nomad is on a distinguished road
Quote:
Originally Posted by Nick View Post
Seems about right to me
Hey, it has plenty of value over the standard whip! After all, buying it identifies the rune of Slay Troll so you don't mistake it for anything useful in future.

Though after the monster changes are done I would still like to campaign for combining Slay Orc, Slay Troll and Slay Giant into one umbrella slay category that might then have some minor utility.
Nomad is offline   Reply With Quote
Old June 1, 2017, 03:14   #50
Nomad
Knight
 
Nomad's Avatar
 
Join Date: Sep 2010
Location: England
Posts: 958
Nomad is on a distinguished road
When I put on a ring with the cowardice curse, I get the "You are too afraid to attack" message if I try to hit anything, but the rune for the curse isn't learned and it stays unidentified. (Still playing 6ba537e at the moment.)
Nomad is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
4.1 pre-release Nick Vanilla 16 April 2, 2017 17:29
Bugfix release for 3.2? Timo Pietilš Development 69 April 14, 2011 21:59
3.2 release candidate is upon us! d_m Vanilla 147 January 19, 2011 11:10
reactions to changes in new V release will_asher Vanilla 50 April 9, 2008 19:47
UnAngband interim release in preparation; please help! Bandobras Variants 13 December 21, 2007 17:01


All times are GMT +1. The time now is 20:55.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2017, vBulletin Solutions, Inc.