Bugs and issues in 4.1.2

[Voovus]

Summoning (scroll/staff) now appears to always bring up out of depth uniques. Is that deliberate? These chaps have a tendency to instakill...

[Sky]

yup, it's deliberate, and useful.

[PowerWyrm]

Originally Posted by Nick

[*]Make rogue monsters drop ?Phase, and make stacks of ?Phase bigger

Master rogues don't drop the scrolls. Is that an overlook or is it intended?

[PowerWyrm]

Originally Posted by Nick

[*]Big reduction in trap frequency

Sure... the new formula places zero traps between DL1 and 14, then at most 1 trap between DL15 and 29, then at most 2 traps after that. Too much reduction no?

[geoff_tewierik]

Got a disconnected Map here in 4.1.2, first time I've seen it, only reason I know is because I hit a teleport trap and it sent me into the seperate section. Have used ?Mapping and _Mapping to confirm.

Hopefully others can see the same and I'm not embarrassing myself...again.

File attached.

[Nick]

Originally Posted by PowerWyrm

Sure... the new formula places zero traps between DL1 and 14, then at most 1 trap between DL15 and 29, then at most 2 traps after that. Too much reduction no?

Good grief. I'll check that when I'm back to my dev machine on the weekend.

Originally Posted by geoff_tewierik

Got a disconnected Map here in 4.1.2, first time I've seen it, only reason I know is because I hit a teleport trap and it sent me into the seperate section. Have used ?Mapping and _Mapping to confirm.

Hopefully others can see the same and I'm not embarrassing myself...again.

File attached.

Thanks, will check this too.

[PowerWyrm]

Originally Posted by Voovus

Summoning (scroll/staff) now appears to always bring up out of depth uniques. Is that deliberate? These chaps have a tendency to instakill...

A bug. Commit 9c5b10b, mon-summon.c, summon_specific_okay():

/* A valid base and no match means disallowed */
	while (bases) {
		if (race->base == bases->base) return true;
		if (bases->next == NULL) return false;
		bases = bases->next;
	}

should probably be:

/* A valid base and no match means disallowed */
	while (bases) {
		if (race->base == bases->base) break;
		if (bases->next == NULL) return false;
		bases = bases->next;
	}

to keep the old behavior.

[Anthon]

If you know many (or all) of the available items from previous runs, you can identify single items by toggling the ignore status of a all items of a particular type via the "item ignoring setup" (= in rogue mode), then select ignore item (^D in rogue mode), select the un-ID item. In its ignore options the b) option will toggle from "b) All" to "b) Unignore all".

The above assumes you did not ignore the unidentified flavor. What b) should always indicate for non-ID-ed items is the ignore status of the flavor.

Details on how this can be exploited:

If you don't want to go through toggling (e.g.) each potion to see what your unidentified flavor matches with, you can just set to ignore anything you don't want to drink up front. Then do not try anything you have not identified, until you checked if you can unignore it (then don't) or not (feel free to try).

Practical example: As a mage I don't ever want to drink PoContemplation. So I would normally buy it when available and then discard (or sell depending on the birth settings). With the exploit, I just set to ignore PoContemplation before ever encountering it. Once I stumble on an un-identified potion, I initiate the ignore-an-item sequence to see if option b) is unignore or not. If it is un-ignore, don't drink it.

[PowerWyrm]

Originally Posted by PowerWyrm

A bug. Commit 9c5b10b, mon-summon.c, summon_specific_okay()

In fact that's a totally unrelated bug. It just allows WRAITH to summon any W, not just unique Ws (Ringwraiths).

[Sky]

noo .. don't take away my summons!