Register FAQ Members List Calendar Search Today's Posts Mark Forums Read

 March 1, 2021, 20:15 #2 Nick Vanilla maintainer     Join Date: Apr 2007 Location: Canberra, Australia Age: 55 Posts: 8,765 Donated: \$60 There's a line for skill-device in each of p_race.txt and class.txt, and negative values are fine - half-trolls have a device skill of -8 in V, for example. __________________ One for the Dark Lord on his dark throne In the Land of Mordor where the Shadows lie.
 March 1, 2021, 21:43 #3 tangar Knight     Join Date: Mar 2015 Posts: 788 yep.. but eg Hydra race (in T) with skill-device:-50 have 83% chance for success with cure light wounds staff.. as in character sheet (shift+C) hydra got 0 at MD. So it seems we need to change formula somehow __________________ https://tangaria.com - Angband multiplayer variant tangaria.com/variants - Angband variants table tangar.info - my website ⍽⍽⍽⍽⍽⍽⍽⍽⍽⍽⍽⍽ My chars @ angband.oook.cz youtube.com/GameGlaz — streams in English ⍽ youtube.com/StreamGuild — streams in Russian
March 2, 2021, 08:05   #4
PowerWyrm
Prophet

Join Date: Apr 2008
Posts: 2,857
Quote:
 Originally Posted by Nick There's a line for skill-device in each of p_race.txt and class.txt, and negative values are fine - half-trolls have a device skill of -8 in V, for example.
Doesn't work. The calculated skill is rounded up to 0, which translates to a formula in get_use_device_chance() of fail = 100 * (- lvl - 140) / (lvl - 90).

A level 0 device would have fail = 15% and a level 40 device (like staff of speed) would have fail = 36%. There aren't many devices with higher level

This formula always uses negative values for whatever reason and is outright bugged (rod of speed is level 95 and gives negative value of fail chance, which is translated to 1% fail chance). I think this needs to be simplified.
__________________

 March 2, 2021, 10:37 #5 Nick Vanilla maintainer     Join Date: Apr 2007 Location: Canberra, Australia Age: 55 Posts: 8,765 Donated: \$60 Ah, I thought you were talking about input values. Agreed, that formula is obscure and outdated (looks like there weren't any level 95 devices when it was written). Also there's the Code: `/* TODO: maybe use something a little less convoluted? */` comment, which is itself very old... I'll mark this as to fix for 4.2, but it probably won't make 4.2.2. __________________ One for the Dark Lord on his dark throne In the Land of Mordor where the Shadows lie.

 Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 Thread Tools Display Modes Linear Mode

 Posting Rules You may not post new threads You may not post replies You may not post attachments You may not edit your posts BB code is On Smilies are On [IMG] code is On HTML code is Off Forum Rules
 Forum Jump User Control Panel Private Messages Subscriptions Who's Online Search Forums Forums Home Angband     AAR     Vanilla     Development     ToME     Sil     Variants     Competition The real world     Idle chatter     Oook! Obsolete     v4

 Similar Threads Thread Thread Starter Forum Replies Last Post Bogatyr Vanilla 3 August 24, 2019 10:21 scud Vanilla 4 June 29, 2013 23:25 Scraper Vanilla 6 October 22, 2011 17:05 Cauldron Vanilla 8 May 17, 2009 10:56 Dragonboneman Vanilla 7 February 2, 2008 14:10

All times are GMT +1. The time now is 01:02.