Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Development

Reply
 
Thread Tools Display Modes
Old March 7, 2009, 17:24   #1
PaulBlay
Knight
 
Join Date: Jan 2009
Posts: 657
PaulBlay is on a distinguished road
Code import etiquette / legalities

This is pretty much a newbie question, but what is involved if I want
to import some feature from Angband to an Angband variant?

Is it enough to put something like
Code:
/* 
 * Copyright (C) 2007 by takkaria
 * Code modified from Angband 3.1.0 source for [variant] by Paul Blay 2009
 */
on the top or does the variant have to be under the GPL ?
Can 'just that bit' be under the GPL?

Anyway I'd like some pointers (not wanting to tread on anybody's toes).
__________________
Currently turning (Angband) Japanese.
PaulBlay is offline   Reply With Quote
Old March 7, 2009, 19:52   #2
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
If it's your own variant, you can decide on your own licensing scheme (and we hope you'll choose the GPL) - and there are standard dual-licence notices at the top of each code block in V, so you can just reproduce it with the bit that you borrow (you can use either of the two offered licences for borrowed code - again, we hope you'll choose the GPL). (That is, unless Takkaria wants all code borrowed from V to be dual-licensed, but I don't think he does.)

If it's someone else's variant, you should get the maintainer's views on how s/he wants to licence code borrowed from V.

If it's a variant without a current maintainer, your guess is as good as mine. I'd stick to the GPL in every case.

CC
Magnate is offline   Reply With Quote
Old March 7, 2009, 20:12   #3
PaulBlay
Knight
 
Join Date: Jan 2009
Posts: 657
PaulBlay is on a distinguished road
Quote:
Originally Posted by Magnate View Post
If it's someone else's variant, you should get the maintainer's views on how s/he wants to licence code borrowed from V.
Good point. I didn't realise there were options.

I shall sound out the maintainer on GPL (it isn't currently under GPL).

A fair bit of the code is from earlier versions of other variants (and Angband itself) so I suppose many of the people who wrote that code have agreed to GPL for the current Angband (and possibly some of the variants in between). If he likes the idea I suppose whoever organized the GPL effort for Angband may be able to help him out if he wants to go that way for the rest of the code in his variant.
__________________
Currently turning (Angband) Japanese.
PaulBlay is offline   Reply With Quote
Old March 7, 2009, 23:35   #4
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by PaulBlay View Post
whoever organized the GPL effort for Angband
That would be another of Takkaria's impressive achievements. There's quite a lot of detail on rephial.org about who has been contacted and exactly what code or other contribution they've made. This should make it easier to identify which bits of the variant can be considered GPLd, and any which can't yet be.

CC
Magnate is offline   Reply With Quote
Old March 7, 2009, 23:41   #5
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 54
Posts: 7,836
Donated: $60
Nick will become famous soon enough
In fact, see here for takkaria's brief (!) rundown of the process.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old March 8, 2009, 01:02   #6
takkaria
Veteran
 
takkaria's Avatar
 
Join Date: Apr 2007
Posts: 1,936
Donated: $40
takkaria is on a distinguished road
Quote:
Originally Posted by Nick View Post
In fact, see here for takkaria's brief (!) rundown of the process.
I'm not sure I could make it any briefer.
__________________
takkaria whispers something about options. -more-
takkaria is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Code: Notes live where? camlost Vanilla 4 February 20, 2009 22:11
New randart code in trunk Magnate Vanilla 1 February 8, 2009 16:17
YACQ: yet another code question will_asher Vanilla 2 January 29, 2009 03:27
Looking through the code K.I.L.E.R Vanilla 5 July 11, 2007 09:01
The safe_setuid code CJNyfalt Vanilla 11 June 26, 2007 04:25


All times are GMT +1. The time now is 03:34.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.