Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Development

Reply
 
Thread Tools Display Modes
Old December 3, 2010, 17:15   #21
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by Nick View Post
In fact, the other people who can push to the official git repository can now update it...
Are you sure you wanted that ...?

But seriously, I think this is a good move. It will make the gradual adoption by V that much easier.
Magnate is offline   Reply With Quote
Old January 15, 2011, 08:46   #22
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 54
Posts: 7,841
Donated: $60
Nick will become famous soon enough
All right.

After several attempts, it has become obvious to me that the business of git updating AngbandBase from the Vanilla master (ie git merge official/master) is always going to leave a whole bunch of conflicts that need manual resolution. I'm sick of doing that, and I don't think it's actually a great idea for any variant maintainer who might actually use AngbandBase.

So the strategy now is
  1. Merge in the latest VERSION changes to AngbandBase (most recently, 3.2.0);
  2. Resolve resulting conflicts;
  3. Wait for the NEXT VERSION.

AngbandBase is thus the low level code of the most recent officially released version. It will only update at version changes of V, which means greater stability for variant maintainers.

Next move is to get FA and O onto AngbandBase (which sounds OK if you say it quickly), and then write a guide to other maintainers for how to use AngbandBase. For the brave, it's ready to go now
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old January 16, 2011, 00:20   #23
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 54
Posts: 7,841
Donated: $60
Nick will become famous soon enough
Quote:
Originally Posted by Nick View Post
For the brave, it's ready to go now
Well, kind of.

Up until now, I've been going on the idea that AngbandBase should be a collection of low-level files on which a variant can be built unchanged. But there are also some files (the things in src/osx, src/win, etc, for example) which can be imported almost unchanged.

Question is, should these ones be left out completely and referred to in the maintainer's guide, or included in some form with some sort of instructions on how to modify them? I can't see an obviously better choice, and would be delighted to hear opinions.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old January 16, 2011, 02:02   #24
Sirridan
Knight
 
Sirridan's Avatar
 
Join Date: May 2009
Posts: 560
Sirridan is on a distinguished road
Quote:
Originally Posted by Nick View Post
Question is, should these ones be left out completely and referred to in the maintainer's guide, or included in some form with some sort of instructions on how to modify them? I can't see an obviously better choice, and would be delighted to hear opinions.
Definitely they need referring at least, and I'd say include some for example's sake. Maybe get someone to write a script of some kind which can help automatically generate these types of files? I mean for the .rc files for windows, that should be pretty easy.
Sirridan is offline   Reply With Quote
Old January 16, 2011, 09:28   #25
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by Sirridan View Post
Definitely they need referring at least, and I'd say include some for example's sake. Maybe get someone to write a script of some kind which can help automatically generate these types of files? I mean for the .rc files for windows, that should be pretty easy.
I think the platform-specific stuff should be included, because takk's intention is to separate it from the game code eventually, which should make it easier to incorporate unchanged over time.
Magnate is offline   Reply With Quote
Old January 18, 2011, 17:08   #26
EpicMan
Swordsman
 
Join Date: Dec 2009
Location: Dallas, Texas, USA
Posts: 356
EpicMan is on a distinguished road
It sounds like AngbandBase and Angband 4.0 are heading in parallel directions. Not to tell you what to do, which is to say that I am :-), but wouldn't your efforts be more productively spent working with Takk on the Angband 4 code, then altering FA/O to work with the new code base?

Maybe there are reasons not to do that (if only that y'all's timelines are very different) but it looks to me like you are going to a lot of work and then will have to do a whole lot more work when Tak's new architecture comes about.

Anyway, don't feel the need to explain or defend your approach, I just wanted to offer food for thought.
EpicMan is offline   Reply With Quote
Old May 31, 2011, 14:10   #27
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 54
Posts: 7,841
Donated: $60
Nick will become famous soon enough
There is now a guide to the Angband source code for variant maintainers (and anyone else who's interested) on the trac wiki.

Comments welcome.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old June 13, 2011, 23:05   #28
CJNyfalt
Swordsman
 
Join Date: May 2007
Posts: 289
CJNyfalt is on a distinguished road
I have always wanted to see something like this done, and have in the past made a couple of failed tries, so I am excited that someone else has picked up the torch.

I hope some day this will become a real C library used by vanilla and several variants.
CJNyfalt is offline   Reply With Quote
Old June 14, 2011, 01:18   #29
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 54
Posts: 7,841
Donated: $60
Nick will become famous soon enough
Quote:
Originally Posted by CJNyfalt View Post
I have always wanted to see something like this done, and have in the past made a couple of failed tries, so I am excited that someone else has picked up the torch.
Your anglib was one of the things that inspired me to try and do this.

Quote:
I hope some day this will become a real C library used by vanilla and several variants.
Yeah, eventually. Even the low level code for V is changing really fast at the moment (UTF-8 support is currently on the way in, for example), and according to takkaria everything will break before too long anyway, so this is really in a holding pattern for now. Still, I don't think any variant maintainer updating to the current V code will be wasting their time (or no more than usual, anyway ).
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old June 18, 2013, 10:20   #30
Zireael
Adept
 
Join Date: Jul 2011
Posts: 204
Zireael is on a distinguished road
Does AngbandBase still exist or is it my browser which throws an error (I've noticed it doesn't agree with git)?
Zireael is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 08:30.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.