Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Development

Reply
 
Thread Tools Display Modes
Old June 17, 2011, 18:57   #1
Raggy
Apprentice
 
Join Date: May 2011
Posts: 85
Raggy is on a distinguished road
Quality squelching

...are not being saved.

Or im missing something?

Go to squelch->then go to quality->set pointy to "good"->go to main menu->save options->save and exit game
Reload game->squelch settings->quality: everything is back to nothing.
Raggy is offline   Reply With Quote
Old June 17, 2011, 19:35   #2
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by Raggy View Post
...are not being saved.

Or im missing something?

Go to squelch->then go to quality->set pointy to "good"->go to main menu->save options->save and exit game
Reload game->squelch settings->quality: everything is back to nothing.
You're playing on Windows, I presume. This is a well-known and little-understood Windows bug, ticket #1318. If you can work out under exactly what conditions it occurs, we'd be very grateful. It doesn't reproduce for all Windows players under all conditions, and it doesn't occur for non-Windows platforms. I think.
Magnate is offline   Reply With Quote
Old June 18, 2011, 03:20   #3
Jazerus
Apprentice
 
Join Date: Jun 2011
Posts: 74
Jazerus is on a distinguished road
Quality squelch is saved for me on Windows, but I also have Angband installed outside of Program Files. Preference save settings in general on Windows may be related to UAC if it turns out those who have the issue have Angband installed in UAC-controlled directories.

The correct behavior persists for me across all builds, official and nightly.
Jazerus is offline   Reply With Quote
Old June 18, 2011, 07:11   #4
Timo Pietilš
Prophet
 
Join Date: Apr 2007
Location: Climbing up from hole I just dug.
Posts: 4,096
Timo Pietilš is on a distinguished road
Quote:
Originally Posted by Jazerus View Post
Quality squelch is saved for me on Windows, but I also have Angband installed outside of Program Files. Preference save settings in general on Windows may be related to UAC if it turns out those who have the issue have Angband installed in UAC-controlled directories.

The correct behavior persists for me across all builds, official and nightly.
Not the UAC case, I use XP and play outside of Program Files, still doesn't save the settings.

I'm surprised to hear that this is Windows-problem. Maybe some of you should really use Windows to code, it is still huge majority of desktop computers (something like 90% of computer I think). I have two totally different XP machines, only similar thing is that they both are XPSP3 and both have ATI display cards (but different models).

Exact situation where saving doesn't happen is "I exit the game, then reload". I can tweak everything and it doesn't save the settings.

Anyway this has to have something to do with settings saved in save file, those settings are not saved anywhere else (not even if I save all my options in pref-file, they are not there). If there can be this kind of error now who knows what else don't get saved later. Monster inventories? Your gear?

Error has occurred between rd39a356436 and next nightly there was available in rephial. Something in there changed that behavior. Track that down, and you get the reason why it doesn't work anymore.
Timo Pietilš is offline   Reply With Quote
Old June 18, 2011, 20:07   #5
Max Stats
Swordsman
 
Join Date: Jun 2010
Posts: 324
Max Stats is on a distinguished road
Quote:
Originally Posted by Jazerus View Post
Quality squelch is saved for me on Windows, but I also have Angband installed outside of Program Files. Preference save settings in general on Windows may be related to UAC if it turns out those who have the issue have Angband installed in UAC-controlled directories.
I had thought of this when I saw the issue, but AFAIK (unless something has changed) squelch settings are saved in the character file, so if it were a UAC issue, it wouldn't be possible to save games at all.

Anyway, the whole thing makes me glad I boot to Linux to play Angband.
Max Stats is offline   Reply With Quote
Old June 19, 2011, 14:26   #6
Raggy
Apprentice
 
Join Date: May 2011
Posts: 85
Raggy is on a distinguished road
Quote:
Originally Posted by Magnate View Post
You're playing on Windows, I presume. This is a well-known and little-understood Windows bug, ticket #1318. If you can work out under exactly what conditions it occurs, we'd be very grateful. It doesn't reproduce for all Windows players under all conditions, and it doesn't occur for non-Windows platforms. I think.
Well it reproduces for me each time I play, I do nothing special, except modifying the quality squelching, saving options, then eventually exiting the game. Next time I play, settings are gone.
Raggy is offline   Reply With Quote
Old June 19, 2011, 17:27   #7
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by Raggy View Post
Well it reproduces for me each time I play, I do nothing special, except modifying the quality squelching, saving options, then eventually exiting the game. Next time I play, settings are gone.
Yes. So we need to know what is different about your system from people playing under Windows who don't have this problem - their settings save and reload fine.

Do you have a pref file somewhere with squelch settings in it? It's possible that your changed settings *are* getting saved and reloaded properly, but then a pref file is being loaded *after* that ...
__________________
"3.4 is much better than 3.1, 3.2 or 3.3. It still is easier than 3.0.9, but it is more convenient to play without being ridiculously easy, so it is my new favorite of the versions." - Timo Pietila
Magnate is offline   Reply With Quote
Old June 19, 2011, 19:54   #8
Timo Pietilš
Prophet
 
Join Date: Apr 2007
Location: Climbing up from hole I just dug.
Posts: 4,096
Timo Pietilš is on a distinguished road
Quote:
Originally Posted by Magnate View Post
Yes. So we need to know what is different about your system from people playing under Windows who don't have this problem - their settings save and reload fine.

Do you have a pref file somewhere with squelch settings in it? It's possible that your changed settings *are* getting saved and reloaded properly, but then a pref file is being loaded *after* that ...
In my case this is definitely not the case. I do have a pref-file which contains class-specific keymaps, and I have changed font-win.prf, but either of those should not affect quality squelch saving.

Quality squelch settings cannot not be saved in pref-file even if you try, I tested that. I made "save options" and that didn't include quality squelch settings. There is no way you can save them in pref-file in current UI.

This started to appear between rd39a356436 and next nightly edition available to download. What changed there? Couldn't you just reverse whatever changed there that has something to do with squelch?
Timo Pietilš is offline   Reply With Quote
Old June 19, 2011, 21:26   #9
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by Timo Pietilš View Post
Quality squelch settings cannot not be saved in pref-file even if you try, I tested that. I made "save options" and that didn't include quality squelch settings. There is no way you can save them in pref-file in current UI.
Not any more they can't, no - but they used to, and people may have old pref files lying around.
Quote:
This started to appear between rd39a356436 and next nightly edition available to download. What changed there? Couldn't you just reverse whatever changed there that has something to do with squelch?
Possibly. I haven't looked yet, but I have a feeling it's not an easy problem to spot.
__________________
"3.4 is much better than 3.1, 3.2 or 3.3. It still is easier than 3.0.9, but it is more convenient to play without being ridiculously easy, so it is my new favorite of the versions." - Timo Pietila
Magnate is offline   Reply With Quote
Old June 19, 2011, 21:59   #10
Timo Pietilš
Prophet
 
Join Date: Apr 2007
Location: Climbing up from hole I just dug.
Posts: 4,096
Timo Pietilš is on a distinguished road
Quote:
Originally Posted by Magnate View Post
Not any more they can't, no - but they used to, and people may have old pref files lying around.
When I "upgrade" I just copy apex, user prefs (class-specific macros/keymaps), font-win.prf, angband.ini and savefiles to new game directory. I have all the old ones still here from who knows how far back (many of them have my own tweaks in edit-files, so not clean savegames).

Anyway, I have never saved squelch-settings, so that can't be the reason for that bug.

Maybe this is compiler error. Have you tried cycgwin gcc for windows-builds? It has been rock-solid platform for my compiling for ages. It seems that there is now couple of .dll:s in root of the game directory that were not there before (rd39a356436 doesn't have those). What is the purpose of those?
Timo Pietilš is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Verbose quality squelching msgs awldune Vanilla 0 February 17, 2010 17:18
Squelching vstat Vanilla 20 August 4, 2009 02:59
3.1 Bug in squelch by quality menu Skelwing Vanilla 1 April 11, 2009 20:20
3.1 bug: ego armor squelch quality ChodTheWacko Vanilla 1 April 11, 2009 20:19
Squelching DSM Colbey Vanilla 8 March 15, 2008 20:48


All times are GMT +1. The time now is 19:15.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.