Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Development

Reply
 
Thread Tools Display Modes
Old March 20, 2016, 03:57   #1
calris
Adept
 
Join Date: Mar 2016
Posts: 194
calris is on a distinguished road
How do we submit code changes

The map not refreshing when running caused a map panel change was bugging me, so I added a force redraw in the disturb() function if the player was running - works a treat.

Where do I submit the patch for review?
calris is offline   Reply With Quote
Old March 20, 2016, 04:21   #2
Derakon
Prophet
 
Derakon's Avatar
 
Join Date: Dec 2009
Posts: 8,918
Derakon is on a distinguished road
Quote:
Originally Posted by calris View Post
The map not refreshing when running caused a map panel change was bugging me, so I added a force redraw in the disturb() function if the player was running - works a treat.

Where do I submit the patch for review?
In an ideal world, you'd have a GitHub repository forked from the main repository, you'd push your change to your repository, and then you'd submit a pull request to the main repository (there'd be a big green button on your repository saying "Submit pull request").

If that all sounds like Greek, then just post the patch here, and I'm sure Nick will see it at some point.
Derakon is offline   Reply With Quote
Old March 20, 2016, 04:26   #3
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 54
Posts: 7,841
Donated: $60
Nick will become famous soon enough
Ideally,
  1. Set yourself up an account on github;
  2. Clone the main Angband repository;
  3. Make changes in a local branch and push them back to github;
  4. Submit a pull request (if you look at your changes on github, you should be prompted to do that).

Failing that, posting the patch (or a link to it) here should be fine.

EDIT: I seem to be a clone of Derakon
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.

Last edited by Nick; March 20, 2016 at 04:34. Reason: Freaked out
Nick is offline   Reply With Quote
Old March 20, 2016, 05:45   #4
calris
Adept
 
Join Date: Mar 2016
Posts: 194
calris is on a distinguished road
Done and done
calris is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
So you want to contribute but can't code? Magnate Development 57 January 29, 2019 21:26
is there a code? jozmon Development 19 August 4, 2014 01:38
State of code ewert Development 2 August 4, 2010 16:08
code help please will_asher Variants 22 March 15, 2010 20:00
Looking through the code K.I.L.E.R Vanilla 5 July 11, 2007 09:01


All times are GMT +1. The time now is 06:38.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.