Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old February 13, 2009, 02:13   #1
Colbey
Apprentice
 
Join Date: Feb 2008
Posts: 51
Colbey is on a distinguished road
r1264 bug: crash at prompt (Windows)

In playing r1264 in Windows (from the nightly build), I destroyed 2 of a stack of 4 books in my inventory, and then pressed Enter to "Ignore this book in the future? [y/n]" The game immediately crashed at that point.

Pressing "n" crashes it as well.
Colbey is offline   Reply With Quote
Old February 13, 2009, 02:31   #2
CunningGabe
Swordsman
 
Join Date: Feb 2008
Location: Boston, MA
Posts: 250
CunningGabe is on a distinguished road
Could you post a savefile? I'm having trouble reproducing this bug on my own.
CunningGabe is offline   Reply With Quote
Old February 13, 2009, 02:44   #3
Colbey
Apprentice
 
Join Date: Feb 2008
Posts: 51
Colbey is on a distinguished road
Sure. (Attached file is a raw savefile, not a zip file. I added the extension to the filename to get around the forum upload restrictions.)
Attached Files
File Type: zip Jimmy_I.zip (55.4 KB, 184 views)
Colbey is offline   Reply With Quote
Old February 13, 2009, 02:55   #4
CunningGabe
Swordsman
 
Join Date: Feb 2008
Location: Boston, MA
Posts: 250
CunningGabe is on a distinguished road
It seems to work okay for me -- does it crash for any book? Which one in particular did you destroy?
CunningGabe is offline   Reply With Quote
Old February 13, 2009, 03:03   #5
Colbey
Apprentice
 
Join Date: Feb 2008
Posts: 51
Colbey is on a distinguished road
One of the 3 Chants and Blessings.
Colbey is offline   Reply With Quote
Old February 13, 2009, 03:11   #6
CunningGabe
Swordsman
 
Join Date: Feb 2008
Location: Boston, MA
Posts: 250
CunningGabe is on a distinguished road
Still working fine for me. How did the game crash -- did it hang? Suddenly exit with no warning? Exit with a warning?

Do you not get the crash with other prayer books?
CunningGabe is offline   Reply With Quote
Old February 13, 2009, 03:21   #7
Colbey
Apprentice
 
Join Date: Feb 2008
Posts: 51
Colbey is on a distinguished road
Windows told me that angband.exe encountered a problem and needs to close. It has this "Error signature":

AppName: angband.exe AppVer: 0.0.0.0 ModName: angband.exe
ModVer: 0.0.0.0 Offset: 00045f4a

I can also view a large hexdump through the Windows error screens, but I can't seem to save or copy the dump. (Not shocked at that level of uselessness coming from Windows...)

It also crashed on the Words Of Wisdom (tried destroying all this time, on the theory that the issue triggers when destroying some but not all of a stack), but not when destroying my only Potion of Speed. (I don't remember how many !speeds are in the dump above, but I've been playing since and only had 1 left.)
Colbey is offline   Reply With Quote
Old February 13, 2009, 03:33   #8
CunningGabe
Swordsman
 
Join Date: Feb 2008
Location: Boston, MA
Posts: 250
CunningGabe is on a distinguished road
Hmm. There was another person who was having book-squelch troubles as well, but as far as I know, nothing else has had a problem. Which version of Windows are you running? (I'm guessing Vista?)

I have a hunch what may be causing this -- there's an sval name buffer used to build the prompt, and the book svals names are far longer than anything else. I think they're causing a buffer overflow somewhere. I've just committed a change in r1265 to enlarge the buffer; if this fixes the crashes, then I'll look into it a little more and make a less hackish fix.

(It sounds like you're not building from source, so you'll just have to wait a little for the next build.) Let me know if it's any better.
CunningGabe is offline   Reply With Quote
Old February 13, 2009, 03:39   #9
Colbey
Apprentice
 
Join Date: Feb 2008
Posts: 51
Colbey is on a distinguished road
Not Vista; XP SP3.

Thanks for checking in a fix! You're right that I'm not building from source, and I often don't get a chance to play over the weekend, but I'll try to verify the fix next week. (Other people, obviously, feel free to download the savefile if you want to look at this bug.)
Colbey is offline   Reply With Quote
Old February 13, 2009, 09:54   #10
bebo
Adept
 
bebo's Avatar
 
Join Date: Jan 2009
Location: Milan, Italy
Posts: 213
bebo is on a distinguished road
see http://angband.oook.cz/forum/showthread.php?t=1477 also
bebo is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
3.1.1 strange crash bebo Vanilla 1 February 8, 2009 23:49
Entro crash Zikke Variants 2 February 2, 2009 20:08
Shopping crash FA, O maybe others buzzkill Variants 5 November 17, 2008 23:45
Stupide 'MORE' prompt!!!! Poop Loops Vanilla 5 May 21, 2008 00:56
Crash - angband: Too many macros! Kav Vanilla 16 June 15, 2007 14:38


All times are GMT +1. The time now is 13:53.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2020, vBulletin Solutions Inc.