Search beyond lit area?

kaypy · June 12, 2012, 13:24

I keep on getting "you have found a [trap|secret door]" when I haven't actually gotten close enough to see what I have found.

This seems a touch odd.

The relevent code seems to be around 93 in cmd1.c/search()

The los routine used here only checks for obstacles and not light.

Would player_can_see_bold be a better choice here?

Magnate · June 12, 2012, 14:00

Good catch. I'm not sure if Gabe intended trap detection to be a 'sixth sense' which didn't rely on visibility. So this might be WAD. I'll point him at this thread next time he's around, if he doesn't find it first.

June 12, 2012, 13:24	#1
kaypy Swordsman Join Date: May 2009 Posts: 294	Search beyond lit area? I keep on getting "you have found a [trap\|secret door]" when I haven't actually gotten close enough to see what I have found. This seems a touch odd. The relevent code seems to be around 93 in cmd1.c/search() The los routine used here only checks for obstacles and not light. Would player_can_see_bold be a better choice here?

June 12, 2012, 14:00	#2
Magnate Angband Devteam member Join Date: May 2007 Location: London, UK Posts: 5,060	Good catch. I'm not sure if Gabe intended trap detection to be a 'sixth sense' which didn't rely on visibility. So this might be WAD. I'll point him at this thread next time he's around, if he doesn't find it first. __________________ "3.4 is much better than 3.1, 3.2 or 3.3. It still is easier than 3.0.9, but it is more convenient to play without being ridiculously easy, so it is my new favorite of the versions." - Timo Pietila

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
feature request - no disturb on 100% search	PowerDiver	Vanilla	11	June 14, 2010 22:07
3.1.0 beta - minor bug? - green lit floor tiles in prelit rooms	vorondil	Vanilla	2	January 8, 2009 18:12
No more Search tab?	awldune	Oook!	12	December 12, 2008 01:10
Area of Effect	kandrc	Vanilla	16	January 19, 2008 12:27
Oldtimer online? Search patch from 1999	TJA	Vanilla	2	August 20, 2007 09:59

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)