Go Back   Angband Forums > Angband > Vanilla

Thread Tools Display Modes
Old June 28, 2012, 17:36   #1
PowerWyrm's Avatar
Join Date: Apr 2008
Posts: 2,954
PowerWyrm is on a distinguished road
[3.4RC] There may not be much interesting here...

Level was generated with a D pit and a GCV, I was expecting "superb treasures"...

In fact, this is easily explained. Excerpt from the code:

if (rating > 250000) rating = 250000;

        c->obj_rating += (rating / 10) * (rating / 10);
obj_rating is coded on an unsigned integer, which maxes at roughly 4e+9. Any WoG, Kelek or high DSM will easily get a max rating of 250k when generated out of depth in a GCV, which boosts the object rating by 625mil. And a GCV easily has more than 7-8 of those, boosting object rating over the MAXINT limit.

Using a percent of the rating would probably fix the problem:

c->obj_rating += (rating / 100) * (rating / 100);
This means losing a bit of accuracy with low ratings, but I don't think it matters much what type of "cobwebs" you get on a junk level
PWMAngband variant maintainer - check (or to learn more about this new variant!
PowerWyrm is offline   Reply With Quote
Old June 28, 2012, 17:41   #2
Derakon's Avatar
Join Date: Dec 2009
Posts: 9,022
Derakon is on a distinguished road
There are cobwebs of shining mithril here!

Seriously though, good catch. It's amazing how many rollover bugs we've had to deal with lately; are we just trying for too much resolution or something?
Derakon is offline   Reply With Quote
Old June 28, 2012, 19:05   #3
Join Date: May 2012
Location: Adelaide, Australia
Posts: 2,601
wobbly will become famous soon enough
Just watch out for that mithril spider....

I'm currently searching any level with more then scraps of junks. 2 egos, an artifact, a ring of free action & gloves of slaying was merely "worthwhile" on dlevel 13.
wobbly is offline   Reply With Quote

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Interesting scroll names. Whelk Vanilla 11 December 1, 2017 01:08
[3.4RC - Win32 client]Graphic glitch for Tile Multipliers Smiling Spectre Vanilla 1 June 22, 2012 13:33
[3.4RC - Win32 client]No stacking piles anymore? Smiling Spectre Vanilla 2 June 22, 2012 13:07
[3.4RC - Win32 client] Map not displayed properly when number of columns is too high PowerWyrm Vanilla 0 June 20, 2012 11:59
[3.4RC - Win32 client] Minimap with tiles PowerWyrm Vanilla 3 June 20, 2012 09:32

All times are GMT +1. The time now is 21:12.

Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2023, vBulletin Solutions Inc.