Bugs in 4.2.0

[Nick]

Originally Posted by scrarth

I've attached a savefile for convenience, both bugs are reproducible in it. I'd really appreciate it if the savefile could be fixed, hopefully the bugs aren't too hard to track down.

OK, fixed savefile attached. The saved town was the problem, so when you go back there you will find the layout different; the shop and your home should be unaffected. Let me know if you have any further problems.

[DavidMedley]

Originally Posted by Derakon

Adamantite, and mithril, are both corrosion-proof. That holds for armor made of the metal just as much as it does for monsters made of it.

Makes sense

[DavidMedley]

When I'm hallucinating, if I do things like hit space, escape, browse a book, etc., no time passes but my hallucinations flicker. Shouldn't they only change when time passes? Pretty easy to determine whether something is actually there or not this way.

[scrarth]

Originally Posted by Nick

OK, fixed savefile attached. The saved town was the problem, so when you go back there you will find the layout different; the shop and your home should be unaffected. Let me know if you have any further problems.

No luck on my end unfortunately, I still get the chunk_copy() level bounds failed error message.

[DavidMedley]

Originally Posted by Derakon

Adamantite, and mithril, are both corrosion-proof. That holds for armor made of the metal just as much as it does for monsters made of it.

Mithril Golem does not resist acid, however.

[Derakon]

Originally Posted by DavidMedley

Mithril Golem does not resist acid, however.

Good news! We're in the 4.2.0 bugs thread, so hopefully Nick will see this.

(They may have been made vulnerable so that mages would have some way to fight them...)

[Nick]

Originally Posted by scrarth

No luck on my end unfortunately, I still get the chunk_copy() level bounds failed error message.

Sorry, I attached the wrong one

This one should be OK - I recalled back to town from your save.

[scrarth]

Originally Posted by Nick

Sorry, I attached the wrong one

This one should be OK - I recalled back to town from your save.

Yep, it's working fine now. Thanks a bunch for that!

[backwardsEric]

Other memory leaks reported by XCode's Leaks instrument for Angband 4.2.0:

1) Some "known" versions of objects allocated from the following partial call stacks below (omitting the calls before process_command()) were leaked.

mem_alloc()
mem_zalloc()
object_new()
object_split()
gear_object_for_use()
ranged_helper()
do_cmd_fire()
process_cmd()

mem_alloc()
mem_zalloc()
object_new()
object_see()
square_know_pile()
square_note_spot()
update_one()
update_view()
move_player()
do_cmd_walk()
process_command()

mem_alloc()
mem_zalloc()
object_new()
object_sense()
square_sense_pile()
effect_handler_SENSE_OBJECTS()
effect_do()
use_aux()
do_cmd_read_scroll()
process_command()

The attached file, object-absorb-known-object-leak-patch.txt, patches object_absorb(), but that doesn't eliminate all of those leaks.

2) An object allocated from this partial call stack,

mem_alloc()
mem_zalloc()
object_new()
make_object()
place_object()
alloc_object()
alloc_objects()
classic_gen()
cave_generate()
prepare_next_level()

, was leaked.

3) The string allocated from this partial call stack,

mem_alloc()
string_make()
cmd_set_arg_string()
cmd_get_string()
do_cmd_inscribe()
process_command()

was leaked when inscribing an object.

4) During character creation, there's a leak if the player edits the character background information. The partial call stack for where the allocations occur is

mem_realloc()
textblock_calculate_lines()
edit_text()
textui_do_birth()
play_game()

5) During character creation, the background or quest information can be leaked, especially if the player backtracks to select a different combination of race and class. The partial call stacks for where the allocations occurred were:

string_append()
player_generate()
do_cmd_choose_race()
process_command()

string_append()
player_generate()
do_cmd_choose_class()
process_command()

string_append()
player_generate()
do_cmd_birth_reset()
process_command()

string_append()
do_cmd_roll_stats()
process_command()

string_make()
do_cmd_choose_history()
process_command()

string_append()
player_generate()
do_cmd_birth_init()
process_command()

mem_zalloc()
player_quests_reset()
player_init()
do_cmd_birth_reset()
process_command()

string_make()
player_quests_reset()
player_init()
do_cmd_birth_reset()
process_command()

The attached file, player-birth-memory-leaks-patch.txt, has patches to plug those leaks and the leak in (4).

[backwardsEric]

In ui-prefs.c's remove_old_dump(), if there is an error opening the new file, the current file won't be closed. The attached patch fixes that.