3.3.2 fails to mark saves as dead when it ought to

Therem Harth · May 3, 2012, 06:27

My latest hobbit mage just got cursed to death by an Acolyte. See death screen -> look at some useless stats, close window -> start Angband again -> I'm back with my hobbit before he died. Accidental savescumming, not good.

IMO Angband should, if possible, mark the save file *on character death*, rather than on hitting the "Quit" entry after death, which seems to be what's happening now. The way things are, if you close the window without hitting "Quit," your save file is not marked as dead.

Edit: oh cool, 3.3.2 consolidates death stuff in death.c. Looking at the code, the problem appears to be that the function to save the game is the last one invoked. It should probably be invoked before the death screen is displayed, somewhere near the beginning of the file. I think.

Derakon · May 3, 2012, 07:21

Mm, I have once or twice in the past been killed by a miskey, and in those events I appreciated being able to quit at the "You die." message and not lose my character. Anyone who's going to savescum can do so even if the savefile gets marked right off (they just have to make backups via the filesystem), so I don't really see that much value in making it harder.

Magnate · May 3, 2012, 10:56

This is WAD. The save is written after the death menu because you can change the keep_randarts option after death. I guess we could write it out both before and after, but that seems excessive.

buzzkill · May 3, 2012, 14:14

IMO being able to quit after death and "save" your character in process in very un-angbandish. Angband shouldn't facilitate save scumming.

Nick · May 3, 2012, 14:36

Quote:

Originally Posted by buzzkill

IMO being able to quit after death and "save" your character in process in very un-angbandish. Angband shouldn't facilitate save scumming.

Agreed. Anyone can choose to savescum, but it should be a conscious circumvention of the intended behaviour. Writing it out before and after isn't too excessive

fizzix · May 3, 2012, 14:48

On windows I get a save on window close, so I can't reproduce this effect. What OS Therem?

Therem Harth · May 3, 2012, 16:25

Linux, using the SDL interface.

Rei Tei · May 4, 2012, 23:27

I didn't even know you could save a character...the only instances where I have been able to reopen a character to before death were of Angband's own doing. I would be just about to die and the Angband window would close and I'd get the error report message. When I reopen my character, I begin the whole level again. It was nice...now at least I have an explanation of how it could have happened.

May 3, 2012, 06:27	#1
Therem Harth Knight Join Date: Jan 2008 Posts: 926	3.3.2 fails to mark saves as dead when it ought to My latest hobbit mage just got cursed to death by an Acolyte. See death screen -> look at some useless stats, close window -> start Angband again -> I'm back with my hobbit before he died. Accidental savescumming, not good. IMO Angband should, if possible, mark the save file on character death, rather than on hitting the "Quit" entry after death, which seems to be what's happening now. The way things are, if you close the window without hitting "Quit," your save file is not marked as dead. Edit: oh cool, 3.3.2 consolidates death stuff in death.c. Looking at the code, the problem appears to be that the function to save the game is the last one invoked. It should probably be invoked before the death screen is displayed, somewhere near the beginning of the file. I think. Last edited by Therem Harth; May 3, 2012 at 06:47.

May 3, 2012, 10:56	#3
Magnate Angband Devteam member Join Date: May 2007 Location: London, UK Posts: 5,057	This is WAD. The save is written after the death menu because you can change the keep_randarts option after death. I guess we could write it out both before and after, but that seems excessive. __________________ "3.4 is much better than 3.1, 3.2 or 3.3. It still is easier than 3.0.9, but it is more convenient to play without being ridiculously easy, so it is my new favorite of the versions." - Timo Pietila

May 3, 2012, 14:14	#4
buzzkill Prophet Join Date: May 2008 Location: Indiana, USA Posts: 2,939 Donated: $8	IMO being able to quit after death and "save" your character in process in very un-angbandish. Angband shouldn't facilitate save scumming. __________________ www.mediafire.com/buzzkill - Get your 32x32 tiles here. UT32 now compatible Ironband and Quickband 9/6/2012. My banding life on Buzzkill's ladder.

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
breaking stable vanilla's saves	dionysian	v4	15	March 1, 2012 22:52
[3.3.2] Compiling fails under Ubuntu 11.10	raycluster	Vanilla	18	February 13, 2012 11:13
T-Engine4 / ToME4 beta36 aka "Saving saves" unleashed	DarkGod	ToME	0	December 7, 2011 12:56
Saves and Resists questions	tprice	Vanilla	16	February 19, 2011 15:57
Mark everything read?	Timo Pietilä	Oook!	5	November 30, 2009 16:05

May 3, 2012, 07:21	#2
Derakon Prophet Join Date: Dec 2009 Posts: 9,024	Mm, I have once or twice in the past been killed by a miskey, and in those events I appreciated being able to quit at the "You die." message and not lose my character. Anyone who's going to savescum can do so even if the savefile gets marked right off (they just have to make backups via the filesystem), so I don't really see that much value in making it harder.

May 3, 2012, 14:48	#6
fizzix Prophet Join Date: Aug 2009 Location: Madison, Wisconsin, US Posts: 3,023	On windows I get a save on window close, so I can't reproduce this effect. What OS Therem?

May 3, 2012, 16:25	#7
Therem Harth Knight Join Date: Jan 2008 Posts: 926	Linux, using the SDL interface.

May 4, 2012, 23:27	#8
Rei Tei Rookie Join Date: Jul 2011 Location: US-West Coast Posts: 2	I didn't even know you could save a character...the only instances where I have been able to reopen a character to before death were of Angband's own doing. I would be just about to die and the Angband window would close and I'd get the error report message. When I reopen my character, I begin the whole level again. It was nice...now at least I have an explanation of how it could have happened.

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)