Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Variants

Reply
 
Thread Tools Display Modes
Old October 13, 2017, 21:45   #71
Breaker_Asylum
Rookie
 
Join Date: Sep 2017
Posts: 8
Breaker_Asylum is on a distinguished road
Quote:
Originally Posted by DGoldDragon28 View Post
I am glad you like it. Unfortunately since classes started up in September I have had little time to work on it, but I hope to have a new release out by new years. As always, if you have an idea or skills with the C language, feel free to stop by the Git repository and fork the repo or create an issue.
... You plan on making this "better" M8... lemme tell ya straight... This variant is the best I've played, Just how it is today. So if ya do make it betta, add a little more flava, With minor school starting spellbooks/ info on how to get them... aka animal, demonolgy, Those nice unique ones.
Breaker_Asylum is offline   Reply With Quote
Old December 22, 2017, 00:51   #72
droof
Apprentice
 
Join Date: Dec 2013
Posts: 71
droof is on a distinguished road
I only recently found Unangband. I love exploration and these dungeons make me want to keep on exploring. Even if I have to debug with ddd for my unarmed melee warrior, still worth it. Very well done, thank you for this great variant!
droof is offline   Reply With Quote
Old December 22, 2017, 05:48   #73
DGoldDragon28
Rookie
 
Join Date: Nov 2013
Location: Baltimore, MD
Posts: 18
DGoldDragon28 is on a distinguished road
What exactly is the bug you are encountering with the unarmed warrior?
__________________
-the pseudonymous Gold Dragon,
Maintainer of Unangband
DGoldDragon28 is offline   Reply With Quote
Old December 22, 2017, 22:32   #74
droof
Apprentice
 
Join Date: Dec 2013
Posts: 71
droof is on a distinguished road
I sent you a pull request with a fix, description and test case for melee.
droof is offline   Reply With Quote
Old December 23, 2017, 06:03   #75
DGoldDragon28
Rookie
 
Join Date: Nov 2013
Location: Baltimore, MD
Posts: 18
DGoldDragon28 is on a distinguished road
Excellent, thank you. I will look it over tomorrow. I am excited at getting to read my first pull request for this game!
__________________
-the pseudonymous Gold Dragon,
Maintainer of Unangband
DGoldDragon28 is offline   Reply With Quote
Old December 23, 2017, 21:29   #76
droof
Apprentice
 
Join Date: Dec 2013
Posts: 71
droof is on a distinguished road
Awesome! I'm just having fun with the code. I expect most requests to be rejected, that's fine. Maybe you'll like one of the ideas.

Why is the gray 'x' used for unexplored space in Unangband? Does it have strategic value or is it a style preference?

The segfault is still present in master. My fix definitely prevents the crash, but it's not the root. The pointer magic goes over my head. Maybe you can find the root of the problem? Here's my gdb trace to the crash: https://pastebin.com/vZLdFuuH
droof is offline   Reply With Quote
Old December 23, 2017, 22:04   #77
DGoldDragon28
Rookie
 
Join Date: Nov 2013
Location: Baltimore, MD
Posts: 18
DGoldDragon28 is on a distinguished road
As a matter of fact, most (2 of 3) of your requests, I accepted.

The purpose of the grey 'x' is unknown to me. It was there when I first picked up the code. As I said in the PR comment, I'll look into adding an option for that.

As for the segfault: Many thanks for the stack-trace, which makes it quite clear what the issue is, and it makes perfect sense that your fix fixed it, as it comes from that precise hack.

The sizes of different types in C are system-dependent. An `int` is generally 4 bytes, which it is on your system. On a 32-bit system, therefore, it is almost always possible to convert a pointer (also being 4 bytes) to an `int` and back without loss of information. However, you are using a 64-bit system, so your pointers are 8 bytes. Thus, when the pointer is cast to an `int` to be passed through the hack, it is truncated, and when converted back, points to memory which the program does not have access to.

I will issue a fix for this as soon as possible. Keep those issues and PRs coming.
__________________
-the pseudonymous Gold Dragon,
Maintainer of Unangband
DGoldDragon28 is offline   Reply With Quote
Old December 23, 2017, 22:30   #78
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 53
Posts: 7,222
Donated: $60
Nick is on a distinguished road
Quote:
Originally Posted by droof View Post
Why is the gray 'x' used for unexplored space in Unangband? Does it have strategic value or is it a style preference?
IIRC it disappears in areas where you have detected traps.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old December 23, 2017, 22:39   #79
droof
Apprentice
 
Join Date: Dec 2013
Posts: 71
droof is on a distinguished road
Thank you so much! Just checking about the 'x'. If removing it puts me at a strategic disadvantage in the game, I will definitely want the 'x' back

Also thank you for the bug explanation, that makes sense now. Also I should just give you the trace next time if I start guessing in code. This would've taken a long time for me to figure out.

edit: if 'x's are supposed to disappear for detected traps, maybe I can reverse it for a less crowded appearance. Explored wilderness and 'x's kind of blend together to my eyes.

Last edited by droof; December 23, 2017 at 22:48.
droof is offline   Reply With Quote
Old January 1, 2018, 04:47   #80
AppleBrandy
Rookie
 
Join Date: Jan 2018
Posts: 3
AppleBrandy is on a distinguished road
I'm attempting to compile the current master branch for Windows via cygwin, and I'm getting an odd problem - it compiled (with a bunch of warnings, but no showstoppers), the exe is in the main directory, but running it just very quickly opens then closes a window, with no error messages. Is this something you ran into? I'm at a loss, honestly.
AppleBrandy is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Unangband is livening up again! getter77 Variants 7 November 7, 2014 06:30
New to Unangband Deranged Archivist Variants 27 October 28, 2010 08:17
Unangband help Lankiel Variants 4 February 21, 2010 19:53
Unangband svn? Magnate Variants 2 July 13, 2009 08:35
UnAngband! Bandobras Variants 17 May 28, 2007 20:32


All times are GMT +1. The time now is 19:10.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2018, vBulletin Solutions Inc.