Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old November 9, 2019, 11:52   #81
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 54
Posts: 7,860
Donated: $60
Nick will become famous soon enough
Quote:
Originally Posted by scrarth View Post
I've attached a savefile for convenience, both bugs are reproducible in it. I'd really appreciate it if the savefile could be fixed, hopefully the bugs aren't too hard to track down.
OK, fixed savefile attached. The saved town was the problem, so when you go back there you will find the layout different; the shop and your home should be unaffected. Let me know if you have any further problems.
Attached Files
File Type: zip Argil.zip (47.4 KB, 5 views)
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old November 9, 2019, 17:19   #82
DavidMedley
Adept
 
Join Date: Oct 2019
Posts: 174
DavidMedley is on a distinguished road
Quote:
Originally Posted by Derakon View Post
Adamantite, and mithril, are both corrosion-proof. That holds for armor made of the metal just as much as it does for monsters made of it.
Makes sense
DavidMedley is offline   Reply With Quote
Old November 9, 2019, 23:59   #83
DavidMedley
Adept
 
Join Date: Oct 2019
Posts: 174
DavidMedley is on a distinguished road
Are You Stoned?

When I'm hallucinating, if I do things like hit space, escape, browse a book, etc., no time passes but my hallucinations flicker. Shouldn't they only change when time passes? Pretty easy to determine whether something is actually there or not this way.
DavidMedley is offline   Reply With Quote
Old November 10, 2019, 03:58   #84
scrarth
Rookie
 
Join Date: Nov 2019
Posts: 3
scrarth is on a distinguished road
Quote:
Originally Posted by Nick View Post
OK, fixed savefile attached. The saved town was the problem, so when you go back there you will find the layout different; the shop and your home should be unaffected. Let me know if you have any further problems.
No luck on my end unfortunately, I still get the chunk_copy() level bounds failed error message.
scrarth is offline   Reply With Quote
Old November 10, 2019, 05:10   #85
DavidMedley
Adept
 
Join Date: Oct 2019
Posts: 174
DavidMedley is on a distinguished road
Quote:
Originally Posted by Derakon View Post
Adamantite, and mithril, are both corrosion-proof. That holds for armor made of the metal just as much as it does for monsters made of it.
Mithril Golem does not resist acid, however.
DavidMedley is offline   Reply With Quote
Old November 10, 2019, 05:28   #86
Derakon
Prophet
 
Derakon's Avatar
 
Join Date: Dec 2009
Posts: 8,941
Derakon is on a distinguished road
Quote:
Originally Posted by DavidMedley View Post
Mithril Golem does not resist acid, however.
Good news! We're in the 4.2.0 bugs thread, so hopefully Nick will see this.

(They may have been made vulnerable so that mages would have some way to fight them...)
Derakon is offline   Reply With Quote
Old November 10, 2019, 05:50   #87
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 54
Posts: 7,860
Donated: $60
Nick will become famous soon enough
Quote:
Originally Posted by scrarth View Post
No luck on my end unfortunately, I still get the chunk_copy() level bounds failed error message.
Sorry, I attached the wrong one

This one should be OK - I recalled back to town from your save.
Attached Files
File Type: zip Argil.zip (61.8 KB, 6 views)
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old November 10, 2019, 10:31   #88
scrarth
Rookie
 
Join Date: Nov 2019
Posts: 3
scrarth is on a distinguished road
Quote:
Originally Posted by Nick View Post
Sorry, I attached the wrong one

This one should be OK - I recalled back to town from your save.
Yep, it's working fine now. Thanks a bunch for that!
scrarth is offline   Reply With Quote
Old November 12, 2019, 02:12   #89
backwardsEric
Rookie
 
Join Date: Aug 2019
Posts: 13
backwardsEric is on a distinguished road
Other memory leaks

Other memory leaks reported by XCode's Leaks instrument for Angband 4.2.0:

1) Some "known" versions of objects allocated from the following partial call stacks below (omitting the calls before process_command()) were leaked.

mem_alloc()
mem_zalloc()
object_new()
object_split()
gear_object_for_use()
ranged_helper()
do_cmd_fire()
process_cmd()

mem_alloc()
mem_zalloc()
object_new()
object_see()
square_know_pile()
square_note_spot()
update_one()
update_view()
move_player()
do_cmd_walk()
process_command()

mem_alloc()
mem_zalloc()
object_new()
object_sense()
square_sense_pile()
effect_handler_SENSE_OBJECTS()
effect_do()
use_aux()
do_cmd_read_scroll()
process_command()

The attached file, object-absorb-known-object-leak-patch.txt, patches object_absorb(), but that doesn't eliminate all of those leaks.

2) An object allocated from this partial call stack,

mem_alloc()
mem_zalloc()
object_new()
make_object()
place_object()
alloc_object()
alloc_objects()
classic_gen()
cave_generate()
prepare_next_level()

, was leaked.

3) The string allocated from this partial call stack,

mem_alloc()
string_make()
cmd_set_arg_string()
cmd_get_string()
do_cmd_inscribe()
process_command()

was leaked when inscribing an object.

4) During character creation, there's a leak if the player edits the character background information. The partial call stack for where the allocations occur is

mem_realloc()
textblock_calculate_lines()
edit_text()
textui_do_birth()
play_game()

5) During character creation, the background or quest information can be leaked, especially if the player backtracks to select a different combination of race and class. The partial call stacks for where the allocations occurred were:

string_append()
player_generate()
do_cmd_choose_race()
process_command()

string_append()
player_generate()
do_cmd_choose_class()
process_command()

string_append()
player_generate()
do_cmd_birth_reset()
process_command()

string_append()
do_cmd_roll_stats()
process_command()

string_make()
do_cmd_choose_history()
process_command()

string_append()
player_generate()
do_cmd_birth_init()
process_command()

mem_zalloc()
player_quests_reset()
player_init()
do_cmd_birth_reset()
process_command()

string_make()
player_quests_reset()
player_init()
do_cmd_birth_reset()
process_command()

The attached file, player-birth-memory-leaks-patch.txt, has patches to plug those leaks and the leak in (4).
Attached Files
File Type: txt object-absorb-known-object-leak-patch.txt (1,018 Bytes, 9 views)
File Type: txt player-birth-memory-leaks-patch.txt (3.2 KB, 7 views)
backwardsEric is online now   Reply With Quote
Old November 14, 2019, 07:47   #90
backwardsEric
Rookie
 
Join Date: Aug 2019
Posts: 13
backwardsEric is on a distinguished road
File not closed in remove_old_dump() if error

In ui-prefs.c's remove_old_dump(), if there is an error opening the new file, the current file won't be closed. The attached patch fixes that.
Attached Files
File Type: txt remove_old_dump_close_if_error_patch.txt (743 Bytes, 7 views)
backwardsEric is online now   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Bugs with 3.5 donalde Vanilla 10 February 24, 2014 18:28
Bugs: V3.1.2 Pete Mack Vanilla 34 December 1, 2010 18:18
Bugs Adley Development 2 October 10, 2010 22:11
V bugs (3.1.1) Pete Mack Vanilla 3 January 10, 2010 10:02
V 3.9 Bugs momo125 Vanilla 3 September 11, 2007 16:48


All times are GMT +1. The time now is 22:48.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.