Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old April 16, 2020, 17:07   #221
DavidMedley
Knight
 
Join Date: Oct 2019
Posts: 726
DavidMedley is on a distinguished road
What if the throwing menus were separated like inv/eq/quiv? Like, you hit v to throw and the first menu it brings up has only things that are made for throwing. If there's nothing on that screen, or if you press left or right, there would be different lists, probably the same inv/eq/quiv lists we already have.
DavidMedley is offline   Reply With Quote
Old April 16, 2020, 22:56   #222
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 55
Posts: 8,393
Donated: $60
Nick will become famous soon enough
Quote:
Originally Posted by DavidMedley View Post
What if the throwing menus were separated like inv/eq/quiv? Like, you hit v to throw and the first menu it brings up has only things that are made for throwing. If there's nothing on that screen, or if you press left or right, there would be different lists, probably the same inv/eq/quiv lists we already have.
That's an interesting idea.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old April 16, 2020, 23:23   #223
Diego Gonzalez
Adept
 
Join Date: May 2007
Posts: 170
Diego Gonzalez is on a distinguished road
Then objects (flask of oil, throwing hammer, etc) should have an specific flag in the txt files for this.
Diego Gonzalez is offline   Reply With Quote
Old April 16, 2020, 23:43   #224
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 55
Posts: 8,393
Donated: $60
Nick will become famous soon enough
Quote:
Originally Posted by Diego Gonzalez View Post
Then objects (flask of oil, throwing hammer, etc) should have an specific flag in the txt files for this.
There is already a flag for throwing weapons that should work for this.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old April 17, 2020, 15:45   #225
DavidMedley
Knight
 
Join Date: Oct 2019
Posts: 726
DavidMedley is on a distinguished road
Playing the nightly (4.2.0 may be the same) and there was a spear under webs. I couldn't find any indication it was there except for the object window and moving over it. Seems like if it's hidden from sight it should be hidden from the object window, or if it's visible in the object window it should be visible on screen or at least to the look command. Or possibly I remembered it was there from before the webs covered it, but I still feel the same principle should apply.
DavidMedley is offline   Reply With Quote
Old April 17, 2020, 20:48   #226
DavidMedley
Knight
 
Join Date: Oct 2019
Posts: 726
DavidMedley is on a distinguished road
What are the current plans for the next release? ETA, will it be 4.2.1 or 4.3, anything that needs to be in it that's not in yet, etc.
DavidMedley is offline   Reply With Quote
Old April 17, 2020, 22:50   #227
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 55
Posts: 8,393
Donated: $60
Nick will become famous soon enough
Quote:
Originally Posted by DavidMedley View Post
Playing the nightly (4.2.0 may be the same) and there was a spear under webs. I couldn't find any indication it was there except for the object window and moving over it. Seems like if it's hidden from sight it should be hidden from the object window, or if it's visible in the object window it should be visible on screen or at least to the look command. Or possibly I remembered it was there from before the webs covered it, but I still feel the same principle should apply.
Yes, this is actually kind of tricky, I'm not sure of the best solution.

As for next release - once the nightlies are bug free is the general idea. With the new blackguards I wanted a little time for bugs to emerge and minor changes to be made too. Bugs are down under 20 now, so I think around a month is possible - but it could be longer, or theoretically shorter. And it will be 4.2.1 - the general idea being that 4.2 was a major change, and the 4.2.x series is essentially improvements on that, and maintains savefile compatibility.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old April 17, 2020, 23:35   #228
DavidMedley
Knight
 
Join Date: Oct 2019
Posts: 726
DavidMedley is on a distinguished road
Sounds good. Thanks for the update.
DavidMedley is offline   Reply With Quote
Old April 18, 2020, 01:10   #229
Diego Gonzalez
Adept
 
Join Date: May 2007
Posts: 170
Diego Gonzalez is on a distinguished road
Perhaps this is a problem of the android port but I'll report a possible bug here, just in case.

When inspecting Google's Play Console I see that there are several crashes in findpath, from anonymous users.

After trying to dissect the ndk coredump, the ndk-stack tool points me to this line:

Code:
pf_result[pf_result_index++] = '0' + (char)(10 - dir);
The code doesn't check for array overflow. This is a bug in Vanilla ?

I'll try to reproduce the bug.
Diego Gonzalez is offline   Reply With Quote
Old April 18, 2020, 01:31   #230
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 55
Posts: 8,393
Donated: $60
Nick will become famous soon enough
Quote:
Originally Posted by Diego Gonzalez View Post
Perhaps this is a problem of the android port but I'll report a possible bug here, just in case.

When inspecting Google's Play Console I see that there are several crashes in findpath, from anonymous users.

After trying to dissect the ndk coredump, the ndk-stack tool points me to this line:

Code:
pf_result[pf_result_index++] = '0' + (char)(10 - dir);
The code doesn't check for array overflow. This is a bug in Vanilla ?

I'll try to reproduce the bug.
A bug in this code would not surprise me at all. I'll do a check too.

EDIT: OK, one massive bug found here already. I'm rewriting the whole thing.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.

Last edited by Nick; April 18, 2020 at 01:49. Reason: OMG
Nick is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Current master post-4.1.3 Nick Vanilla 505 June 16, 2019 00:26
Suggestion for Rangers (repost from master-post thread) Thraalbee Vanilla 1 April 13, 2019 18:08
Issues on current master Nick Vanilla 277 June 18, 2017 22:30
Bugs and complaints on current master Nick Vanilla 588 April 27, 2017 22:54
Master Thief Grotug Idle chatter 1 March 26, 2017 23:54


All times are GMT +1. The time now is 18:22.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2020, vBulletin Solutions Inc.