Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old May 28, 2009, 18:03   #1
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
"You have nothing to identify."

This happened to me yesterday:

You have nothing to identify.
The hill orc hits you.

... and I thought, hey, wait a minute, surely I shouldn't waste a turn if there isn't anything to ID. It seems to me the same as "There's a wall in the way!" and "You are too afraid to attack the foo!", neither of which wastes a turn. But "You have nothing to identify" (and also "you have nothing to enchant") do.

I've looked at the code, and it's non-trivial to change this, so I thought I'd see what everybody else thought before embarking on it.

On a related note, cancelling out of item selection should also not take a turn, but as far as I can tell, it does. I've never had hard proof of this though, so I may have failed to understand the code. IMO neither aborting the ID at item selection nor having nothing to ID should cost you a turn.
Magnate is offline   Reply With Quote
Old May 28, 2009, 18:31   #2
Nolendil
Adept
 
Nolendil's Avatar
 
Join Date: May 2007
Location: Paris, France
Posts: 171
Donated: 10 euro
Nolendil is on a distinguished road
I didn't know that it used one turn and I share your point of view.
That's not a big deal if you can't fix it as I only use Id when I'm safe.
__________________
A(3.2.0) C "Angdiira II" DP L:36 DL:44(2200') A+ R+ Sp w:Whip of Westernesse(+10,+10)(+2)
A Mx H- D c-- f- PV+ s- d P++ M+
C- S-- I So B++ ac GHB- SQ+ RQ++ V+
Nolendil is offline   Reply With Quote
Old May 28, 2009, 18:36   #3
will_asher
DaJAngband Maintainer
 
will_asher's Avatar
 
Join Date: Apr 2007
Location: San Antonio, TX
Posts: 927
Donated: $10
will_asher is on a distinguished road
It seems to me that it would be easy to make it not take a turn, just change the part in do_cmd_read_scroll() so that "take a turn" comes after the reading of the scroll, like this:
Code:
	/* Read the scroll */
	used_up = use_object(o_ptr, &ident);

	/* Take a turn */
	if (used_up) p_ptr->energy_use = 100;
Did I miss something?
__________________
Will_Asher

Play DaJAngband:
http://sites.google.com/site/dajangbandwebsite/home
will_asher is offline   Reply With Quote
Old May 28, 2009, 19:00   #4
Zikke
Veteran
 
Join Date: Jun 2008
Location: Los Angeles
Posts: 1,068
Zikke is on a distinguished road
I agree that not IDing something shouldn't take a turn. It doesn't even consume the charge on the staff or whatever.
__________________
A(3.1.0b) CWS "Fyren_V" NEW L:50 DL:127 A++ R+++ Sp+ w:The Great Axe of Eonwe
A/FA W H- D c-- !f PV+++ s? d P++ M+
C- S+ I- !So B ac++ GHB? SQ? !RQ V F:
Zikke is offline   Reply With Quote
Old May 28, 2009, 19:05   #5
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by will_asher View Post
Did I miss something?
Yeah - spells, staves, rods, artifact activation.

I think it needs some surgery on get_item.
Magnate is offline   Reply With Quote
Old May 28, 2009, 19:25   #6
Marble Dice
Swordsman
 
Join Date: Jun 2008
Location: Columbia, MO. USA
Posts: 405
Marble Dice is on a distinguished road
Quote:
Originally Posted by Magnate View Post
So the other day I was unnecessarily reading Identify scrolls while standing adjacent to a horde of hostile orcs.
Fixed that for you. If that's not good game testing, I don't know what is.

I concur, this would be a good change.
Marble Dice is offline   Reply With Quote
Old May 28, 2009, 19:38   #7
PowerDiver
Prophet
 
Join Date: Mar 2008
Posts: 2,712
PowerDiver is on a distinguished road
Quote:
Originally Posted by Magnate View Post
This happened to me yesterday:

You have nothing to identify.
The hill orc hits you.

... and I thought, hey, wait a minute, surely I shouldn't waste a turn if there isn't anything to ID. It seems to me the same as "There's a wall in the way!" and "You are too afraid to attack the foo!", neither of which wastes a turn. But "You have nothing to identify" (and also "you have nothing to enchant") do.

I've looked at the code, and it's non-trivial to change this, so I thought I'd see what everybody else thought before embarking on it.

On a related note, cancelling out of item selection should also not take a turn, but as far as I can tell, it does. I've never had hard proof of this though, so I may have failed to understand the code. IMO neither aborting the ID at item selection nor having nothing to ID should cost you a turn.

The interpretation is that you take a turn reading the scroll, and then there is nothing for the magic to act upon. Like zapping a rod of drain life at an adjacent wall. Just be glad the scroll doesn't disintegrate the way they usually do when you read them!

Consider the case when you read an unaware scroll of banishment and quit out without selecting a monster. You gain awareness. Surely that should cost a turn.

It used to be that a failed attack due to fear cost you a turn. I requested a change, but did not know that made it into dev yet.

Canceling item selection does not take a turn, and I don't remember that it ever did.
PowerDiver is offline   Reply With Quote
Old May 28, 2009, 20:25   #8
PowerDiver
Prophet
 
Join Date: Mar 2008
Posts: 2,712
PowerDiver is on a distinguished road
Quote:
Originally Posted by Magnate View Post
I've looked at the code, and it's non-trivial to change this, so I thought I'd see what everybody else thought before embarking on it.
If you want to make this impossible, the right approach is to modify the selection hook so that when you press 'r', the code checks your surroundings for something to be identified [should be a preexisting function for that], and if there is nothing to identify the scroll of identify is not considered a valid selection.

It might only be a few lines of code, or it might be messy, I don't know. It might also be confusing to people who wonder why they cannot figure out how to read their identify scroll.
PowerDiver is offline   Reply With Quote
Old May 28, 2009, 20:27   #9
PowerDiver
Prophet
 
Join Date: Mar 2008
Posts: 2,712
PowerDiver is on a distinguished road
Quote:
Originally Posted by PowerDiver View Post
Canceling item selection does not take a turn, and I don't remember that it ever did.
I now think I misunderstood you. Pressing 'r' and then canceling does not cost a turn. If you 'r' on a scroll of identify, and then cancel before selecting the item to id, that does cost a turn.
PowerDiver is offline   Reply With Quote
Old May 28, 2009, 23:16   #10
Donald Jonker
Knight
 
Join Date: Jun 2008
Posts: 593
Donald Jonker is on a distinguished road
Quote:
Originally Posted by PowerDiver View Post
The interpretation is that you take a turn reading the scroll, and then there is nothing for the magic to act upon. Like zapping a rod of drain life at an adjacent wall. Just be glad the scroll doesn't disintegrate the way they usually do when you read them!
This seems inconsistent. Either the magic is consumed or it isn't. You read the scroll or you don't. Another interpretation of events would be that your player checks your inventory for unID'd items prior to actually reading the scroll. Then the non-use of a turn would make sense.

Quote:
Consider the case when you read an unaware scroll of banishment and quit out without selecting a monster. You gain awareness. Surely that should cost a turn.
You could make a special case of awareness-gaining taking a turn. But there doesn't seem to be any good reason why gaining awareness on ?phase should consume a scroll and gaining it on ?ID shouldn't. I don't know that there is a consistent, expedient way of handling it. Maybe force the player to choose an inventory item to ID/monster to banish in order to gain awareness. In the latter case it would be dangerous/wasteful, however.
__________________
Bands, / Those funny little plans / That never work quite right.
-Mercury Rev
Donald Jonker is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
How many turns do you "lose" when recalling back to town? bebo Vanilla 32 February 11, 2009 15:22
Quick Diving versus "Recommended Depths" Wraitheist Vanilla 14 May 4, 2008 09:12
Blast! Killed by a "summon monster" trap Wraitheist Vanilla 10 April 27, 2008 19:36
[Norseband] Help needed with "silly" time messages ISNorden Variants 2 April 4, 2008 22:06
Roguelike idea from "Lost Magic" DS game - Mr. @ teaches typing! ekolis Idle chatter 10 October 19, 2007 04:25


All times are GMT +1. The time now is 08:27.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2021, vBulletin Solutions Inc.