Go Back   Angband Forums > Angband > Development

Thread Tools Display Modes
Old May 27, 2009, 10:42   #1
Join Date: Jan 2009
Posts: 657
PaulBlay is on a distinguished road
errr get_birth_command(bool wait) in Vanilla

Just a couple of minor points.

errr get_birth_command(bool wait)
    static enum birth_stage current_stage = BIRTH_RESET;
    static enum birth_stage prev;
    static enum birth_stage roller = BIRTH_RESET;
    enum birth_stage next = current_stage;
Might I suggest prev_stage and next_stage as being easier more consistent with current_stage (and easier to search on ;-)?

Initializing prev (or prev_stage, if you would ;-) to BIRTH_RESET would remove a compiler warning and I don't think it would have any other effect. (prev is set to BIRTH_RESET at the end of get_birth_command the first time it is called).
Currently turning (Angband) Japanese.
PaulBlay is offline   Reply With Quote

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Vanilla Pseudo ID Mondkalb Vanilla 18 May 22, 2009 04:07
How much do you love... Vanilla? Larvitz Vanilla 3 January 31, 2009 03:07
Vanilla as opposed to Variants? Larvitz Vanilla 5 January 21, 2009 08:07
Vanilla throwing bug? HallucinationMushroom Vanilla 6 January 10, 2009 19:41
No sound in new Vanilla versions Mondkalb Vanilla 1 October 3, 2007 08:38

All times are GMT +1. The time now is 19:08.

Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2020, vBulletin Solutions Inc.