Adding Oangband magic realms/spellbooks. What changes do I need to make?

[Elfin Jedi]

Originally Posted by Pete Mack

Inventory has it's own interface with colors. I suspect it's printing black on black, or just giving up. What color did you specify in object_base.txt?

light purple for necromancy books, light green for nature books; changing prayer books to light blue. They do display properly on the ASCII map. (Light green ?, light purple ?.)

[Nick]

OK, I think you probably need to add some code to obj_desc_get_basename() in obj-desc.c - mimic what is done for TV_MAGIC_BOOK and TV_PRAYER_BOOK.

[Pete Mack]

Hmm. Looks like more data that belongs in object_base.txt
I'd forgotten all about that.
Edit:
The thing to do is to grep for cases for TV_MAGIC_BOOK and add new entries. This is not the only place, by a long shot. There are 10 places that need to be edited.

[Elfin Jedi]

Originally Posted by Nick

OK, I think you probably need to add some code to obj_desc_get_basename() in obj-desc.c - mimic what is done for TV_MAGIC_BOOK and TV_PRAYER_BOOK.

Originally Posted by Pete Mack

The thing to do is to grep for cases for TV_MAGIC_BOOK and add new entries. This is not the only place, by a long shot. There are 10 places that need to be edited.

Already done, found this:

case TV_MAGIC_BOOK:
if (terse)
return "& Book~ #";
else
return "& Book~ of Magic Spells #";

case TV_PRAYER_BOOK:
if (terse)
return "& Book~ #";
else
return "& Holy Book~ of Prayers #";

case TV_NATURE_BOOK:
if (terse)
return "& Book~ #";
else
return "& Book~ of Nature Lore #";

case TV_NECROMANCY_BOOK:
if (terse)
return "& Book~ #";
else
return "& Book~ of Necromancy #";

I already searched for TV_MAGIC_BOOK, Book, and even TV a while ago and added more code for each of the results. Except for wiz-stats.c which only has TV_MAGIC_BOOK and has a note saying that since prayer books have the same probability only one of the two needs to be tracked. I don't know if there would be anything there that needs editing.

List of files changed: list-tvals.h, obj-desc.c, obj-randart.c, obj-tval.c, store.c, ui-knowledge.c, ui-options.c, wiz-spoil.c. Oh and list-magic-realms.h, object.txt, object_base.txt, store.txt, class.txt.

[Pete Mack]

If the issue is still happening, I suspect you'd do better to fire up the debugger. The one in MSVC is pretty easy to use. Put a breakpoint in the appropriate subroutine.

[Nick]

Originally Posted by Pete Mack

If the issue is still happening, I suspect you'd do better to fire up the debugger. The one in MSVC is pretty easy to use. Put a breakpoint in the appropriate subroutine.

Agreed - that's what I'd be doing now. In fact, it is what I'm doing for my tragically buggy pathfinding algorithm...

[Pete Mack]

Whoops, forgot which thread I was replying to. But even gdb is better than blind guesses