Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old August 3, 2013, 07:42   #1
molybdenum
Apprentice
 
Join Date: May 2013
Posts: 84
molybdenum is on a distinguished road
[3.5-dev] Boulder damage calculation error

In nonhp_dam(), there is this calculation (which is only used by boulder attacks):

Code:
	if (rs_ptr->rlev_dam.m_bonus == 1) /* then rlev affects dice */
		dam += damcalc(MIN(1, rs_ptr->rlev_dam.dice * rlev / 100), 
				rs_ptr->rlev_dam.sides, dam_aspect);
MIN() should probably be changed to MAX(). Otherwise, boulders will only do a max of 24 damage.
molybdenum is offline   Reply With Quote
Old August 3, 2013, 11:36   #2
takkaria
Veteran
 
takkaria's Avatar
 
Join Date: Apr 2007
Posts: 1,947
Donated: $40
takkaria is on a distinguished road
Quote:
Originally Posted by molybdenum View Post
In nonhp_dam(), there is this calculation (which is only used by boulder attacks):

Code:
	if (rs_ptr->rlev_dam.m_bonus == 1) /* then rlev affects dice */
		dam += damcalc(MIN(1, rs_ptr->rlev_dam.dice * rlev / 100), 
				rs_ptr->rlev_dam.sides, dam_aspect);
MIN() should probably be changed to MAX(). Otherwise, boulders will only do a max of 24 damage.
Fixed, thanks.
__________________
takkaria whispers something about options. -more-
takkaria is offline   Reply With Quote
Old August 3, 2013, 18:58   #3
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,060
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by takkaria View Post
Fixed, thanks.
Apologies, that's one of mine.
__________________
"3.4 is much better than 3.1, 3.2 or 3.3. It still is easier than 3.0.9, but it is more convenient to play without being ridiculously easy, so it is my new favorite of the versions." - Timo Pietila
Magnate is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
3.5-dev error on startup Raajaton Vanilla 2 May 16, 2013 02:02
Damage bonuses that don't provide extra damage? Egavactip v4 2 May 27, 2012 02:51
Damage/round calculation Chud Vanilla 15 December 11, 2011 10:05
damage calculation? Gockel Variants 4 September 14, 2010 23:17
[O] Error Using Dev-C++ to compile BennyG Variants 8 October 2, 2009 17:51


All times are GMT +1. The time now is 03:03.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2022, vBulletin Solutions Inc.