Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old April 19, 2021, 00:57   #41
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 56
Posts: 9,134
Donated: $60
Nick will become famous soon enough
Quote:
Originally Posted by MattB View Post
Tonnes of larva.
Demon spawn?
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old April 19, 2021, 01:17   #42
MattB
Veteran
 
Join Date: Mar 2013
Location: Berkshire, UK
Posts: 1,212
MattB is on a distinguished road
Quote:
Originally Posted by Nick View Post
Demon spawn?
Hahaha!
Fair point and well made.
Yes, there was lots of lava but very little larvae.
MattB is offline   Reply With Quote
Old April 20, 2021, 09:46   #43
PowerWyrm
Prophet
 
PowerWyrm's Avatar
 
Join Date: Apr 2008
Posts: 2,893
PowerWyrm is on a distinguished road
- open client
- set tile size to 16x16
- use "l"ook command
- crash

In do_cmd_locate():

Code:
int panel_hgt = (int)(PANEL_SIZE / tile_height);
int panel_wid = (int)(PANEL_SIZE / tile_width);

strnfmt(out_val, sizeof(out_val),
		        "Map sector [%d,%d], which is%s your sector.  Direction?",
		        (y2 / panel_hgt), (x2 / panel_wid), tmp_val);
But PANEL_SIZE = 11, so if you use tile size greater than 11 the values for panel_hgt and panel_wid will be 0 and will provoke a division by zero error in the following line...
__________________
PWMAngband variant maintainer - check http://powerwyrm.monsite-orange.fr (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!
PowerWyrm is offline   Reply With Quote
Old April 20, 2021, 10:28   #44
PowerWyrm
Prophet
 
PowerWyrm's Avatar
 
Join Date: Apr 2008
Posts: 2,893
PowerWyrm is on a distinguished road
Also the sector displayed makes absolutely no sense...

It should start at [0,0] if you're in the northwesternmost panel and should be increased by 1 each time you move east or south from there. See MAngband code:

Code:
/* Start at current panel */
	y2 = p_ptr->panel_row;
	x2 = p_ptr->panel_col;

/* Apply the motion */
	y2 += ddy[dir];
	x2 += ddx[dir];

/* Prepare to ask which way to look */
	sprintf(out_val,
	        "Map sector [%d,%d], which is%s your sector.  Direction?",
	        y2, x2, tmp_val);

/* Set the panel location */
	p_ptr->panel_row = y2;
	p_ptr->panel_col = x2;
__________________
PWMAngband variant maintainer - check http://powerwyrm.monsite-orange.fr (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!

Last edited by PowerWyrm; April 20, 2021 at 10:36.
PowerWyrm is offline   Reply With Quote
Old April 20, 2021, 11:05   #45
MattB
Veteran
 
Join Date: Mar 2013
Location: Berkshire, UK
Posts: 1,212
MattB is on a distinguished road
I just TO'd the Balrog of Moria, then summoned him on the same level using a staff of summoning.
Should that happen?
Feels weird to me...
MattB is offline   Reply With Quote
Old April 20, 2021, 13:14   #46
PowerWyrm
Prophet
 
PowerWyrm's Avatar
 
Join Date: Apr 2008
Posts: 2,893
PowerWyrm is on a distinguished road
Quote:
Originally Posted by MattB View Post
I just TO'd the Balrog of Moria, then summoned him on the same level using a staff of summoning.
Should that happen?
Feels weird to me...
IIRC that's a new feature. Looking at the code, the summon function now has a "call" parameter which uses a new method of summoning ("calls out" a monster that is present on the level) and this parameter is set to "true" 25% of the time randomly.
__________________
PWMAngband variant maintainer - check http://powerwyrm.monsite-orange.fr (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!
PowerWyrm is offline   Reply With Quote
Old April 20, 2021, 13:40   #47
PowerWyrm
Prophet
 
PowerWyrm's Avatar
 
Join Date: Apr 2008
Posts: 2,893
PowerWyrm is on a distinguished road
If you try to use the "l"ook command when using 16x16 tile size and you end up with a panel of size 0, the command will also loop endlessly.
__________________
PWMAngband variant maintainer - check http://powerwyrm.monsite-orange.fr (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!
PowerWyrm is offline   Reply With Quote
Old April 20, 2021, 14:41   #48
PowerWyrm
Prophet
 
PowerWyrm's Avatar
 
Join Date: Apr 2008
Posts: 2,893
PowerWyrm is on a distinguished road
Using this code everywhere panel dimensions (in particular "screen_wid / 2" occurences) are used fixes the problem:

Code:
int screen_hgt, screen_wid;
    int panel_wid, panel_hgt;

    screen_hgt = p->screen_rows / p->tile_hgt;
    screen_wid = p->screen_cols / p->tile_wid;

    panel_wid = screen_wid / 2;
    panel_hgt = screen_hgt / 2;

    /* Paranoia */
    if (panel_wid < 1) panel_wid = 1;
    if (panel_hgt < 1) panel_hgt = 1;
The only remaining issue with this is that the @ isn't visible if panel_hgt = 1 (it's displayed one line below).
__________________
PWMAngband variant maintainer - check http://powerwyrm.monsite-orange.fr (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!
PowerWyrm is offline   Reply With Quote
Old April 20, 2021, 21:05   #49
MattB
Veteran
 
Join Date: Mar 2013
Location: Berkshire, UK
Posts: 1,212
MattB is on a distinguished road
Quote:
Originally Posted by PowerWyrm View Post
IIRC that's a new feature. Looking at the code, the summon function now has a "call" parameter which uses a new method of summoning ("calls out" a monster that is present on the level) and this parameter is set to "true" 25% of the time randomly.
Oh. Fair enough then.
That might call an end to my traditional level-ending of standing on the stairs with a staff of summoning trying to call up some cheap low-level uniques.
MattB is offline   Reply With Quote
Old April 20, 2021, 22:16   #50
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 56
Posts: 9,134
Donated: $60
Nick will become famous soon enough
Quote:
Originally Posted by PowerWyrm View Post
IIRC that's a new feature. Looking at the code, the summon function now has a "call" parameter which uses a new method of summoning ("calls out" a monster that is present on the level) and this parameter is set to "true" 25% of the time randomly.
Neat, I forgot I did that
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Current master post-4.2.1 Nick Vanilla 241 February 28, 2021 15:12
Current master post 4.2.0 Nick Vanilla 463 June 5, 2020 03:31
Current master post-4.1.3 Nick Vanilla 505 June 16, 2019 00:26
Issues on current master Nick Vanilla 277 June 18, 2017 22:30
Bugs and complaints on current master Nick Vanilla 588 April 27, 2017 22:54


All times are GMT +1. The time now is 13:59.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2021, vBulletin Solutions Inc.