FAangband 2.0.1

[MITZE]

Was looking into Mana Burn, but noticed something about crits in general that I'm confused by.

player-attack.c, line 804 seems to imply that melee and throwing share the same crit tiering (and consequently that shooting has a different tiering).

However, the critical_shot function starting at player-attack.c, line 435 seems to imply that shooting and throwing share a crit tiering (and that consequently melee has its own).

Do melee, throwing, and shooting have differences or limitations in which crits they can get? Or is this just the result of obtuse/old code comments resulting in me having the wrong idea? (Also, and I'm pretty sure this has been brought up before, probably even by me, but are crits in fact working as intended?)

[swim]

For the "Evasion" special ability, do shields count towards the weight to be considered lightly armored?

[Nick]

Originally Posted by swim

For the "Evasion" special ability, do shields count towards the weight to be considered lightly armored?

Yes, armor is used in the broad sense - so body armor, cloaks, shields, boots, gloves, hats.

[swim]

Originally Posted by Nick

Yes, armor is used in the broad sense - so body armor, cloaks, shields, boots, gloves, hats.

What about amulets?

[Nick]

Originally Posted by swim

What about amulets?

Nope, doesn't count amulets, rings or lights.

[swim]

Originally Posted by Nick

Nope, doesn't count amulets, rings or lights.

Thanks!

[MITZE]

Never again, huh.

[MITZE]

I could have sworn that resistances stacked multiplicatively, with diminishing returns (i.e. 50% + 50% = 75%) and that vulnerabilities were applied last, multiplicatively, to the resistance total (so if you have 80% resistance and 50% vulnerability your actual resistance is 40%).

However, Eriloth has a character with rCold (50%, 34%, -55%, 40%, 10%, 35%) which tallied up to ~83%, which seemed too high to me.

Did it work differently in FA1, and I'm remembering from that?

[Nick]

Originally Posted by MITZE

I could have sworn that resistances stacked multiplicatively, with diminishing returns (i.e. 50% + 50% = 75%) and that vulnerabilities were applied last, multiplicatively, to the resistance total (so if you have 80% resistance and 50% vulnerability your actual resistance is 40%).

However, Eriloth has a character with rCold (50%, 34%, -55%, 40%, 10%, 35%) which tallied up to ~83%, which seemed too high to me.

Did it work differently in FA1, and I'm remembering from that?

83% is correct. The easy way to check is to calculate the amount of damage that gets through, multiplicatively - so 34% resist is 66% damage, etc. In this case,

.5 * .66 * 1.55 * .6 * .9 * .65 ~= .17

so roughly 83% resist.

Originally Posted by MITZE

Attachment 2122

Never again, huh.

Hm, maybe one of the changes I pulled in from V broke something.

[backwardsEric]

Originally Posted by Nick

Hm, maybe one of the changes I pulled in from V broke something.

In obj-design.c's get_property() the handling of OBJ_PROPERTY_MOD and OBJ_PROPERTY_STAT seems suspicious. According to line 235, the passed in value is being treated as an increment to the current value, but the calculated cost for the adjusted value (from line 224) only accounts for the increment and does not include the current value. There's something similarly suspicious about the handling of OBJ_PROPERTY_ELEMENT.