Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Variants

Reply
 
Thread Tools Display Modes
Old January 18, 2013, 18:05   #31
chris
PosChengband Maintainer
 
Join Date: Jan 2008
Posts: 702
chris is on a distinguished road
Quote:
Originally Posted by Arjen View Post
Just killed Ares, he didn't drop his hat...
Olympians no longer drop 100%. They are also a bit easier than in Chengband (but Ares is no pushover!!).
chris is offline   Reply With Quote
Old January 18, 2013, 18:10   #32
Arjen
Adept
 
Join Date: Dec 2010
Location: The Netherlands
Age: 35
Posts: 240
Arjen is on a distinguished road
Ares is when you have a 300-400 damage darkness storm and resist teleport. But too bad, I wanted to check if I could get a blow from it.

Found the Ring of Destruction with all it's brands, but those don't work... 9d9 brand all eye was just a dream. But the malus on that ring are bad too.

(Nice job on the new artifacts, I like the magic based lamps too). Now if only monsters who drop {good} could drop more jewelry.
Arjen is offline   Reply With Quote
Old January 20, 2013, 21:50   #33
Darin
Apprentice
 
Join Date: Jun 2010
Location: Massachusetts, USA
Posts: 52
Darin is on a distinguished road
For the comp I managed to compile v1.0.3 for the Mac (X11 only, Intel only). But the inventory percentages look, well, a bit off, so I don't know what other interesting numbers there may be, or if it is a cosmetic problem or something worse. I was able to play through a game with no obvious problems, though.

big_inventory_percentage
Darin is offline   Reply With Quote
Old January 20, 2013, 22:39   #34
chris
PosChengband Maintainer
 
Join Date: Jan 2008
Posts: 702
chris is on a distinguished road
Quote:
Originally Posted by Darin View Post
For the comp I managed to compile v1.0.3 for the Mac (X11 only, Intel only). But the inventory percentages look, well, a bit off, so I don't know what other interesting numbers there may be, or if it is a cosmetic problem or something worse. I was able to play through a game with no obvious problems, though.

big_inventory_percentage
In cmd3.c on line 55 is the following code:
Code:
sprintf(out_val, "Inventory: carrying %d.%d pounds (%ld%% of capacity). Command: ", 
  (int)(p_ptr->total_weight / 10), 
  (int)(p_ptr->total_weight % 10), 
  (p_ptr->total_weight * 100) / weight_limit());
The total_weight field seems correct. But I wonder if the %ld is wrong. The field is really an int and we should probably use %d instead. Could you make this change and recompile?

BTW, I've seen a lot of %ld and casting things to long throughout the code base. This makes me nervous as a long is 64 bits for 64-bit compiles while an int is still just 32 bits.

Also, if you get a Mac makefile working, could you email me a copy (perhaps with instructions). I've had interest in a mac compile for Chengband before but could never oblige as I don't have access to a mac. My email address is ckousky at gmail dot com.

Thanks!
chris is offline   Reply With Quote
Old January 21, 2013, 01:10   #35
Darin
Apprentice
 
Join Date: Jun 2010
Location: Massachusetts, USA
Posts: 52
Darin is on a distinguished road
Quote:
Originally Posted by chris View Post
In cmd3.c on line 55 is the following code:
Code:
sprintf(out_val, "Inventory: carrying %d.%d pounds (%ld%% of capacity). Command: ", 
  (int)(p_ptr->total_weight / 10), 
  (int)(p_ptr->total_weight % 10), 
  (p_ptr->total_weight * 100) / weight_limit());
The total_weight field seems correct. But I wonder if the %ld is wrong. The field is really an int and we should probably use %d instead. Could you make this change and recompile?

BTW, I've seen a lot of %ld and casting things to long throughout the code base. This makes me nervous as a long is 64 bits for 64-bit compiles while an int is still just 32 bits.

Also, if you get a Mac makefile working, could you email me a copy (perhaps with instructions). I've had interest in a mac compile for Chengband before but could never oblige as I don't have access to a mac. My email address is ckousky at gmail dot com.

Thanks!
Yup, that fixed it. I actually didn't get the mac makefile working, since I have never gotten any of the mac makefiles for variants of earlier Angband versions to work with recent Mac OS X versions. I used the makefile.linux, and even then I had to get rid of the GCU code. So as far as I can tell one would need an Intel mac with X11 or XQuartz to use the binary I made. And as with the Halls of Mist binary, one will have to rename the save file to something like "501.<username>".
Darin is offline   Reply With Quote
Old January 21, 2013, 06:18   #36
Qyx
Apprentice
 
Join Date: Dec 2012
Posts: 64
Qyx is on a distinguished road
On starting the game, looked for help with selecting a race... got "Cannot open 'races.txt'..." Noticed the actual file in /lib is 'Races.txt'...
Qyx is offline   Reply With Quote
Old January 21, 2013, 14:55   #37
chris
PosChengband Maintainer
 
Join Date: Jan 2008
Posts: 702
chris is on a distinguished road
Quote:
Originally Posted by Qyx View Post
On starting the game, looked for help with selecting a race... got "Cannot open 'races.txt'..." Noticed the actual file in /lib is 'Races.txt'...
Thanks for the catch. It works OK on windows (case preserving) but not on linux (case sensitive). It will be fixed in the next release I push, but I'm generally waiting for game crash bugs to push new releases. In the meantime, you can rename the file as 'races.txt' and it should work for you. (Note: The helpfiles for Warlocks and Weaponmasters still need to be written).
chris is offline   Reply With Quote
Old January 21, 2013, 17:59   #38
AnonymousHero
Veteran
 
AnonymousHero's Avatar
 
Join Date: Jun 2007
Posts: 1,372
AnonymousHero is on a distinguished road
Quote:
Originally Posted by chris View Post
BTW, I've seen a lot of %ld and casting things to long throughout the code base. This makes me nervous as a long is 64 bits for 64-bit compiles while an int is still just 32 bits.
Yeah, this is really an annoying part of the C89 standard printf(). The only really portable way to get this working properly (without always casting) on 32 and 64 bit is to use format string defines, so something like:

Code:
#ifdef ON_64_BIT_PLATFORM
#define FMTs32 "%d"
#define FMTu32 "%u"
#else
#define FMTs32 "%ld"
#define FMTu32 "%lu"
#endif
and then use them as follows:

Code:
     int32_t foo = 123;
     printf("something " FMTs32 " something something.", x);
(note that int32_t is also C99.)

The only other way is simply using "int" everywhere, but that may not be sufficient on all compilers/platforms.
AnonymousHero is offline   Reply With Quote
Old January 28, 2013, 20:52   #39
Qyx
Apprentice
 
Join Date: Dec 2012
Posts: 64
Qyx is on a distinguished road
Maybe a dumb question... is there an easy way to avoid destroying scrolls of summons?
Qyx is offline   Reply With Quote
Old January 29, 2013, 04:48   #40
Qyx
Apprentice
 
Join Date: Dec 2012
Posts: 64
Qyx is on a distinguished road
Minor bug (or perhaps not, but seems like it might be):

Confusion affecting target after already slain:

>>You have slain the Novice rogue.
>>Your Claw stops glowing.
>>The Novice rogue appears confused.
Qyx is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
[Announce] NPPAngband 6.0.0 nppangband Variants 34 December 15, 2012 03:15
Announce: NPP 0.5.3 nppangband Variants 1 September 18, 2011 18:27
Announce: FayAngband 1.0 Mikko Lehtinen Variants 73 June 20, 2011 12:10
Gumband 2.3.1 Announce rdanhenry Variants 35 May 22, 2009 07:16
Announce: DaJAngband v1.0.03 will_asher Variants 4 February 6, 2008 21:23


All times are GMT +1. The time now is 17:27.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2021, vBulletin Solutions Inc.