r1946->r1948: angband: No town monsters!

[SaThaRiel]

Hi,

i upgraded today from SVN 1946 to 1948. Wanted to play my dwarf-paladin on my netbook. But i just received the above error message (X11 and GCU modes tested).
I installed 1948 today on another computer and was able to run the game with an old char and also make a new one (OS is the same, installation routine also).

After a downgrade to 1946 i was able to play as usual on my netbook. I can provide:
- compile Flags
- strace output
- configure/compile output
- savefile
if needed

[d_m]

Uh oh.

Sounds like MarbleDice's flags patch might have caused this.

[SaThaRiel]

Originally Posted by SaThaRiel

[...]I installed 1948 today on another computer and was able to run the game with an old char and also make a new one (OS is the same, installation routine also).[...]

Sorry for quoting myself but i feel that the sentence above is not clear enough. I could play a char which i played before with 3.1.1 - not with 1946. But it looks like you have already a good idea what happened

[Marble Dice]

The flags patch was large and extensive, and while it's quite likely to blame, I'm not sure I understand the behavior. You said you could run r1948 on one computer, but not your netbook? If that's the case, be sure you're not using an edited monster.txt file. I took a quick look and I don't see why the changes in r1948 would cause the game to fail loading the town monsters, and it works for me, so I'll have to keep searching.

[SaThaRiel]

I dont think its a netbook problem. Just this scenario:
- Char running under 1946 will throw this error after the upgrade to 1948. Downgraded to 1946 and i could start the game again.
- char running under 3.1.1 will run fine
- new char under 1948 also

So i would say that something between 1946 and 1948 has changed. The savefile doesnt seem to get touched, at least it wasnt corrupted.
As told before i can send some more info.

Edit: Same behavior from 1946->1950. May test if 1948->1950 works.

Another edit: The problem is solved - had to do a "make clean" before compiling Angband. Now it works. I thought that it would recompile all updated files and link the stuff together correctly. Well, need to learn a bit about make i fear

[Marble Dice]

Excellent, please keep an eye out for other strange behavior.

[PowerDiver]

Originally Posted by SaThaRiel

Well, need to learn a bit about make i fear

There is something a little strange with the current environment. I'll change an include file, run make and see it tell me it is creating dependencies, and then not recompile everything that includes the include file. If you don't know for sure what needs to be recompiled [so you can watch and check] I think you have to do a make clean first.

[SaThaRiel]

Well, i just included the make clean into the build script - so sure it takes a bit more time to compile but after all it works Just updated from 1950 to 1951 and my savefile loaded.
There was an warning somewhere on the rephial site that you should delete some files or risk a corrupt savefile. Is this not actual anymore? I am sure that i ran only once into a savefile corruption (without a new version) - must have been Angband 2.somthing and had no backup. So i always try to keep at least one actual savefile for such cases, but since the build script is available for everyone using ArchLinux, i think that i should add such a warning into the install routine.